[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Blocks|177841 (FE-NEEDSPONSOR) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Vasiliy Glazov vasc...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-09-06 07:50:27 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Rq6YlXib2Ja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aZvE1fvPIYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #42 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=l3AvuHrQ6Ia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404
--- Comment #39 from Steven Dake sd...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package requires other packages for directories it uses.
[X]: Package uses nothing in %doc for runtime.
[X]: Package is not known to require ExcludeArch.
[X]: Package complies to the Packaging Guidelines
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later), Unknown or generated. 2 files have unknown
license. Detailed output of licensecheck in /home/sdake/821404-gimp-dds-
plugin/licensecheck.txt
[X]: Package consistently uses macro is (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Package must own all directories that it creates.
[X]: Package does not own files or directories owned by other packages.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[X]: Package contains systemd file(s) if in need.
[X]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[X]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[X]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make.
[x]: SourceX tarball
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Steven Dake sd...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #40 from Steven Dake sd...@redhat.com --- APPROVED. Welcome to the packagers group! When you receive the packagers group welcome email, please submit an SCM request. Again my apologies for the 3 months delay. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vKwTpjZqZ0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Vasiliy Glazov vasc...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #41 from Vasiliy Glazov vasc...@gmail.com --- New Package SCM Request === Package Name: gimp-dds-plugin Short Description: A plugin for GIMP allows you to load/save in the DDS format Owners: vascom Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wEO30tgIX0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #36 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/gimp-dds-plugin/master/gimp-dds-plugin.spec SRPM URL: http://koji.russianfedora.ru/packages/gimp-dds-plugin/2.2.1/2.fc20.R/src/gimp-dds-plugin-2.2.1-2.fc20.R.src.rpm Done. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0lDsf9qzM6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Luya Tshimbalanga l...@fedoraproject.org changed: What|Removed |Added CC||l...@fedoraproject.org --- Comment #37 from Luya Tshimbalanga l...@fedoraproject.org --- *** Bug 988489 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GwJ79t5Araa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #38 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/gimp-dds-plugin/master/gimp-dds-plugin.spec SRPM URL: http://koji.russianfedora.ru/packages/gimp-dds-plugin/2.2.1/3.fc20.R/src/gimp-dds-plugin-2.2.1-3.fc20.R.src.rpm Updated for build with right CFLAGS. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sJV0m80uMna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404
--- Comment #34 from Vasiliy Glazov vasc...@gmail.com ---
I am not understand about directory %{_libdir}/gimp/2.0/plug-ins/dds. It owned
by this package. Why need adding %dir?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Xv8snxwPNMa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #35 from Steven Dake sd...@redhat.com --- nevermind unowned dir comment. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b7WdpZGZsea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Steven Dake sd...@redhat.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2om3yNIomBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404
--- Comment #33 from Steven Dake sd...@redhat.com ---
Vasiliy,
pkgconfig is not needed as a buildrequires - see:
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires
I believe this directory is unowned. This can be fixed by using a %dir for the
directory name, unless dds comes from another package.
%{_libdir}/gimp/2.0/plug-ins/dds
Once these issues are fixed, please submit a new spec url and srpm url and I'll
sponsor you and wrap up the review.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=bjouzINGvGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #32 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/gimp-dds-plugin/master/gimp-dds-plugin.spec SRPM URL: http://koji.russianfedora.ru/packages/gimp-dds-plugin/2.2.1/1.fc20.R/src/gimp-dds-plugin-2.2.1-1.fc20.R.src.rpm Done. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GAoFNmdHrTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #31 from Steven Dake sd...@redhat.com --- Vasiliy, Can you submit an SRPM and SPEC for the latest upstream version so I can wrap up the review and sponsorship? Thanks -steve -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kCJHylJQPha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #30 from Vasiliy Glazov vasc...@gmail.com --- OK. 2.2.1 - is the latest version. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OsyNntDXGta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Steven Dake sd...@redhat.com changed: What|Removed |Added Component|0x |Package Review --- Comment #29 from Steven Dake sd...@redhat.com --- Vasiliy, My sincere apologies for what appears to be abandoning this review. I can assure you this is not the case. I was on leave from work for personal reasons. I am happy to sponsor you and finish this review in the next week if you can provide an updated src.rpm with the latest upstream dds plugin. (latest upstream is required by review guidelines). Regards -steve -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nLCCbX6qSDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #27 from Vasiliy Glazov vasc...@gmail.com --- Can we continue? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Vasiliy Glazov vasc...@gmail.com changed: What|Removed |Added CC||dw...@infradead.org Component|Package Review |0x --- Comment #26 from Vasiliy Glazov vasc...@gmail.com --- How's it going? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #24 from Vasiliy Glazov vasc...@gmail.com --- Steven, are you still here? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #25 from Steven Dake sd...@redhat.com --- Yes still alive ;) thank you for pinging me. Looking back over this review request, the reviews you executed look good, so the next steps are for me to review your package followed by you submitting a scm request. Let me got on with my day a bit and I'll make a good effort to review your package today or early tomorrow. Regards -steve -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Vasiliy Glazov vasc...@gmail.com changed: What|Removed |Added CC||andreas.bierfert@lowlatency ||.de Component|Package Review |orange --- Comment #23 from Vasiliy Glazov vasc...@gmail.com --- I just remind about myself. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Component|orange |Package Review -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #21 from Vasiliy Glazov vasc...@gmail.com --- Steven, I return and ready to work. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #22 from Steven Dake sd...@redhat.com --- Vasiliy, Ok - will try to get back into this in next couple days - super busy at dayjob atm. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #20 from Steven Dake sd...@redhat.com --- Vasiliy, Congratulations on the wedding! When your prepared to continue the packaging process, please ping me in this bugzilla so I know your back. (I am sponsoring several new packagers, so need a bit of your help to keep on track of your sponsorship). Regards -steve -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Steven Dake sd...@redhat.com changed: What|Removed |Added Comment #15 is|1 |0 private|| --- Comment #18 from Steven Dake sd...@redhat.com --- Vasiliy, Your doing a good job of prepping for joining the packager group, but would you mind doing a full review on https://bugzilla.redhat.com/show_bug.cgi?id=840551? This includes filling in the [ ] spots in the review. Regards -steve -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #19 from Vasiliy Glazov vasc...@gmail.com --- Done https://bugzilla.redhat.com/show_bug.cgi?id=840551 Steven, please freeze my joining the packager group for three weeks. I'm going to honeymoon :) But after that I will continue to work with you. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #14 from Vasiliy Glazov vasc...@gmail.com --- Do I understand correctly that if [], then I check manually and enter [N/A] or [X] or [!] ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404
--- Comment #16 from Jeff Peeler jpee...@redhat.com ---
For future reference, mktables.c and dxt_tables.h have no license header. Not a
problem, but might want to make it consistent.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[X]: MUST Package does not contain kernel modules.
[X]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[X]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[X]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[X]: MUST Package contains no bundled libraries.
[X]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[X]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[X]: MUST Package requires other packages for directories it uses.
[X]: MUST Package uses nothing in %doc for runtime.
[X]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[X]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[X]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
*No copyright* UNKNOWN, GPL (v2 or later) For detailed output of
licensecheck see file: /home/jpeeler/reviews/821404-gimp-dds-
plugin/licensecheck.txt
[X]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[X]: MUST Package is named according to the Package Naming Guidelines.
[X]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[X]: MUST Package obeys FHS, except libexecdir and /usr/target.
[X]: MUST Package must own all directories that it creates.
[X]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[X]: MUST Package is not relocatable.
[X]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[X]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[X]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[X]: SHOULD Latest version is packaged.
[X]: SHOULD Package does not include license text files separate from
upstream.
[-]: SHOULD Patches link
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #17 from Vasiliy Glazov vasc...@gmail.com --- Now everything is done correctly? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #9 from Vasiliy Glazov vasc...@gmail.com --- OK. My first review https://bugzilla.redhat.com/show_bug.cgi?id=840551 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #10 from Vasiliy Glazov vasc...@gmail.com --- And second review https://bugzilla.redhat.com/show_bug.cgi?id=840425 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #11 from Steven Dake sd...@redhat.com --- Vasiliy, Review in comment #9 is a bit odd. You ask the package review reporter t o run fedora review. It is the packager reviewer (ie your) job to run fedora review. The second review looks pretty good. Could you run through fedora review with them, then once they look solid, I'll finish reviewing your package? Thanks -steve -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #12 from Vasiliy Glazov vasc...@gmail.com --- I understand about fedora-review. And I think review 840425 is done. The package meets all requirements except using macro in Source0. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #13 from Steven Dake sd...@redhat.com --- Vasiliy, I see in 840425 you did provide a full review in comment #10. Unfortunately many of the [ ] are empty, which leaves the impression to the git admins that the review is still pending. You need to make sure to fill out each field (notice - for N/A). Could you take another spin at that one? overall looking good. Thanks -steve -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #7 from vasc...@gmail.com --- Плагин is the russian translate of plugin. http://ru.wikipedia.org/wiki/%D0%9F%D0%BB%D0%B0%D0%B3%D0%B8%D0%BD - in russian http://en.wikipedia.org/wiki/Plug-in_(computing) - in english It is correct translation. I dont know why spellchecker warning about it. FSF address patch added Spec URL: https://raw.github.com/RussianFedora/gimp-dds-plugin/master/gimp-dds-plugin.spec SRPM URL: http://koji.russianfedora.ru/packages/gimp-dds-plugin/2.1.0/2.fc18.R/src/gimp-dds-plugin-2.1.0-2.fc18.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Steven Dake sd...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|sd...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 Steven Dake sd...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #8 from Steven Dake sd...@redhat.com --- Vascom2, I'll sponsor you. To join the packager group you need to be able to do the following things: 1. provide competent reviews of other people's packages 2. produce high quality packaging that passes the guidelines prior to review 3. help coach packagers on trouble points in their packaging Read: http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group A package should follow the packaging guidelines: http://fedoraproject.org/wiki/Packaging:Guidelines Since you have submitted a package, I will ask you in the bugzilla to review a couple other people's packages. While you are not a packager, you can still provide reviews to demonstrate you are capable of providing a review of a new package. To execute a review, you would follow the review guidelines: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines Some example reviews I have done are here: https://bugzilla.redhat.com/buglist.cgi?f1=flagtypes.namelist_id=79500o1=equalsclassification=Fedoraemailtype1=substringquery_format=advancedemailassigned_to1=1token=1338582948-9534ec43e4e74cdb0393ec72859aedfebug_status=NEWbug_status=ASSIGNEDbug_status=MODIFIEDbug_status=ON_DEVbug_status=ON_QAbug_status=VERIFIEDbug_status=RELEASE_PENDINGbug_status=POSTbug_status=CLOSEDemail1=sdake%40redhat.comv1=fedora-review%2Bcomponent=Package%20Review Once you have given a couple high quality reviews of other's packages, I'll review your package submission and we will get it beat into submission for Fedora. When your ready to review atleast two other packages, find some FE-NEEDSPONSOR packages and use the FedoraReview tool to review those packages. The FedoraReview tool can be found at: https://fedorahosted.org/FedoraReview/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #4 from vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/gimp-dds-plugin/master/gimp-dds-plugin.spec SRPM URL: http://koji.russianfedora.ru/packages/gimp-dds-plugin/2.1.0/1.fc18.R/src/gimp-dds-plugin-2.1.0-1.fc18.R.src.rpm All done. 1. Removed unneeded defattr in files section. 2. FSF address upstream notify http://code.google.com/p/gimp-dds/issues/detail?id=17 3. Changelog corrected. 4. fedora-review done. Log attached. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #5 from vasc...@gmail.com --- Created attachment 597985 -- https://bugzilla.redhat.com/attachment.cgi?id=597985action=edit fedora-review log -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #6 from Jeff Peeler jpee...@redhat.com --- Great to see your patch applied upstream so quickly. Until that patch makes it into a release, you'll need to apply it in your spec file. See: http://fedoraproject.org/wiki/Packaging/PatchUpstreamStatus Send an email to the maintainer pointing out this request request if you haven't already. Also any idea on this spelling: Плагин - Плагиат? The rpmlint output really should be silent except in special cases that do not appear to apply here. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404
Jeff Peeler jpee...@redhat.com changed:
What|Removed |Added
CC||jpee...@redhat.com
--- Comment #3 from Jeff Peeler jpee...@redhat.com ---
Next steps:
1) Remove unneeded defattr in files section.
2) Need to notify upstream about the FSF address being incorrect
(http://www.fsf.org/about/contact/) in the headers and source files, preferably
with a patch. Then either import upstream's changes or link to upstream note
with a patch.
3) Changelog should match the RPM version. Also you might as well declare
version 2.1.0 as the initial release and remove the other entries.
4) Run fedora-review when completed so you can correct the minor issues before
getting an official review.
I believe it is ok that your source line does not use the name macro, since the
package probably should have the -plugin suffix.
(Unofficial) Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package contains desktop file if it is a GUI application.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
*No copyright* UNKNOWN, GPL (v2 or later) (with incorrect FSF
address) For detailed output of licensecheck see file:
/home/jpeeler/821404-gimp-dds-plugin/licensecheck.txt
[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[ ]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[ ]: MUST Spec file is legible and written in American
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #2 from vasc...@gmail.com --- Update to 2.1.0 Spec URL: https://raw.github.com/RussianFedora/gimp-dds-plugin/master/gimp-dds-plugin.spec SRPM URL: http://koji.russianfedora.ru/packages/gimp-dds-plugin/2.1.0/1.fc17.R/src/gimp-dds-plugin-2.1.0-1.fc17.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=821404 --- Comment #1 from vasc...@gmail.com 2012-05-14 08:00:45 EDT --- SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=36027name=gimp-dds-plugin-2.0.9-2.fc17.R.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821404] Review Request: gimp-dds-plugin - A plugin for GIMP allows to load/save in the DDS format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=821404 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added CC||lemen...@gmail.com Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
