[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- erlang-egeoip-0-0.3.20111025git45c32ad.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-16 19:57:08 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- erlang-egeoip-0-0.3.20111025git45c32ad.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- erlang-egeoip-0-0.3.20111025git45c32ad.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #5) full review below. Some notes: - could you make the build more verbose (by passing REBAR_FLAGS=-v ?) - the comment regarding the Open Data license needs to be updated -- probably remove the AFAIK and IANAL part since spot and the legal team has reviewed it - defattr needs removing All done, and thanks for the review! Updated packages: * http://peter.fedorapeople.org/erlang-egeoip.spec * http://peter.fedorapeople.org/erlang-egeoip-0-0.3.20111025git45c32ad.fc18.src.rpm Koji scratchbuild for Rawhide: * http://koji.fedoraproject.org/koji/taskinfo?taskID=4135307 New Package SCM Request === Package Name: erlang-egeoip Short Description: Erlang IP Geolocation module Owners: peter Branches: f16 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- erlang-egeoip-0-0.3.20111025git45c32ad.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/erlang-egeoip-0-0.3.20111025git45c32ad.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- erlang-egeoip-0-0.3.20111025git45c32ad.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/erlang-egeoip-0-0.3.20111025git45c32ad.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- erlang-egeoip-0-0.3.20111025git45c32ad.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/erlang-egeoip-0-0.3.20111025git45c32ad.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- erlang-egeoip-0-0.3.20111025git45c32ad.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 Michel Alexandre Salim michel+...@sylvestre.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||michel+...@sylvestre.me Assignee|nob...@fedoraproject.org|michel+...@sylvestre.me Flags||fedora-review? --- Comment #4 from Michel Alexandre Salim michel+...@sylvestre.me --- Taking this review -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845
Michel Alexandre Salim michel+...@sylvestre.me changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Michel Alexandre Salim michel+...@sylvestre.me ---
full review below. Some notes:
- could you make the build more verbose (by passing REBAR_FLAGS=-v ?)
- the comment regarding the Open Data license needs to be updated -- probably
remove the AFAIK and IANAL part since spot and the legal team has reviewed it
- defattr needs removing
You can fix that when importing though. The rest are the same RHEL-related
issues discussed in previous reviews.
APPROVED
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[!]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Could not retrieve sources. Please check the source files for
licenses manually.
[!]: MUST Package consistently uses macros (instead of hard-coded directory
names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
No meaningful
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 --- Comment #3 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #2) Thats a fun new variant of BSD with advertising. Just add BSD with advertising to the License: tag in the package. Lifting FE-Legal. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
https://bugzilla.redhat.com/show_bug.cgi?id=821845 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 | --- Comment #2 from Tom spot Callaway tcall...@redhat.com --- Thats a fun new variant of BSD with advertising. Just add BSD with advertising to the License: tag in the package. Lifting FE-Legal. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821845] Review Request: erlang-egeoip - Erlang IP Geolocation module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=821845 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2012-05-15 11:00:00 EDT --- Cast wizards - raise magic FE-Legal flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
