[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libzen-0.4.29-2.fc19|libzen-0.4.29-2.el6 --- Comment #59 from Fedora Update System upda...@fedoraproject.org --- libzen-0.4.29-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y9C8zWOh8xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libzen-0.4.29-2.fc18 Resolution|--- |ERRATA Last Closed||2013-08-20 20:04:43 --- Comment #57 from Fedora Update System upda...@fedoraproject.org --- libzen-0.4.29-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5bgxyPsoxUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|libzen-0.4.29-2.fc18|libzen-0.4.29-2.fc19 --- Comment #58 from Fedora Update System upda...@fedoraproject.org --- libzen-0.4.29-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LOXwg9toQPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FhCaF9F7xVa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #53 from Fedora Update System upda...@fedoraproject.org --- libzen-0.4.29-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libzen-0.4.29-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x0oARL237ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #54 from Fedora Update System upda...@fedoraproject.org --- libzen-0.4.29-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libzen-0.4.29-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9D9mO10m4Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #55 from Fedora Update System upda...@fedoraproject.org --- libzen-0.4.29-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/libzen-0.4.29-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GiurwbNdZpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #56 from Fedora Update System upda...@fedoraproject.org --- libzen-0.4.29-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=esXFxOpmRGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Vasiliy Glazov vasc...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #49 from Vasiliy Glazov vasc...@gmail.com --- New Package SCM Request === Package Name: libzen Short Description: Shared library for libmediainfo and medianfo Owners: vascom Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KfI2JVCZgva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #50 from Vasiliy Glazov vasc...@gmail.com --- New Package SCM Request === Package Name: libzen Short Description: Shared library for libmediainfo and mediainfo Owners: vascom Branches: f18 f19 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=exbKriq5zTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #51 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=adkWp2asFpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FDGN4H9fYPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #52 from Vasiliy Glazov vasc...@gmail.com --- Christopher, which requests are you referring to? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vCc9HZAQBia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #48 from Christopher Meng cicku...@gmail.com --- APPROVED. Please understand workflow of fedpkg asap, I see many requests are not imported int SCM. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TZkPM5HwURa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zKoL8L8nFga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #44 from Ralf Corsepius rc040...@freenet.de --- (In reply to Christopher Meng from comment #43) you should use find to find the la files Says who? The only thing that matters is that they are removed. There are many ways to achieve this. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d534mgbw6Ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #45 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=82976name=libzen-0.4.29-2.fc20.R.src.rpm 0. Updated to 2.4.29. 1. Suffix .R removed. 2. install -p added. 3. .la files removed. 4. pkgconfig sed already fixed in 2.4.29 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0gPsIKeTFUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #46 from Christopher Meng cicku...@gmail.com --- Ralf, do you still have questions against this package here? If not, I will change flag. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=79Qp5R1rNha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #47 from Michael Schwendt bugs.mich...@gmx.net --- From comment 3: * Do not ship static libs (*.a) * Do not ship libtool *.la's That has been very clear, IMO. Except that the packaging guidelines ought to comment on libtool archives in a separate section and not in the static libs section. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o0YOUjwLCMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Michael Schwendt bugs.mich...@gmx.net changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=09YTmufMYRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
https://bugzilla.redhat.com/show_bug.cgi?id=822329 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com --- Comment #43 from Christopher Meng cicku...@gmail.com --- Seems this package is messy. Issues: 1. Please fix changelog contains .R stuffs of RussianFedora, I don't want to see again of it. 2. Please preserve the timestamps by install -p. 3. Ralf is not correct, you should use find to find the la files and -delete them, or just rm, do NOT ship any libtool files. 4. Please notify upstream about pkgconfig sed fix. Once fixed, this will get approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MtKVHWNUGBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #42 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/packages/libzen/0.4.28/7.fc18.R/src/libzen-0.4.28-7.fc18.R.src.rpm Increased version. Done the same changes for libmediainfo https://bugzilla.redhat.com/show_bug.cgi?id=822328 mediainfo https://bugzilla.redhat.com/show_bug.cgi?id=822327 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=axRlqeNaIoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #41 from Vasiliy Glazov vasc...@gmail.com --- OK, it will be done soon. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9TUOlcMN6Xa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #40 from Nikita Klimov n...@jaur.su ---
Hi Vasiliy,
Are you still interested in adding mediainfo and related packages in fedora? If
so, I suggest to work closely on correcting existing errors. After the packages
are ready, I think you will find a sponsor. Please, will increase the version
of the libzen package and add a comment to %{changelog} section. Also, please
fix errors that were identified in this review, in packages libmedianfo and
mediainfo.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=ZIazlVmFnJa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #39 from Nikita Klimov n...@jaur.su --- Hi Vasiliy, - Every time you make changes, that is, whenever you increment the E-V-R of a package, add a changelog entry. This is important not only to have an idea about the history of a package, but also to enable users, fellow packages, and QA people to easily spot the changes that you make. http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs Please don't forgot about it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JnS2tFfD9na=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #31 from Ralf Corsepius rc040...@freenet.de --- (In reply to comment #27) Because when it created it empty. Then fix it. This is an arched package, so debuginfo files are mandatory. In other words something is defective and you (the prospective packager) are supposed to fix it. In case wasn't clear enough: This is a MUSTFIX. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PH2RLpk502a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #32 from Vasiliy Glazov vasc...@gmail.com --- OK. I change make install-strip to make install. And create debuginfo subpackage. Fixed. Some wildcards in %files section removed. dos2unix removed. Instead it used sed. ./autogen - is upstream authors script $ cat rpmbuild/BUILD/ZenLib/Project/GNU/Library/autogen #libtoolize if test $(uname) = Darwin ; then #Darwin based Systems like Mac OS X: libtoolize is called glibtoolize. glibtoolize --automake else libtoolize --automake fi #aclocal if test -e /usr/bin/aclocal-1.11 ; then #OpenSolaris: no aclocal aclocal-1.11 elif test -e /usr/bin/aclocal-1.10 ; then aclocal-1.10 else aclocal fi #automake if test -e /usr/bin/automake-1.11 ; then #OpenSolaris: no automake automake-1.11 -a elif test -e /usr/bin/automake-1.10 ; then automake-1.10 -a else automake -a fi autoconf -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4Lzbs3dCPxa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #33 from Ralf Corsepius rc040...@freenet.de ---
(In reply to comment #31)
(In reply to comment #27)
Because when it created it empty.
Then fix it. This is an arched package, so debuginfo files are mandatory.
In other words something is defective and you (the prospective packager) are
supposed to fix it.
This is the cause:
%install
pushd Project/GNU/Library
make install-strip DESTDIR=%{buildroot}
popd
Invoke make install instead of make install-strip.
(Background: executables must not be stripped for debuginfo generateion.
Rpm automatically strips them later.
Finally there are more questionable items in your spec:
* autogen is supposed to be run in %prep (not in %build)
* you are passing --disable-static to %configure
= find %{buildroot} -name '*.a' -exec rm -f {} ';'
is superfluous.
* Many source files carry bogus permissions. chmod -x them in %
A visible symptom is rpmlint complaining about files in *debuginfo:
...
libzen-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/ZenLib/Source/ZenLib/Format/Http/Http_Cookies.cpp
libzen-debuginfo.x86_64: E: wrong-script-end-of-line-encoding
/usr/src/debug/ZenLib/Source/ZenLib/Format/Http/Http_Cookies.cpp
libzen-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/ZenLib/Source/ZenLib/ZtringListListF.h
...
* Another MUSTFIX:
libzen-devel.x86_64: E: script-without-shebang /usr/bin/libzen-config
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=NXmi79YqQLa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #34 from Ralf Corsepius rc040...@freenet.de --- (In reply to comment #32) OK. I change make install-strip to make install. And create debuginfo subpackage. Fixed. Some wildcards in %files section removed. dos2unix removed. Instead it used sed. ./autogen - is upstream authors script Forget about it. It's crap. Use autoreconf or switch to using patches -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dM4IU1glcLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #35 from Vasiliy Glazov vasc...@gmail.com ---
Corrected SPEC: https://raw.github.com/RussianFedora/libzen/master/libzen.spec
Corrected SRPM:
http://koji.russianfedora.ru/koji/getfile?taskID=71532name=libzen-0.4.28-6.fc19.R.src.rpm
Removed find %{buildroot} -name '*.a' -exec rm -f {} ';
And corrected others. Added shebang. Moved ./autogen to %prep. All
spurious-executable-perm and wrong-script-end-of-line-encoding corrected.
But I am not sure what i must write instead of ./autogen, because if I use
autoreconf it causes errors and can't compile. Why we can't use ./autogen?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=fognbQ7E2Da=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #36 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=71532name=libzen-0.4.28-6.fc19.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KaVetMyUFJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #37 from Jérôme Martinez jer...@mediaarea.net --- (In reply to comment #35) But I am not sure what i must write instead of ./autogen, because if I use autoreconf it causes errors and can't compile. I think it is OK with: autoreconf -i -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GPOQpWaXDoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #38 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=71538name=libzen-0.4.28-6.fc19.R.src.rpm Thanks, changed ./autogen to autoreconf -i. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Yy9q59ydJRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #24 from Nikita Klimov n...@jaur.su ---
Hi Vasiliy,
This is my informal review:
Issues:
===
- All build dependencies are listed in BuildRequires, except for any that are
listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- Large documentation must go in a -doc subpackage.
Note: Documentation size is 4177920 bytes in 290 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[!]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #25 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=71522name=libzen-0.4.28-6.fc19.R.src.rpm Created doc subpackage. Disabled debuginfo subpackage generation. Removed gcc-c++ from BR. Jérôme, can you add shebang to /usr/bin/libzen-config? It mean add #!/bin/bash to first line. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IV5XJgySpfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #26 from Ralf Corsepius rc040...@freenet.de --- (In reply to comment #25) Disabled debuginfo subpackage generation. Why? I can't imagine any valid reason, why debuginfos should be disabled. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=47x4rCuLsna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #27 from Vasiliy Glazov vasc...@gmail.com --- Because when it created it empty. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IOI28BTBsla=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #28 from Eduardo Echeverria echevemas...@gmail.com --- Hi Vasily, please read http://fedoraproject.org/wiki/Packaging:Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_packaging_issues Btw, you thought use autoreconf instead of . /autogen? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7Y8s63qKAUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #29 from Eduardo Echeverria echevemas...@gmail.com --- other comments: - Why use dosunix, if you can do the same with thirst?. - Please do not use wildcards to install the files that are in directories, it is implied that you are installing the entire directory and not only part of the files that are contained in the same -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vp7EfAChm1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #30 from Eduardo Echeverria echevemas...@gmail.com --- I'm sorry, I meant sed, not thirst -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E4xuY5scvfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #23 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=71294name=libzen-0.4.28-5.fc19.R.src.rpm All done. Old %changelog entries will be removed later. All links direct. Or you want link without ? and ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4htooXRE2Qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #16 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=71133name=libzen-0.4.28-4.fc19.R.src.rpm 1. License corrected. 2. Wildcard removed. 3. Done for all except %configure, because it not just ./configure. Right? 4. You mean that I should inform upstream about obsoleted tags 'DETAILS_AT_TOP' and 'HTML_ALIGN_MEMBERS'? Added command doxygen -u Doxyfile 5. I am not sure about nonstandard commands, because I copied it from original spec http://sourceforge.net/p/zenlib/code/HEAD/tree/ZenLib/trunk/Project/GNU/libzen.spec 6. Removed RFRemix tags from %changelog. 7. Yes I read it, and I almost get sponsor here https://bugzilla.redhat.com/show_bug.cgi?id=821404 but he lost :( I already made some review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sR8ZTWHdNUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #17 from Jérôme Martinez jer...@mediaarea.net --- 4. You mean that I should inform upstream about obsoleted tags 'DETAILS_AT_TOP' and 'HTML_ALIGN_MEMBERS'? I will update my doxygen file soon with an up to date version. 5. I am not sure about nonstandard commands, because I copied it from original spec Actually, I, the upstream developper, am not expert of Makefile/spec files, any help would be appreciated to to make it standard (e.g. in Makefile rather than in spec file) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=n0Qy4yO45ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #18 from Vasiliy Glazov vasc...@gmail.com ---
Jérôme, very glad for your respond.
Please do next:
1. Correct file encoding and remove executable bits from documentation in
source package:
dos2unix *.txt Source/Doc/Documentation.html
chmod 644 *.txt Source/Doc/Documentation.html
2. Make install headers and development files, than i remove this from spec:
# Zenlib headers and ZenLib-config
install -dm 755 %{buildroot}%{_includedir}/ZenLib
install -m 644 Source/ZenLib/*.h \
%{buildroot}%{_includedir}/ZenLib
for i in HTTP_Client Format/Html Format/Http; do
install -dm 755 %{buildroot}%{_includedir}/ZenLib/$i
install -m 644 Source/ZenLib/$i/*.h \
%{buildroot}%{_includedir}/ZenLib/$i
done
sed -i -e 's|Version: |Version: %{version}|g' \
Project/GNU/Library/%{name}.pc
install -dm 755 %{buildroot}%{_libdir}/pkgconfig
install -m 644 Project/GNU/Library/%{name}.pc \
%{buildroot}%{_libdir}/pkgconfig
3. I think you can remove *.la and *.a files automatically if shared compile
enabled.
Normal spec - if sections %prep %build %install contain 1-2 commands.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=yfwhAgm3Sua=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #19 from Jérôme Martinez jer...@mediaarea.net --- 1. Correct file encoding and remove executable bits from documentation in source package: Source package is created from a Windows machine so executable bit is set by default everywhere during tar.bz2 creation, and it is intended for different platforms, so documentation has \r\n. I don't plan to force my source files to Linux line ending. But it is maybe possible to put dos2unix and chmod in the Makefile if there is a way to detect the platform (if not Windows or Mac, run dos2unix) 2. Make install headers and development files, than i remove this from spec: I am a total newbee in Makefile, I am aware it should be in Makefile, but I currently don't know how to do it. Sorry, but I currently lack of time to learn this, any patch for Makefile would be appreciated. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bdE2UNWPvca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #20 from Vasiliy Glazov vasc...@gmail.com --- I think now we can leave it as is. Because all installed and work very good. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nb8Uy9QPVBa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #21 from Nikita Klimov n...@jaur.su ---
Hi Vasiliy,
- we must correct my mistake with license. Valid license short name for
zlib/libpng license is 'zlib'
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses .
Please correct it.
- If you want to be maintainer this package in Fedora, you must be extremely
familiar with its contents. Software components included in Fedora needs to be
maintained actively and bugs, especially security issues needs to be fixed in a
timely manner. As a Fedora package maintainer, it is your primary
responsibility to ensure this.
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Understand_your_responsibilities
Please do all steps in spec file by hand, not using RPM system, and comment all
tasks.
- Rebuild SRC RPM with new spec file and give direct link to it.
Almost all other, in my opinion is fine, except comments in %{changelog}
section, but it no so necessary in this stage.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=13khX8pEP0a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #22 from Jérôme Martinez jer...@mediaarea.net --- - If you want to be maintainer this package in Fedora, you must be extremely familiar with its contents. FYI, the maintainer of Fedora package will have full bugs and security support from upstream, MediaInfo (the tool which needs this package) is maintained for 10 years and security is very important for the company behind it, security issues will be fixed in a timely manner directly from upstream, the maintainer will only have to update the package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OZfULru2JKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #15 from Nikita Klimov n...@jaur.su ---
Unfortunately, there are a number of comments:
- In License: section replace 'zlib/libpng License' to 'zlib/libpng'
- dos2unix *.txt Source/Doc/*.html - dos2unix *.txt
Source/Doc/Documentation.html (wildcard in my opinion not need)
- Please don't ignore any remark:
Macro forms of system executables SHOULD NOT be used except when there is a
need to allow the location of those executables to be configurable. For
example, rm should be used in preference to %{__rm}, but %{__python} is
acceptable.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
For example:
%__chmod - chmod
If you disagree with any remark, explain your point of view, but don't ignore
it.
- Doxygen's tags 'DETAILS_AT_TOP' and 'HTML_ALIGN_MEMBERS' has become obsolete,
please contact upstream. Temporary you can use:
doxygen -u
before generate documentation.
- Do more informative comments in %{changelog} section. For example 'Clean
spec' and 'Spec prepared for review' not informative.
This is important not only to have an idea about the history of a package, but
also to enable users, fellow packages, and QA people to easily spot the changes
that you make.
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
- Please add short informative comments to %{prep}, %{build} and %{install}
section before any 'nonstandart' tasks, that explains why this task necessary.
- I know that you are also maintainer in RFRemix project, but in this stage it
doesn't matter. We have to prepare the package for inclusion in Fedora, not
RFRemix. And so the package must comply with Fedora rules. Please remove
RFRemix tags in %{changelog} section.
- Do you read this
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Convincing_someone_to_sponsor_you
? Please try to doing informal reviews to other packagers in order to find and
convincing a willing sponsor. I can help fix errors and omissions in package,
but can't be a sponsor, and so can't do formal review, because review and
approval for the first package for new packagers must be done by registered
sponsors.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=6RoSwWxRGia=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #12 from Vasiliy Glazov vasc...@gmail.com --- I'll remove %__chmod +x autogen. But simple autoconf not work. I think ./autogen is needed. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rsGNNurN26a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #13 from Nikita Klimov n...@jaur.su --- (In reply to comment #12) I'll remove %__chmod +x autogen. But simple autoconf not work. I think ./autogen is needed. Oh, sorry. You are right :) Please correct other remarks and update links to spec file and source RPM. I'll do a detailed review tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yYDC8ubwFLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #14 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://github.com/RussianFedora/libzen/blob/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=70806name=libzen-0.4.28-3.fc19.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GXdGonFG1Va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #10 from Vasiliy Glazov vasc...@gmail.com ---
Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec
SRPM URL:
http://koji.russianfedora.ru/koji/getfile?taskID=70536name=libzen-0.4.28-2.fc19.R.src.rpm
Almost all corrected.
I correct %{changelog} when package will be included in Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=dorKzSi8T6a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
--- Comment #11 from Nikita Klimov n...@jaur.su ---
- Macro forms of system executables SHOULD NOT be used except when there is a
need to allow the location of those executables to be configurable. For
example, rm should be used in preference to %{__rm}, but %{__python} is
acceptable.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
- Use %{buildroot} and %{optflags} or $RPM_BUILD_ROOT and $RPM_OPT_FLAGS but
not %{buildroot} and $RPM_OPT_FLAGS or $RPM_BUILD_ROOT and %{optflags}
https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
In my opinion %{buildroot} and %{optflags} a little more beautiful but ypu can
use $RPM_BUILD_ROOT and $RPM_OPT_FLAGS if you prefer it.
- Take a look at line 63 in spec file:
63 %__chmod +x autogen
There is no need, since executable bit also set.
- Take a look at line 64:
64 ./autogen
There is also no need, simply use autoconf.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=yojgqzHWo1a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=822329
Nikita Klimov n...@jaur.su changed:
What|Removed |Added
CC||n...@jaur.su
--- Comment #9 from Nikita Klimov n...@jaur.su ---
Hi Vasiliy
- libzen should be released with zlib/libpng license. Why are you using LGPLv3
in spec file?
- Please add short informative comments in %{build} and %{install} section
- The package must be consistent. For any given path, within the same spec,
use either a hard-coded path or a macro, not a combination of the two.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#macros
A good solution will use %{name} macro where you can.
- In my opinion it's not necessary in spec file:
42 # Fix up Makefile.am
43 cat EOF Project/GNU/Library/Makefile.am
44
45 bin_SCRIPTS = libzen-config
46
47 pkgconfigdir = \$(libdir)/pkgconfig
48 pkgconfig_DATA = libzen.pc
49
50 EOF
Upstream file also included this lines, and you are simply doubled it.
- Please remove Russian Fedora tags in %{changelog} section.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=9733dfMjMGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #8 from Vasiliy Glazov vasc...@gmail.com --- Spec URL: https://raw.github.com/RussianFedora/libzen/master/libzen.spec SRPM URL: http://koji.russianfedora.ru/packages/libzen/0.4.28/1.fc18.R/src/libzen-0.4.28-1.fc18.R.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BxcT9J3cCMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822329 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Blocks||822328 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qtKoW1iSBea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #6 from vasc...@gmail.com 2012-05-18 03:08:27 EDT --- Corrected SPEC: https://github.com/RussianFedora/libzen/blob/master/libzen.spec Corrected SRPM: http://koji.russianfedora.ru/packages/libzen/0.4.26/3.fc17.R/src/libzen-0.4.26-3.fc17.R.src.rpm I add you patch and libzen-config to devel. Now all OK? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Blocks||822327 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 Jérôme Martinez jer...@mediaarea.net changed: What|Removed |Added CC||jer...@mediaarea.net --- Comment #7 from Jérôme Martinez jer...@mediaarea.net 2012-05-18 11:32:21 EDT --- (In reply to comment #3) Then you will want to look again - There are plenty of differences, primarily related to building the package, because upstream's configuration is a dysfunctional mess ;) As the original developer of the spec file, I agree ;-). It was made quickly for my own needs (different configs, different distros), without a lot of knowledge about RPM, and it is definitely ugly. * Wrt. the license: The package contains an LGPL'ed file = This file's license outrules the license from License.txt and renders this package as a whole LGPL'ed. Corrected in the SVN: https://sourceforge.net/p/zenlib/code/398/ The intended license is definitely zlib license for this package. (In reply to comment #5) They are shipping libzen-config inside of their sources, but miss to install it Error from me. It is expected to be installed for people not using pkg-config. I corrected it in the SVN: https://sourceforge.net/p/zenlib/code/399/ Jérôme, developer of mediainfo/libmediainfo and the tiny ugly libzen library used by mediainfo/libmediainfo. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #2 from vasc...@gmail.com 2012-05-17 02:01:34 EDT --- Ralf Corsepius, I don't see sufficient difference. But why you choose License:LGPLv3 I think this wrong. http://sourceforge.net/p/zenlib/code/397/tree/ZenLib/trunk/License.txt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #3 from Ralf Corsepius rc040...@freenet.de 2012-05-17 02:24:18 EDT --- Then you will want to look again - There are plenty of differences, primarily related to building the package, because upstream's configuration is a dysfunctional mess ;) Some remarks for now: * Do not ship static libs (*.a) * Do not ship libtool *.la's * Last time I checked, the upstream's libzen-config was dysfunctional I added a patch to my package to work around this. * Wrt. the license: The package contains an LGPL'ed file: # grep License Source/ZenLib/* Source/ZenLib/PreComp.h:// under the terms of the GNU Lesser General Public License as published by Source/ZenLib/PreComp.h:// the Free Software Foundation, either version 3 of the License, or Source/ZenLib/PreComp.h:// GNU Lesser General Public License for more details. Source/ZenLib/PreComp.h:// You should have received a copy of the GNU Lesser General Public License = This file's license outrules the license from License.txt and renders this package as a whole LGPL'ed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #4 from vasc...@gmail.com 2012-05-17 03:05:38 EDT --- Corrected SPEC: https://github.com/RussianFedora/libzen/blob/master/libzen.spec Corrected SRPM: http://koji.russianfedora.ru/packages/libzen/0.4.26/2.fc17.R/src/libzen-0.4.26-2.fc17.R.src.rpm I don't see libzen-config in package from mediainfo at all http://mediainfo.sourceforge.net/en/Download/Fedora http://downloads.sourceforge.net/zenlib/libzen0-0.4.26-1.i386.Fedora_16.rpm Other remarks I am corrected. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 --- Comment #5 from Ralf Corsepius rc040...@freenet.de 2012-05-18 00:44:42 EDT --- (In reply to comment #4) I don't see libzen-config in package from mediainfo at all http://mediainfo.sourceforge.net/en/Download/Fedora http://downloads.sourceforge.net/zenlib/libzen0-0.4.26-1.i386.Fedora_16.rpm As I said before, upstream's configuration is pretty messy ... and so is their packaging. They are shipping libzen-config inside of their sources, but miss to install it in their rpms: # tar tjvf libzen_0.4.26.tar.bz2 | grep config -rwxrwxrwx 0/09714 2012-04-08 14:50 ZenLib/Project/GNU/Library/configure.ac -rwxrwxrwx 0/0 340 2011-10-13 09:50 ZenLib/Project/GNU/Library/libzen-config.in -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 vasc...@gmail.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822329] Review Request: libzen - Shared library for libmediainfo and medianfo
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822329 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added CC||rc040...@freenet.de --- Comment #1 from Ralf Corsepius rc040...@freenet.de 2012-05-17 01:44:11 EDT --- FYI: You may want to compare your packages against those I ship through packman: http://ftp.gwdg.de/pub/linux/misc/packman/fedora/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
