[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Fedora Update System changed: What|Removed |Added Fixed In Version||libesedb-20120102-7.el7 Resolution|NEXTRELEASE |ERRATA --- Comment #18 from Fedora Update System --- libesedb-20120102-7.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #17 from Fedora Update System --- libesedb-20120102-7.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/libesedb-20120102-7.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #16 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Michal Ambroz changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Michal Ambroz --- Package Change Request == Package Name: libesedb New Branches: epel7 Owners: rebus Hello SCM team, plase can you add epel7 branch for the libesedb package? Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=822718 Mario Blättermann changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-11-15 04:33:14 --- Comment #14 from Mario Blättermann --- Packages are marked as stable now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #13 from Fedora Update System --- libesedb-20120102-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #12 from Fedora Update System --- libesedb-20120102-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/libesedb-20120102-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #11 from Fedora Update System --- libesedb-20120102-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libesedb-20120102-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #10 from Fedora Update System --- libesedb-20120102-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libesedb-20120102-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Michal Ambroz changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Michal Ambroz --- Hello SCM team, please can you create new package? New Package SCM Request === Package Name: libesedb Short Description: Library to access the Extensible Storage Engine (ESE) Database File (EDB) format Owners: rebus Branches: f17 f18 f19 el6 el5 Thank you Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718
Mario Blättermann changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #7 from Mario Blättermann ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4567157
$ rpmlint -i -v *
libesedb.src: I: checking
libesedb.src: I: checking-url http://code.google.com/p/libesedb/ (timeout 10
seconds)
libesedb.src: E: unknown-key (MD5
The package was signed, but with an unknown key. See the rpm --import option
for more information.
libesedb.src: I: checking-url
http://libesedb.googlecode.com/files/libesedb-alpha-20120102.tar.gz (timeout 10
seconds)
libesedb.src: W: invalid-url Source0:
http://libesedb.googlecode.com/files/libesedb-alpha-20120102.tar.gz HTTP Error
404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
libesedb.i686: I: checking
libesedb.i686: I: checking-url http://code.google.com/p/libesedb/ (timeout 10
seconds)
libesedb.i686: W: no-manual-page-for-binary esedbexport
Each executable in standard binary directories should have a man page.
libesedb.x86_64: I: checking
libesedb.x86_64: I: checking-url http://code.google.com/p/libesedb/ (timeout 10
seconds)
libesedb.x86_64: W: no-manual-page-for-binary esedbexport
Each executable in standard binary directories should have a man page.
libesedb-debuginfo.i686: I: checking
libesedb-debuginfo.i686: I: checking-url http://code.google.com/p/libesedb/
(timeout 10 seconds)
libesedb-debuginfo.x86_64: I: checking
libesedb-debuginfo.x86_64: I: checking-url http://code.google.com/p/libesedb/
(timeout 10 seconds)
libesedb-devel.i686: I: checking
libesedb-devel.i686: I: checking-url http://code.google.com/p/libesedb/
(timeout 10 seconds)
libesedb-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libesedb-devel.x86_64: I: checking
libesedb-devel.x86_64: I: checking-url http://code.google.com/p/libesedb/
(timeout 10 seconds)
libesedb-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libesedb.spec: I: checking-url
http://libesedb.googlecode.com/files/libesedb-alpha-20120102.tar.gz (timeout 10
seconds)
libesedb.spec: W: invalid-url Source0:
http://libesedb.googlecode.com/files/libesedb-alpha-20120102.tar.gz HTTP Error
404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
7 packages and 1 specfiles checked; 1 errors, 6 warnings.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv3+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
068ab53f434376e2c0f4bfa56e98b324a8b2bee89b3588b524f3541112f40e26
libesedb-alpha-20120102.tar.gz
068ab53f434376e2c0f4bfa56e98b324a8b2bee89b3588b524f3541112f40e26
libesedb-alpha-20120102.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[.] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequ
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #6 from Michal Ambroz --- Updated package: Spec URL: http://rebus.fedorapeople.org/SPECS/libesedb.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/libesedb-20120102-3.fc17.src.rpm Thank you Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718
--- Comment #5 from Mario Blättermann ---
%install
#Apply on for rhel
%if 0%{?rhel}
rm -rf %{buildroot}
%endif
If you really want to provide a package for EPEL 5, remove that conditional
cleaning of buildroot and maintain a spec file separately for that branch. BTW,
your script is not valid because the extra's like BuildRoot definition, %clean
section and so on are only applicable for RHEL 5 and older, not for RHEL in
general.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #4 from Michal Ambroz --- Thank you for review. Updated package: Spec URL: http://rebus.fedorapeople.org/SPECS/libesedb.spec SRPM URL: http://rebus.fedorapeople.org/SRPMS/libesedb-20120102-2.fc17.src.rpm Best regards Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #3 from Mario Blättermann --- Any news...? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718
Mario Blättermann changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #2 from Mario Blättermann ---
The file links are dead, these are the right ones:
Spec URL: http://rebus.fedorapeople.org/SPECS/libesedb.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/libesedb-20120102-1.fc17.src.rpm
Koji scratch build for f18:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4513986
Your package is almost fine, some objections though:
The initial cleaning of buildroot in %install is an artifact from older Fedora
versions (< F10, EPEL5). Please remove the appropriate line.
Currently our man pages are gzipped, but this could change in the future,
that's why:
%{_mandir}/man1/esedbinfo.1.*
%{_mandir}/man3/libesedb.3.*
$ rpmlint -i -v *
libesedb.src: I: checking
libesedb.src: I: checking-url http://sourceforge.net/projects/libesedb/
(timeout 10 seconds)
libesedb.src: E: unknown-key (MD5
The package was signed, but with an unknown key. See the rpm --import option
for more information.
libesedb.src: I: checking-url
http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz
(timeout 10 seconds)
libesedb.src: W: invalid-url Source0:
http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz HTTP
Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
libesedb.i686: I: checking
libesedb.i686: I: checking-url http://sourceforge.net/projects/libesedb/
(timeout 10 seconds)
libesedb.i686: W: no-manual-page-for-binary esedbexport
Each executable in standard binary directories should have a man page.
libesedb.x86_64: I: checking
libesedb.x86_64: I: checking-url http://sourceforge.net/projects/libesedb/
(timeout 10 seconds)
libesedb.x86_64: W: no-manual-page-for-binary esedbexport
Each executable in standard binary directories should have a man page.
libesedb-debuginfo.i686: I: checking
libesedb-debuginfo.i686: I: checking-url
http://sourceforge.net/projects/libesedb/ (timeout 10 seconds)
libesedb-debuginfo.x86_64: I: checking
libesedb-debuginfo.x86_64: I: checking-url
http://sourceforge.net/projects/libesedb/ (timeout 10 seconds)
libesedb-devel.i686: I: checking
libesedb-devel.i686: I: checking-url http://sourceforge.net/projects/libesedb/
(timeout 10 seconds)
libesedb-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libesedb-devel.x86_64: I: checking
libesedb-devel.x86_64: I: checking-url
http://sourceforge.net/projects/libesedb/ (timeout 10 seconds)
libesedb-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
libesedb.spec: I: checking-url
http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz
(timeout 10 seconds)
libesedb.spec: W: invalid-url Source0:
http://downloads.sourceforge.net/libesedb/libesedb-alpha-20120102.tar.gz HTTP
Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
7 packages and 1 specfiles checked; 1 errors, 6 warnings.
This project is no longer hosted at SourceForge. The new download location is
http://libesedb.googlecode.com/files/libesedb-alpha-20120102.tar.gz.
Please don't sign your srpms. It is not really needed and produces annoying
output of rpmlint.
Please fix the issues (project website, source location, buildroot cleaning,
man page extension) and your package is ready for a full review.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Michal Ambroz changed: What|Removed |Added CC||m...@fabian-affolter.ch, ||re...@seznam.cz Alias||libesedb -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
https://bugzilla.redhat.com/show_bug.cgi?id=822718 Michal Ambroz changed: What|Removed |Added Blocks||563471 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 822718] Review Request: libesedb - Library to access the Extensible Storage Engine (ESE) Database File (EDB) format
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=822718 --- Comment #1 from Michal Ambroz 2012-05-17 17:53:53 EDT --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4084680 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
