[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- erlang-eleveldb-1.1.0-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- erlang-eleveldb-1.1.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/erlang-eleveldb-1.1.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2012-07-20 02:01:26 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171
Brendan Jones brendan.jones...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Brendan Jones brendan.jones...@gmail.com ---
This package is APPROVED. Remove EPEL macros/tags if not required,
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[ ]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Note: Unversioned so-files in non-devel package (fix or explain):erlang-
eleveldb-1.1.0-1.fc18.x86_64.rpm :
/usr/lib64/erlang/lib/eleveldb-1.1.0/priv/eleveldb.so
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[!]: MUST Buildroot is not present
Note: Buildroot is not needed unless packager plans to package for EPEL5
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[-]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Apache (v2.0) For detailed output of licensecheck see file:
/home/bsjones/rpmbuild/SRPMS/erlang-eleveldb/licensecheck.txt
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Peter Lemenkov lemen...@gmail.com --- Thanks! New Package SCM Request === Package Name: erlang-eleveldb Short Description: Erlang LevelDB API Owners: peter Branches: f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 --- Comment #4 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #3) This is looking good, just one rpmlint error of concern? erlang-eleveldb.src: W: invalid-url Source0: basho-eleveldb-1.1.0-0-g7790751.tar.gz erlang-eleveldb.x86_64: E: explicit-lib-dependency erlang-stdlib erlang-eleveldb.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/eleveldb-1.1.0/priv/eleveldb.so === I think there is something wrong with your configuration. Maybe you didn't installed something which is required for debuginfo generation. Try builds from Koji (see link above) - for example I don't see this issue with this build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4242884 I also noticed you had the tests commented out - they all passed here however. Thanks for spotting this. This is a leftover from my experiments on a secondary arches. New package: * http://peter.fedorapeople.org/erlang-eleveldb.spec * http://peter.fedorapeople.org/erlang-eleveldb-1.1.0-2.fc18.src.rpm Changelog: * EL5-related stuff removed * Enable tests Koji build for Rawhide: * http://koji.fedoraproject.org/koji/taskinfo?taskID=4247618 Note - I intentionally didn't package recently released 1.2.0 since they patched bundled library and I need time to properly build it against system-wide leveldb. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 --- Comment #3 from Brendan Jones brendan.jones...@gmail.com --- This is looking good, just one rpmlint error of concern? erlang-eleveldb.src: W: invalid-url Source0: basho-eleveldb-1.1.0-0-g7790751.tar.gz erlang-eleveldb.x86_64: E: explicit-lib-dependency erlang-stdlib erlang-eleveldb.x86_64: W: unstripped-binary-or-object /usr/lib64/erlang/lib/eleveldb-1.1.0/priv/eleveldb.so === erlang-eleveldb.x86_64: W: no-documentation 2 packages and 0 specfiles checked; 1 errors, 3 warnings. I also noticed you had the tests commented out - they all passed here however. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 Bug 823171 depends on bug 823170, which changed state. Bug 823170 Summary: Review Request: leveldb - A fast and lightweight key/value database library by Google https://bugzilla.redhat.com/show_bug.cgi?id=823170 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Whiteboard|NotReady| --- Comment #1 from Peter Lemenkov lemen...@gmail.com --- Unblocking NotReady - all build-deps are now in Rawhide. Koji scratchbuild for F-18: http://koji.fedoraproject.org/koji/taskinfo?taskID=4242883 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823171] Review Request: erlang-eleveldb - Erlang LevelDB API
https://bugzilla.redhat.com/show_bug.cgi?id=823171 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added CC||brendan.jones...@gmail.com Assignee|nob...@fedoraproject.org|brendan.jones...@gmail.com Flags||fedora-review? --- Comment #2 from Brendan Jones brendan.jones...@gmail.com --- I will take this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
