[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-06-06 22:34:10 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- greybird-0.8.2-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- greybird-0.8.2-3.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #8 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- greybird-0.8.2-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/greybird-0.8.2-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Blocks|177841 | Flags|fedora-review? |fedora-review+ --- Comment #6 from Kevin Fenzi ke...@scrye.com --- All those changes look good to me, I see no further blockers here, so this package is APPROVED. I'll go ahead and sponsor you into the packager group. :) Welcome to the fun. Continue the process from https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Athmane Madjoudj athma...@gmail.com --- New Package SCM Request === Package Name: greybird Short Description: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3 Owners: athmane Branches: f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|ke...@scrye.com Flags||fedora-review? --- Comment #3 from Kevin Fenzi ke...@scrye.com --- I'd be happy to review this and look at sponsoring you. ;) Look for a review soon... -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #4 from Kevin Fenzi ke...@scrye.com --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License GPLv2+ or CC-BY-SA OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Not a blocker, but might consider shipping the xfce-notify-4.0/ theme too? Also, lightdm is under review, so might be ready to ship it's theme? 2. If I use the method listed in the spec to get the source, I get: shimmerproject-Greybird-v0.8.2-0-g10555c8.tar.gz but you have shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz (they appear identical, perhaps your versioning is off in the spec?) 3. rpmlint says: greybird.src: W: spelling-error Summary(en_US) minimalistic - minimalist, minimalism, animistic greybird.src: W: spelling-error %description -l en_US metacity - meta city, meta-city, mendacity greybird.src: W: spelling-error %description -l en_US grey - Grey, gray, trey greybird.src: W: spelling-error %description -l en_US ish - is, sh, dish greybird.src: W: invalid-url Source0: shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz 5 packages and 0 specfiles checked; 0 errors, 5 warnings. All can be ignored. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #5 from Athmane Madjoudj athma...@gmail.com --- Thank you, Kevin. (In reply to comment #4) snip Issues: 1. Not a blocker, but might consider shipping the xfce-notify-4.0/ theme too? Also, lightdm is under review, so might be ready to ship it's theme? I've included Xfce notify theme, I can add lightdm theme as after it gets approved but I think we'll loose fedora branding (background). 2. If I use the method listed in the spec to get the source, I get: shimmerproject-Greybird-v0.8.2-0-g10555c8.tar.gz but you have shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz (they appear identical, perhaps your versioning is off in the spec?) Fixed, upstream tagged 10555c8 commit as 0.8.2 (3 hours ago) https://github.com/shimmerproject/Greybird/tags snip Spec URL: http://athmane.fedorapeople.org/pkgs/greybird.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/greybird-0.8.2-3.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4095296 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Blocks||177841 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #1 from Athmane Madjoudj athma...@gmail.com --- Note: this is my second package and I'm looking for sponsor. rpmlint output: greybird.src: W: spelling-error Summary(en_US) minimalistic - minimalist, minimalism, animistic greybird.src: W: spelling-error %description -l en_US metacity - meta city, meta-city, mendacity greybird.src: W: spelling-error %description -l en_US grey - Grey, gray, trey greybird.src: W: spelling-error %description -l en_US ish - is, sh, dish greybird.src: W: invalid-url Source0: shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz greybird.spec: W: invalid-url Source0: shimmerproject-Greybird-v0.8.1-9-g10555c8.tar.gz 5 packages and 1 specfiles checked; 0 errors, 6 warnings. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4090481 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 --- Comment #2 from Athmane Madjoudj athma...@gmail.com --- - Updated the requirement to gtk3-engines-unico = 1.0.2 (available in f17+), otherwise you get a buggy gtk3 theme - Spec cleanup Spec URL: http://athmane.fedorapeople.org/pkgs/greybird.spec SRPM URL: http://athmane.fedorapeople.org/pkgs/greybird-0.8.1-2.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4090667 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 823311] Review Request: greybird - A clean minimalistic theme for Xfce, GTK+ 2 and 3
https://bugzilla.redhat.com/show_bug.cgi?id=823311 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added Alias||greybird -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
