needinfo canceled: [Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Vít Ondruch  has canceled Package Review
's request for Vít Ondruch
's needinfo:
Bug 823351: Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a
JSON stream-based parser
https://bugzilla.redhat.com/show_bug.cgi?id=823351



--- Comment #27 from Vít Ondruch  ---
Resetting the reviewer. I think this will get eventually autoclosed unless
somebody have enough energy to move this forward.
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Vít Ondruch  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|vondr...@redhat.com |nob...@fedoraproject.org
  Flags|fedora-review?  |
   |needinfo?(vondruch@redhat.c |
   |om) |



--- Comment #27 from Vít Ondruch  ---
Resetting the reviewer. I think this will get eventually autoclosed unless
somebody have enough energy to move this forward.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=823351

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla=report-spam_desc=Report%20of%20Bug%20823351%23c27
--
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Alasdair Kergon  changed:

   What|Removed |Added

 CC||a...@redhat.com




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=823351
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

needinfo canceled: [Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Vít Ondruch  has canceled Package Review
's request for Vít Ondruch
's needinfo:
Bug 823351: Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a
JSON stream-based parser
https://bugzilla.redhat.com/show_bug.cgi?id=823351
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Vít Ondruch  changed:

   What|Removed |Added

  Flags|needinfo?(vondruch@redhat.c |
   |om) |




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=823351
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Vít Ondruch  changed:

   What|Removed |Added

  Flags|needinfo?(vondruch@redhat.c |
   |om) |




-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

needinfo canceled: [Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Vít Ondruch  has canceled Package Review
's request for Vít Ondruch
's needinfo:
Bug 823351: Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a
JSON stream-based parser
https://bugzilla.redhat.com/show_bug.cgi?id=823351
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Sandro Bonazzola  changed:

   What|Removed |Added

 Blocks|1460625 (oVirt_on_Fedora)   |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1460625
[Bug 1460625] [Tracker] Fedora support
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Sandro Bonazzola  changed:

   What|Removed |Added

  Flags|needinfo?(sbonazzo@redhat.c |
   |om) |



--- Comment #22 from Sandro Bonazzola  ---
(In reply to Matthias Runge from comment #21)
> Sandro, you -2'ed the RDO review. I guess, this is not necessary anymore?

It's still needed but the RDO review patch is not working:
Fails functional testing on fedora. I get: Ignoring yajl-ruby-1.3.1 because its
extensions are not built.  Try: gem pristine yajl-ruby --version 1.3.1

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Matthias Runge  changed:

   What|Removed |Added

  Flags|needinfo?(mru...@redhat.com |needinfo?(sbonazzo@redhat.c
   |)   |om)



--- Comment #21 from Matthias Runge  ---
Sandro, you -2'ed the RDO review. I guess, this is not necessary anymore?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Sandro Bonazzola  changed:

   What|Removed |Added

 Blocks||1460625 (oVirt_on_Fedora)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1460625
[Bug 1460625] [Tracker] Fedora support
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Sandro Bonazzola  changed:

   What|Removed |Added

External Bug ID||RDO 10681
  Flags||needinfo?(mru...@redhat.com
   ||)



--- Comment #20 from Sandro Bonazzola  ---
Matthias can you please review?
Also pushed to https://review.rdoproject.org/r/#/c/10681/

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351



--- Comment #19 from Sandro Bonazzola  ---
Bumped to 1.3.1.
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/sbonazzo/ovirt-fluentd/rubygem-yajl-ruby.git/tree/rubygem-yajl-ruby.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/ovirt-fluentd/fedora-rawhide-x86_64/00678767-rubygem-yajl-ruby/rubygem-yajl-ruby-1.3.1-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Sandro Bonazzola  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1426110



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Vít Ondruch  changed:

   What|Removed |Added

 CC||yguen...@redhat.com



--- Comment #18 from Vít Ondruch  ---
*** Bug 1373005 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Julian C. Dunn jd...@aquezada.com changed:

   What|Removed |Added

 Blocks|823352  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=823352
[Bug 823352] Review Request: rubygem-chef - a client for the Chef config
management system
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Julian C. Dunn jd...@aquezada.com changed:

   What|Removed |Added

 Blocks|823344  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=823344
[Bug 823344] Review Request: rubygem-ohai - detects data about your system,
exports as JSON for use with Chef
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351



--- Comment #17 from Julian C. Dunn jd...@aquezada.com ---
Since Brian Lopez seems to not want the devendorization patches against
yajl-ruby, we (Chef Software, Inc.) have rewritten our own FFI wrapper around
libyajl2 to get around this vendoring issue. Future versions of Chef will use
ffi-yajl instead of both yajl-ruby and the JSON gem, so I have submitted
bz#1114146 as a precursor to getting Chef into Fedora.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351



--- Comment #16 from Vít Ondruch vondr...@redhat.com ---
Just for the record, it seems tha yajl-ruby might be renamed to yajl:
https://github.com/brianmario/yajl-ruby/pull/128

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Julian C. Dunn jd...@aquezada.com changed:

   What|Removed |Added

  Flags|needinfo?(jd...@aquezada.co |
   |m)  |



--- Comment #15 from Julian C. Dunn jd...@aquezada.com ---
Hi Ken, I'm ok with the build patches, but we still need to solve the big issue
which is whether to integrate the de-vendorization patch into Fedora yajl. That
would potentially change the behavior of yajl from upstream, since the patch is
not 100% finished pending input from (unresponsive) upstream we would need to
make a call as to what to do.

Specifically: the de-vendorization patch
(https://github.com/brianmario/yajl-ruby/pull/113) causes some tests to fail,
and I'm unsure whether this is a problem.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Ken Dreyer ktdre...@ktdreyer.com changed:

   What|Removed |Added

  Flags||needinfo?(jd...@aquezada.co
   ||m)



--- Comment #14 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Julian, just checking to see if you've had a chance to review those patches
and merge them into your yajl-ruby package? It would be great to get yajl-ruby
into Fedora.

I've updated for the latest yajl-ruby release (1.2.0):

http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-yajl-ruby.git/commit/?id=40e3e04fa5fb421ffda3b2112eb0570257413fb5

F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6533809

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351



--- Comment #13 from Ken Dreyer ktdre...@ktdreyer.com ---
Hi Julian, I've made some adjustments to the spec file and pushed the changes
to a Git repo, here:
http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-yajl-ruby.git/log/

I've broken each change into a separate Git commit so you can review each one.
I'll also try to explain each suggested change below.

1. (60bdf07) remove gem2rpm autogenerated comment. The gem2rpm tool inserts
this comment into the packages, but it is just cruft so we can remove it.

2. (233f9b0) use HTTPS in URLs. This commit changes the URL from using
plaintext HTTP to secured HTTPS.

3. (f054c1c) remove trailing whitespace. There were two lines with trailing
whitespace in the spec file, so this commit fixes that.

4. (27bddfb) simplify el6/rubyabi conditionals. The last Fedora version that
supported ruby(abi) is Fedora 18, and this is going end-of-life in a few days.
We only need to support ruby(abi) on EL6. This commit simplifies the RPM dist
conditionals to reflect this.

5. (a9e8c12) build doc subpackage as noarch. The -doc subpackage should be set
to noarch since there's no architecture-specific files within it.

6. (c6cb71d) move build process into %build. The Ruby guidelines indicate that
the gem should be unpacked in %prep and built in %build. This commit runs gem
unpack and gem spec in %prep, and gem build in %build.

7. (2abbc85) use %gem_install macro. On platforms that are not EL6, the
%gem_install macro is available and preferable to manually compiling the gem.

8. (2b748f8) use %{ruby_sitearch} and %{gem_extdir_mri}. The %{gem_extdir}
macro is deprecated. Use %{ruby_sitearch} on EL6, and use %{gem_extdir_mri}
elsewhere.

9. (a2de3a8) BuildRequire ruby(rubygems). I needed to add this to get the
package to build on EL6.

10. (031261f) mark README.md and CHANGELOG.md as %doc. These files are text,
not code, so I marked them as such in this commit.

11. (8f5c851) move README.md to main package. I thought it would be a good idea
to ship this in the main package because so that it's more accessible to users.

12. (1e3db58) delete unnecessary gemspec during %install. It's not necessary to
ship two gemspecs for this package. This commit deletes the duplicate during
%install.

13. (128ca61) remove developer-only files during %prep. Some files were deleted
during %install, some files were %exclude'd, and some were shipped in -doc.
This commit just deletes them all during %prep (and removes them from the
gemspec) for cleanliness and consistency.

I've tested this version on EL6 and F19, and simple JSON tests work on both
platforms.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

Allen Hewes al...@decisiv.net changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |
 CC||al...@decisiv.net

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=Se3g2iSqDGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

--- Comment #10 from Vít Ondruch vondr...@redhat.com ---
(In reply to comment #9)
 I think, once the upstream merges the changes to allow to use system's yajl
 libraries, the name of this package should be changed to 'rubygem-yajl' as
 per Fedora rubygem naming guidelines.

I disagree. This guidelines applies to ruby packages, not to rubygems.
Moreover, we already met packages which were named foo and foo-ruby, while
their sourcecode and upstreams were different.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=rLqIBIVl7xa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

Vaidas Jablonskis jablons...@gmail.com changed:

   What|Removed |Added

 CC||jablons...@gmail.com

--- Comment #9 from Vaidas Jablonskis jablons...@gmail.com ---
I think, once the upstream merges the changes to allow to use system's yajl
libraries, the name of this package should be changed to 'rubygem-yajl' as per
Fedora rubygem naming guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tC7h5G7qX3a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

--- Comment #8 from Vít Ondruch vondr...@redhat.com ---
Just FYI, I just sent pull request [1] to upstream allowing yajl-ruby to build
against system yajl library.


[1] https://github.com/brianmario/yajl-ruby/issues/113

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=bupnJf28S1a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

--- Comment #7 from Josef Stribny jstri...@redhat.com ---
I made two patches for yajl-ruby; first is an update to Yajl 2 (to match the
current system version on Fedora) and second is a switch to the system version
of the library. I am discussing the progress with upstream on the GitHub
project page [1].

[1] https://github.com/brianmario/yajl-ruby/issues/111#issuecomment-12542826

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GoYVWu7Alba=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

Josef Stribny jstri...@redhat.com changed:

   What|Removed |Added

 CC||jstri...@redhat.com
  Flags|needinfo?(jstribny@redhat.c |
   |om) |

--- Comment #6 from Josef Stribny jstri...@redhat.com ---
As Vit has already mentioned, I am looking into yajl-ruby to find a way to make
it work with system yajl (which is one version ahead, but with patches from the
patched lib included with yajl-ruby).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=HaUKYfvDlqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

  Flags||needinfo?(jstribny@redhat.c
   ||om)

--- Comment #5 from Vít Ondruch vondr...@redhat.com ---
Josef Stribny is trying to make yajl work with Fedora's yajl. Hopefully he will
provide use with some update soon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=jSr7OC4Nixa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

Michael Scherer m...@zarb.org changed:

   What|Removed |Added

 CC||m...@zarb.org

--- Comment #4 from Michael Scherer m...@zarb.org ---
Yep, the bundled is a showstopper. But we can proceed on the other review in
the mean time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=V47mlWZ4Bta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

--- Comment #3 from Julian C. Dunn jd...@aquezada.com ---
I have corrected all the issues identified and rebuilt the SRPM.

http://fedorapeople.org/~jdunn/rubygem-yajl-ruby/rubygem-yajl-ruby-1.1.0-2.fc19.src.rpm
http://fedorapeople.org/~jdunn/rubygem-yajl-ruby/rubygem-yajl-ruby.spec

I take it the bundled YAJL is a showstopper and that we can't proceed until
upstream fixes this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=C4r5mQT05Sa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

Vít Ondruch vondr...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||vondr...@redhat.com
   Assignee|nob...@fedoraproject.org|vondr...@redhat.com
  Flags||fedora-review?

--- Comment #1 from Vít Ondruch vondr...@redhat.com ---
I'll take it for a review, since it is dependency of rubygem-chef. Not sure if
Jonas is active though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=JIlyvfFAZHa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=823351

--- Comment #2 from Vít Ondruch vondr...@redhat.com ---
* Keep Gemfile and %{gem_name}.gemspec
  - Please consider to keep above mentioned files in -doc subpackage. Although
they are not needed for runtime, they were originally shipped by upstream,
so lets try to keep the modifications limited.

* Move files not needed for runtime into -doc subpackage
  - Please consider to move following files/directories into -doc subpackage,
since they are not needed for runtime IMO:

  %doc %{gem_instdir}/CHANGELOG.md
  %doc %{gem_instdir}/README.md
  %{gem_instdir}/benchmark
  %{gem_instdir}/spec
  %{gem_instdir}/tasks

* Package does not own the binary extension directories
  - The %{gem_extdir}/lib/yajl/yajl.so means that only the yajl.so file is
owned by the package. Please use %{gem_extdir} instead, to own the whole
directory structure including the .so file.

* Exclude %{gem_cache}
  - Please exclude %{gem_cache}. This file is not needed on Fedora.

* Bundled library
  - This gem contains bundled YAJL library. Please work with upstream to allow
to use the YAJL available on system.
  - I already submitted issue upstream: 
https://github.com/brianmario/yajl-ruby/issues/111

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=LCIuKtBNXGa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Jonas Courteau r...@courteau.org changed:

   What|Removed |Added

 Blocks|177841  |823344

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 823351] Review Request: rubygem-yajl-ruby - Ruby C bindings to YAJL - a JSON stream-based parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=823351

Jonas Courteau r...@courteau.org changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |rubygem-yajl-ruby   |rubygem-yajl-ruby - Ruby C
   ||bindings to YAJL - a JSON
   ||stream-based parser

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review