[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Tomas Tomecek  changed:

   What|Removed |Added

 Status|POST|CLOSED
 CC||ttome...@redhat.com
 Resolution|--- |DUPLICATE
Last Closed||2020-01-25 12:03:51



--- Comment #12 from Tomas Tomecek  ---
I am stepping up to maintain nyancat in fedora myself, hence closing this and
starting a new review process since the spec here is not available any more.

*** This bug has been marked as a duplicate of bug 1794912 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Ricky Elrod  changed:

   What|Removed |Added

   Assignee|rel...@redhat.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

 CC||i...@ianweller.org
  Flags||needinfo?(i...@ianweller.org
   ||)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Ben Rosser rosser@gmail.com changed:

   What|Removed |Added

 CC|rosser@gmail.com|



--- Comment #11 from Petr Šabata psab...@redhat.com ---
Ping once again.

Your git branches were created.  How about building the package?  And
submitting new-package updates for stable releases...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083



--- Comment #10 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Ian Weller i...@ianweller.org changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #9 from Ian Weller i...@ianweller.org ---
New Package SCM Request
===
Package Name: nyancat
Short Description: A terminal Nyan Cat renderer
Upstream URL: https://github.com/klange/nyancat
Owners: ianweller
Branches: epel7 f20 f21
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083



--- Comment #8 from Petr Šabata psab...@redhat.com ---
Ping.

Your package has passed the review.  Feel free to submit an SCM request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=824083

Ricky Elrod rel...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |
  Flags||fedora-review+

--- Comment #7 from Ricky Elrod rel...@redhat.com ---
Remaining issues (both non-blockers and are SHOULD items):

- Try and get the DESTDIR patch upstream.
- Ask upstream to include a LICENSE file in the project.

Please try to take care of the above if you can, but for purposes of review,
this package is APPROVED.

Package Review
==

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Large documentation must go in a -doc subpackage.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm  4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: 

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=824083

--- Comment #6 from Ian Weller i...@ianweller.org ---
* Tue Feb 05 2013 Ian Weller iwel...@redhat.com - 1.1-1
- Update to 1.1  
- Include man page   

Spec: http://ianweller.fedorapeople.org/SRPMS/nyancat/1.1-1/nyancat.spec
SRPM:
http://ianweller.fedorapeople.org/SRPMS/nyancat/1.1-1/nyancat-1.1-1.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=gbXYKpGUsSa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=824083

Michael Schwendt mschwe...@gmail.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|codebl...@elrod.me

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=b0tnS7UJhXa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Ricky Elrod codebl...@elrod.me changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

--- Comment #5 from Ricky Elrod codebl...@elrod.me ---
[ok] - Package meets naming and packaging guidelines
[ok] - Spec file matches base package name.
[ok] - Spec has consistant macro usage.
[ok] - Meets Packaging Guidelines.
[ok - NCSA] - License
[ok] - License field in spec matches
[ok - see below] - License file included in package
[ok] - Spec in American English
[ok] - Spec is legible.
[ok] - Sources match upstream md5sum:
  [ricky@t520 SPECS]$ md5sum ~/Downloads/klange-nyancat-5fe3de9.tar.gz
../SOURCES/klange-nyancat-5fe3de9.tar.gz
  fef3b947260dcb191e2eed4bcc58b42c 
/home/ricky/Downloads/klange-nyancat-5fe3de9.tar.gz
  fef3b947260dcb191e2eed4bcc58b42c  ../SOURCES/klange-nyancat-5fe3de9.tar.gz

[ok] - BuildRequires correct
[ok] - Package has %defattr and permissions on files is good.
[ok] - Package has a correct %clean section.
[ok] - Package has correct buildroot
[ok] - Package is code or permissible content.
[ok] - Packages %doc files don't affect runtime.
[ok] - Package compiles and builds on at least one arch.
[ok] - Package has no duplicate files in %files.
[ok] - Package doesn't own any directories other packages own.
[ok - see below] - No rpmlint output.

SHOULD Items:

[ok] - Should build in mock.
[ok] - Should build on all supported archs
[ok] - Should function as described.
[ok] - Should have dist tag
[ok] - Should package latest version

Issues:

1. Consider asking upstream to include a copy of the license in the repository.
(non-blocker)
2. I think the versioning is a bit off, consider:
Version:1
Release:0.1.%{checkout}%{?dist}
3. There's a manpage now (upstream repo), you probably should include this.

rpmlint output:

[ricky@t520 SPECS]$ rpmlint
../SRPMS/nyancat-1.0-1.20120522git5fe3de9.fc18.src.rpm
nyancat.src: W: spelling-error Summary(en_US) renderer - tenderer, rendered,
render er
nyancat.src: W: spelling-error %description -l en_US poptart - pop tart,
pop-tart, polestar
nyancat.src: W: invalid-url Source0: klange-nyancat-5fe3de9.tar.gz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

[ricky@t520 SPECS]$ rpmlint
../RPMS/x86_64/nyancat-1.0-1.20120522git5fe3de9.fc18.x86_64.rpm
nyancat.x86_64: W: spelling-error Summary(en_US) renderer - tenderer,
rendered, render er
nyancat.x86_64: W: spelling-error %description -l en_US poptart - pop tart,
pop-tart, polestar
nyancat.x86_64: W: no-manual-page-for-binary nyancat
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 CC||ppi...@redhat.com

--- Comment #4 from Petr Pisar ppi...@redhat.com ---
(In reply to comment #3)
 I used wget to download the file, which doesn't actually pay attention to
 the content disposition headers, so it just names it tarball. So it's an
 extra step for someone either way.

Well, wget has an option --content-disposition exactly for this reason.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Petr Šabata psab...@redhat.com changed:

   What|Removed |Added

 CC||psab...@redhat.com

--- Comment #1 from Petr Šabata psab...@redhat.com ---
And now Fedora will be complete :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

Ben Rosser rosser@gmail.com changed:

   What|Removed |Added

 CC||rosser@gmail.com

--- Comment #2 from Ben Rosser rosser@gmail.com ---
As I need sponsorship (and reviews of my own package request), this can't be a
formal review. I did look into a few things though:

I followed the github link and it downloaded
klange-nyancat-stable-2-g5fe3de9.tar.gz- not something on the format of
klange-nyancat-5fe3de9.tar.gz. So after downloading I had to do mv
klange-nyancat-stable-2-g5fe3de9.tar.gz klange-nyancat-5fe3de9.tar.gz- you
might want to mention this is necessary in the spec? (Or modify the spec to
deal with that?)

Other than that, this seems fine.. rpmlint finds a couple of spelling errors
and the invalid URL in the spec, which are false positives for this package. It
does also note the lack of a man page for a binary, but that's it.

nyancat.src: W: spelling-error Summary(en_US) renderer - tenderer, rendered,
render er
nyancat.src: W: spelling-error %description -l en_US poptart - pop tart,
pop-tart, polestar
nyancat.src: W: invalid-url Source0: klange-nyancat-5fe3de9.tar.gz
nyancat.x86_64: W: spelling-error Summary(en_US) renderer - tenderer,
rendered, render er
nyancat.x86_64: W: spelling-error %description -l en_US poptart - pop tart,
pop-tart, polestar
nyancat.x86_64: W: no-manual-page-for-binary nyancat

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 824083] Review Request: nyancat - A terminal Nyan Cat renderer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=824083

--- Comment #3 from Ian Weller i...@ianweller.org ---
(In reply to comment #2)
 I followed the github link and it downloaded
 klange-nyancat-stable-2-g5fe3de9.tar.gz- not something on the format of
 klange-nyancat-5fe3de9.tar.gz. So after downloading I had to do mv
 klange-nyancat-stable-2-g5fe3de9.tar.gz klange-nyancat-5fe3de9.tar.gz- you
 might want to mention this is necessary in the spec? (Or modify the spec to
 deal with that?)

I used wget to download the file, which doesn't actually pay attention to the
content disposition headers, so it just names it tarball. So it's an extra
step for someone either way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review