[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-06-11 09:26:21 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 Bug 824798 depends on bug 825250, which changed state. Bug 825250 Summary: Review Request: guacamole-ext - Common interfaces for extending the main Guacamole web application https://bugzilla.redhat.com/show_bug.cgi?id=825250 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #10 from Stanislav Ochotnicky socho...@redhat.com --- A small request. Please don't remove src.rpm files at least until the review is completely closed. I just wanted to have a look at older srpm file just to find it's not longer there :-/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #11 from Simone Caronni negativ...@gmail.com --- Ok, I'll do, sorry. --Simone -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #12 from Simone Caronni negativ...@gmail.com --- New Package SCM Request === Package Name: guacamole-common Short Description: The core Java library used by the Guacamole web application Owners: slaanesh Branches: f17 f16 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||socho...@redhat.com Flags||fedora-review? --- Comment #1 from Stanislav Ochotnicky socho...@redhat.com --- I'll review this -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798
--- Comment #2 from Stanislav Ochotnicky socho...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[!]: MUST License file installed when any subpackage combination is
installed.
LICENSE files should be put into javadoc subpackage as well
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[!]: MUST Requires correct, justified where necessary.
Pom file specifies slf4j and javax.servlet as a dependency. First is
easy, for second one you should probably add Servlet3 for now. We'll
be fixing javax.XX stuff soon(ish).
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[-]: SHOULD Package functions as described.
[-]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Rpmlint is run on all installed packages.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
Java
[x]: MUST If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: MUST Javadoc subpackages have Requires:
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|socho...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #3 from Simone Caronni negativ...@gmail.com --- Thanks, I've added all you pointed out; but I cannot install it on Fedora 17. - Added Requires on slf4j and Servlet3. - Added LICENSE file to javadoc subpackage. - Install pom file from pom.xml. - Moved jar file to guacamole subdirectory. What does exactly mean you should probably add Servlet3 for now. We'll be fixing javax.XX stuff soon(ish).? Thanks, --Simone -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #4 from Simone Caronni negativ...@gmail.com --- If I try to install it there seems to be no other package providing Servlet3: Resolving Dependencies -- Running transaction check --- Package guacamole-common.noarch 0:0.6.0-2.fc17 will be installed -- Processing Dependency: Servlet3 for package: guacamole-common-0.6.0-2.fc17.noarch -- Finished Dependency Resolution Error: Package: guacamole-common-0.6.0-2.fc17.noarch (slaanesh) Requires: Servlet3 You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #5 from Simone Caronni negativ...@gmail.com --- Ok, got it, sorry: http://koji.fedoraproject.org/koji/rpminfo?rpmID=3055243 servlet3 from tomcat-servlet-3.0-api. Spec URL: http://slaanesh.fedorapeople.org/guacamole-common.spec SRPM URL: http://slaanesh.fedorapeople.org/guacamole-common-0.6.0-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Stanislav Ochotnicky socho...@redhat.com --- Well we are planning to add javax.servlet and related provides in appropriate package(s) in next guideline update. We'll see how it goes. In any case, you figured it out and package is good now. Well done, and as I said before: kudos to upstream devs for doing it right(tm). APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 Simone Caronni negativ...@gmail.com changed: What|Removed |Added Depends On||825250 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #7 from Simone Caronni negativ...@gmail.com --- Spec URL: http://slaanesh.fedorapeople.org/guacamole-common.spec SRPM URL: http://slaanesh.fedorapeople.org/guacamole-common-0.6.0-3.fc17.src.rpm Fixed %add_maven_depmap usage as per bug #825250 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798
Mary Ellen Foster mefos...@gmail.com changed:
What|Removed |Added
CC||mefos...@gmail.com
--- Comment #8 from Mary Ellen Foster mefos...@gmail.com ---
Sorry, I wasn't clear -- you also need to change the filename that you use for
the pom to correspond to the %add_maven_depmap call. So it should also be
install -pm 644 pom.xml
$RPM_BUILD_ROOT%{_mavenpomdir}/JPP.guacamole-%{name}.pom
And you need to change the filename in the %files directory too
And some package -- I guess probably this one? -- needs to own the
%{_javadir}/guacamole directory too.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 824798] Review Request: guacamole-common - The core Java library used by the Guacamole web application
https://bugzilla.redhat.com/show_bug.cgi?id=824798 --- Comment #9 from Simone Caronni negativ...@gmail.com --- Spec URL: http://slaanesh.fedorapeople.org/guacamole-common.spec SRPM URL: http://slaanesh.fedorapeople.org/guacamole-common-0.6.0-4.fc17.src.rpm Yep. You're absolutely right. - Fixed .pom file installation. - Changed ownership from jar to containing directory. Thanks, --Simone -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
