[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||bkhive-1.1.1-8.el7 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-8.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-8.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/bkhive-1.1.1-8.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Michal Ambroz re...@seznam.cz changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #15 from Michal Ambroz re...@seznam.cz --- Package Change Request == Package Name: bkhive New Branches: epel7 Owners: rebus Hello SCM team, plase can you add epel7 branch for the bkhive package? Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Branch exists. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-4.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-25 20:24:34 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-2.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-2.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/bkhive-1.1.1-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/bkhive-1.1.1-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/bkhive-1.1.1-2.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- bkhive-1.1.1-4.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/bkhive-1.1.1-4.el5 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Michal Ambroz re...@seznam.cz changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Michal Ambroz re...@seznam.cz --- Hello SCM team, please can you create the package? New Package CVS Request === Package Name: bkhive Short Description: Dump the syskey bootkey from a Windows system hive Owners: rebus Branches: F17 F16 EL6 EL5 Thank you Michal Ambroz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Fabian Affolter m...@fabian-affolter.ch --- (In reply to comment #2) 3) [!]: MUST Rpmlint output is silent. Sorry I didn't make it clear that there is no further action needed. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593
--- Comment #1 from Fabian Affolter m...@fabian-affolter.ch ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint bkhive-debuginfo-1.1.1-1.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint bkhive-1.1.1-1.fc18.src.rpm
bkhive.src: W: spelling-error Summary(en_US) syskey - passkey
bkhive.src: W: spelling-error Summary(en_US) bootkey - boot key, boot-key,
bootee
bkhive.src: W: spelling-error %description -l en_US syskey - passkey
bkhive.src: W: spelling-error %description -l en_US bootkey - boot key,
boot-key, bootee
bkhive.src: W: spelling-error %description -l en_US decrypt - decry pt,
decry-pt, decry
bkhive.src: W: spelling-error %description -l en_US Syskey - Passkey
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
rpmlint bkhive-1.1.1-1.fc18.i686.rpm
bkhive.i686: W: spelling-error Summary(en_US) syskey - passkey
bkhive.i686: W: spelling-error Summary(en_US) bootkey - boot key, boot-key,
bootee
bkhive.i686: W: spelling-error %description -l en_US syskey - passkey
bkhive.i686: W: spelling-error %description -l en_US bootkey - boot key,
boot-key, bootee
bkhive.i686: W: spelling-error %description -l en_US decrypt - decry pt,
decry-pt, decry
bkhive.i686: W: spelling-error %description -l en_US Syskey - Passkey
1 packages and 0 specfiles checked; 0 errors, 6 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/fab/reviews/825593/bkhive-1.1.1.tar.gz :
MD5SUM this package : bb5e076f3051c60331a7831b6c11719d
MD5SUM upstream package : bb5e076f3051c60331a7831b6c11719d
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593
--- Comment #2 from Michal Ambroz re...@seznam.cz ---
Hello Fabian,
thank you for taking the review.
1) [!]: MUST License field in the package spec file matches the actual license.
Thanks for spotting ... fixed to GPLv2+
2) [!]: MUST License field in the package spec file matches the actual license.
I do plan to support EPEL as well
3) [!]: MUST Rpmlint output is silent.
rpmlint contains only warnings because the terminology is not known to the
dictionay - bootkey, syskey, decrypt - all should be where they are
4) [!]: SHOULD SourceX / PatchY prefixed with %{name}.
Fixed - thank you
Spec URL: http://rebus.fedorapeople.org/SPECS/bkhive.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/bkhive-1.1.1-2.fc17.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Status|NEW |ASSIGNED CC||m...@fabian-affolter.ch Assignee|nob...@fedoraproject.org|m...@fabian-affolter.ch Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive
https://bugzilla.redhat.com/show_bug.cgi?id=825593 Michal Ambroz re...@seznam.cz changed: What|Removed |Added CC||re...@seznam.cz Blocks||563471 Alias||bkhive -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
