[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 kc8...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from kc8...@gmail.com --- New Package SCM Request === Package Name: fuelmanager Short Description: keep track of fuel mileage Owners: kc8hfi Branches: f16 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- SCM request package name and Bug summary package name don't match, please fix. Preferably fuelmanager. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 --- Comment #5 from kc8...@gmail.com --- New Spec URL: http://kc8hfi.fedorapeople.org/fuelmanager.spec New SRPM URL: http://kc8hfi.fedorapeople.org/fuelmanager-0.3.7-1.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4184879 1. removed the defattr 2. added hicolor-icon-theme to build requirements 3. using more wildcards in %files I think I've moved everything to one style, instead of mixing macro and variable. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 Nick Bebout n...@fedoraproject.org changed: What|Removed |Added Assignee|nob...@fedoraproject.org|n...@fedoraproject.org Flags||fedora-review+ --- Comment #6 from Nick Bebout n...@fedoraproject.org --- Please fix your sources, the md5sum of the tarball in your srpm and the file at the url in Source0 do not match. Everything else looks good now, except for you don't need to add gcc-c++ to BuildRequires, it's on the list of exceptions. With these changes, this package is APPROVED. I have sponsored you into the packager group, congratulations! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 Nick Bebout n...@fedoraproject.org changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 --- Comment #3 from kc8...@gmail.com --- Scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=4178008 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added CC||m...@fabian-affolter.ch --- Comment #4 from Fabian Affolter m...@fabian-affolter.ch --- Just some quick comments: - You are mixing macro and variable style - The numbering in your changelog needs a reset when updating the package - defattr is no longer needed - hicolor-icon-theme is a requirement - Working with wildcards in your %files section will make your life easier in the future when updating the package -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 --- Comment #2 from Nick Bebout n...@fedoraproject.org --- Spec URL: http://fedorapeople.org/~kc8hfi/fuelmanager.spec SRPM URL: http://fedorapeople.org/~kc8hfi/fuelmanager-0.3.6-5.fc15.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 Pierre-YvesChibon pin...@pingoured.fr changed: What|Removed |Added Summary|eview Request: Fuel Manager |Review Request: Fuel |- keep track of your fuel |Manager - keep track of |mileage and consumption |your fuel mileage and ||consumption -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826563] Review Request: Fuel Manager - keep track of your fuel mileage and consumption
https://bugzilla.redhat.com/show_bug.cgi?id=826563 --- Comment #1 from kc8...@gmail.com --- The SRPM link is incorrect, it should be: http://sourceforge.net/projects/fuelmanager/files/fuelmanager-0.3.6-5.fc15.src.rpm/download -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
