[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-07-19 21:54:50 --- Comment #11 from Fedora Update System --- sslext-1.2-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- sslext-1.2-2.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 --- Comment #9 from Fedora Update System --- sslext-1.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/sslext-1.2-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 --- Comment #8 from Kevin Fenzi --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from gil cattaneo --- New Package SCM Request === Package Name: sslext Short Description: Struts SSL Switching Extension Owners: gil Branches: f17 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647
Mikolaj Izdebski changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #6 from Mikolaj Izdebski ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint sslext-1.2-2.fc18.noarch.rpm
sslext.noarch: W: spelling-error %description -l en_US config -> con fig,
con-fig, configure
sslext.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint sslext-javadoc-1.2-2.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint sslext-1.2-2.fc18.src.rpm
sslext.src: W: spelling-error %description -l en_US config -> con fig, con-fig,
configure
sslext.src: W: invalid-url Source0: sslext-1.2-realclean-src-cvs.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
The above warnings can be ignored.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[!]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: SHOULD SourceX / PatchY prefixed with %{name}.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 --- Comment #5 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/sslext/1/sslext.spec SRPM URL: http://gil.fedorapeople.org/sslext/1/sslext-1.2-2.fc16.src.rpm - removed non-free file - fixed spelling errors in description - added missing dependencies - added javadoc sub package -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 --- Comment #4 from Mikolaj Izdebski --- felix-osgi-foundation was listed above by mistake. Obviously it's not needed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 --- Comment #3 from Mikolaj Izdebski --- Issues: 1) web/WEB-INF/web-app_2_3.dtd file is non-free and it cannot be distributed with Fedora. This file needs to be removed from the source tarball. 2) spelling errors in description: http -> HTTP https -> HTTPS xml -> XML 3) missing dependencies. The following Requires need to be added: Requires: apache-commons-digester Requires: apache-commons-logging Requires: felix-osgi-foundation Requires: tomcat-servlet-3.0-api Requires: tomcat-jsp-2.2-api 4) no javadoc package Please fix these issues before i can proceed with the review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 Mikolaj Izdebski changed: What|Removed |Added Depends On||825825 --- Comment #2 from Mikolaj Izdebski --- So far it doesn't build in mock because of missing dependency on struts. I'm adding missing bug dependency. Review postponed until struts is available in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 Mikolaj Izdebski changed: What|Removed |Added Status|NEW |ASSIGNED CC||mizde...@redhat.com Assignee|nob...@fedoraproject.org|mizde...@redhat.com Flags||fedora-review? --- Comment #1 from Mikolaj Izdebski --- I'm taking this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826647] Review Request: sslext - Struts SSL Switching Extension
https://bugzilla.redhat.com/show_bug.cgi?id=826647 gil cattaneo changed: What|Removed |Added Blocks||826645 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
