[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #17 from Fedora Update System --- plasma-mediacenter-0.8.90-4.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=827814 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-12-06 02:06:33 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #16 from Fedora Update System --- plasma-mediacenter-0.8.90-6.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/plasma-mediacenter-0.8.90-6.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #15 from Fedora Update System --- plasma-mediacenter-0.8.90-4.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #14 from Fedora Update System --- plasma-mediacenter-0.8.90-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/plasma-mediacenter-0.8.90-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #13 from Fedora Update System --- plasma-mediacenter-0.8.90-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/plasma-mediacenter-0.8.90-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #12 from Siddharth Sharma --- thanks :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 Siddharth Sharma changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Siddharth Sharma --- New Package SCM Request === Package Name: plasma-mediacenter Short Description: A mediacenter user interface written with the Plasma framework Owners: siddharths Branches: f17 f18 InitialCC: siddharths -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #9 from Siddharth Sharma --- Changes done as per comment 7 Spec URL: http://siddharths.fedorapeople.org/SPECS/plasma-mediacenter.spec SRPM URLhttp://siddharths.fedorapeople.org/SRPMS/plasma-mediacenter-0.8.90-4.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 Magnus Tuominen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Magnus Tuominen --- Allright, this one however belongs in the devel package, missed it last time: W: devel-file-in-non-devel-package /usr/lib64/libplasmamediacenter.so Since that is a small thing to fix, I trust the packager to make that change before importing. Approving. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814
--- Comment #7 from Kevin Kofler ---
No. These are plugins, not linked libraries. Libraries intended to be linked
would be installed to %{_kde4_libdir}, not %{_kde4_libdir}/kde4.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814
--- Comment #6 from Magnus Tuominen ---
New files checked, looking good except for one thing:
%{_kde4_libdir}/kde4/pmc_*.so should be in the devel package and not in the
package itself.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #5 from Siddharth Sharma --- LICENSE added and other changes requested in review process Spec URL: http://siddharths.fedorapeople.org/SPECS/plasma-mediacenter.spec SRPM URL: http://siddharths.fedorapeople.org/SRPMS/plasma-mediacenter-0.8.90-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #4 from Magnus Tuominen --- Adding to the review: No License files came with the source, so I do npt know what license the package is as the "homepage" does not mention any either, can you ask upstream to include a license file please? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814
--- Comment #3 from Magnus Tuominen ---
This is the review:
MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
rpmlint -iv plasma-mediacenter.spec
plasma-mediacenter.spec: I: checking-url
http://download.kde.org/unstable/plasma-mediacenter/0.9/src/plasma-mediacenter-0.9-beta.tar.gz
(timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint -iv ../SRPMS/plasma-mediacenter-0.9-2.fc17.src.rpm
plasma-mediacenter.src: I: checking
plasma-mediacenter.src: I: checking-url
http://download.kde.org/unstable/plasma-mediacenter/0.9/src (timeout 10
seconds)
plasma-mediacenter.src: I: checking-url
http://download.kde.org/unstable/plasma-mediacenter/0.9/src/plasma-mediacenter-0.9-beta.tar.gz
(timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint -iv ../RPMS/x86_64/plasma-mediacenter-*2*.rpm
plasma-mediacenter.x86_64: I: checking
plasma-mediacenter.x86_64: E: explicit-lib-dependency plasma-mobile-libs
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.
plasma-mediacenter.x86_64: I: checking-url
http://download.kde.org/unstable/plasma-mediacenter/0.9/src (timeout 10
seconds)
plasma-mediacenter.x86_64: E: invalid-soname /usr/lib64/libmediacenterlibs.so
libmediacenterlibs.so
The soname of the library is neither of the form lib.so. or
lib-.so.
plasma-mediacenter.x86_64: W: no-manual-page-for-binary plasma-mediacenter
Each executable in standard binary directories should have a man page.
plasma-mediacenter.x86_64: W: dangerous-command-in-%post cp
plasma-mediacenter.x86_64: W: one-line-command-in-%postun /sbin/ldconfig
You should use %postun -p instead of using: %postun It
will avoid the fork of a shell interpreter to execute your command as well as
allows rpm to automatically mark the dependency on your command for the
excecution of the scriptlet.
plasma-mediacenter-debuginfo.x86_64: I: checking
plasma-mediacenter-debuginfo.x86_64: I: checking-url
http://download.kde.org/unstable/plasma-mediacenter/0.9/src (timeout 10
seconds)
plasma-mediacenter-devel.x86_64: I: checking
plasma-mediacenter-devel.x86_64: I: checking-url
http://download.kde.org/unstable/plasma-mediacenter/0.9/src (timeout 10
seconds)
plasma-mediacenter-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
3 packages and 0 specfiles checked; 2 errors, 4 warnings.
?
The invalid-soname error can be ignored, not sure about %post .. maybe someone
more experienced can make a comment on that?
BR plasma-mobile-lib is probably not needed as plasma-mobile is listed as a BR.
MUST: The package must be named according to the Package Naming Guidelines.
OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK
MUST: The package must meet the Packaging Guidelines .
OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK
MUST: The spec file must be written in American English.
OK
MUST: The spec file for the package MUST be legible.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
SRPM:22df9da683c220303a5b300b1528b407
Upstream:22df9da683c220303a5b300b1528b407
OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]
OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
OK
MUST: Packages must NOT bundle copies of system libraries.
OK
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
OK
MUST: A package must own all directories that i
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 Magnus Tuominen changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 Magnus Tuominen changed: What|Removed |Added CC||magnus.tuomi...@gmail.com Assignee|nob...@fedoraproject.org|magnus.tuomi...@gmail.com Flags||fedora-review? --- Comment #2 from Magnus Tuominen --- Review coming soon. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 --- Comment #1 from Siddharth Sharma --- rebuilt for devel package split new links Spec URL: http://siddharths.fedorapeople.org/SPECS/plasma-mediacenter.spec SRPM URL: http://siddharths.fedorapeople.org/SRPMS/plasma-mediacenter-0.9-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 827814] Review Request: plasma-mediacenter - A mediacenter user interface written with the Plasma framework
https://bugzilla.redhat.com/show_bug.cgi?id=827814 Kevin Kofler changed: What|Removed |Added CC||ke...@tigcc.ticalc.org Blocks||656997 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
