[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 --- Comment #11 from Fedora Update System --- ghc-oeis-0.3.1-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 --- Comment #10 from Fedora Update System --- ghc-oeis-0.3.1-1.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-11 20:25:26 --- Comment #9 from Fedora Update System --- ghc-oeis-0.3.1-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- ghc-oeis-0.3.1-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 --- Comment #7 from Fedora Update System --- ghc-oeis-0.3.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ghc-oeis-0.3.1-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 --- Comment #6 from Fedora Update System --- ghc-oeis-0.3.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-oeis-0.3.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 --- Comment #5 from Fedora Update System --- ghc-oeis-0.3.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-oeis-0.3.1-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 Fedora Update System changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 Shakthi Kannan changed: What|Removed |Added Status|ASSIGNED|RELEASE_PENDING Flags||fedora-cvs? --- Comment #3 from Shakthi Kannan --- Thanks for the review. New Package SCM Request === Package Name: ghc-oeis Short Description: A oeis library for Haskell Owners: shakthimaan Branches: f16 f17 f18 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789
Lakshmi Narasimhan changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Lakshmi Narasimhan ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint -i *.rpm ../ghc-oeis.spec
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Build Requires list - OK
Summary and description - Not OK, requires better summary and
description
API documentation - OK
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
BSD
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum oeis-0.3.1.tar.gz
829308a22e330bef8e39a8fa88776488eba6213b1bd90cf70168811f5611ba4f
oeis-0.3.1.tar.gz
sha256sum ghc-oeis-0.3.1-1.fc16.src/oeis-0.3.1.tar.gz
829308a22e330bef8e39a8fa88776488eba6213b1bd90cf70168811f5611ba4f
ghc-oeis-0.3.1-1.fc16.src/oeis-0.3.1.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides.
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
Installed the packages. Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
pm -e ghc-oeis
error: Failed dependencies:
ghc(oeis-0.3.1) = cb2a9dd055fa16e38a914bfb2adc859b is needed by (installed)
ghc-oeis-devel-0.3.1-1.fc15.x86_64
ghc-oeis = 0.3.1-1.fc15 is needed by (installed)
ghc-oeis-devel-0.3.1-1.fc15.x86_64
[NA]MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
[NA]MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section
[+]MUST: Packages must not own files or directories already owned by other
packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.
Should items
[-]SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
[-]SHOULD: The reviewer should test that the package builds in mock.
[-]SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+]SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
Loaded Math.OEIS into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.
cabal2spec-diff is OK.
Please fix summary and description.
APPROVED
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 Lakshmi Narasimhan changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||lakshminaras2...@gmail.com Assignee|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828789] Review Request: ghc-oeis - Interface to the Online Encyclopedia of Integer Sequences
https://bugzilla.redhat.com/show_bug.cgi?id=828789 Shakthi Kannan changed: What|Removed |Added CC||haskell-devel@lists.fedorap ||roject.org --- Comment #1 from Shakthi Kannan --- $ rpmlint ghc-oeis.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-oeis-0.3.1-1.fc16.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-oeis-0.3.1-1.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-oeis-devel-0.3.1-1.fc16.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Successful Koji builds for F16, F17 and F18 respectively: http://koji.fedoraproject.org/koji/taskinfo?taskID=4128456 http://koji.fedoraproject.org/koji/taskinfo?taskID=4128457 http://koji.fedoraproject.org/koji/taskinfo?taskID=4128462 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
