[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #24 from Fedora Update System --- l3afpad-0.8.18.1.10-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LZahRoekyn&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #23 from Fedora Update System --- l3afpad-0.8.18.1.10-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SCYQ8fr9c3&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 Fedora Update System changed: What|Removed |Added Resolution|NEXTRELEASE |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gLrpkHvjjD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #22 from Fedora Update System --- l3afpad-0.8.18.1.10-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/l3afpad-0.8.18.1.10-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pcnDLWIBcA&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #21 from Fedora Update System --- l3afpad-0.8.18.1.10-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/l3afpad-0.8.18.1.10-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d7lpjOHCGU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 Benedikt Schäfer changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-02-23 15:53:13 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SzlnxuwQ50&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #20 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q0k8RYj8BY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 Christoph Wickert changed: What|Removed |Added Flags||fedora-cvs? --- Comment #19 from Christoph Wickert --- That is intended, Toshio pushed an exception. New Package SCM Request === Package Name: l3afpad Short Description: Simple text editor Owners: ib54003 cwickert Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q5s1jmCDx2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #18 from Jon Ciesla --- FAS email and bugzilla email don't match. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HTUr2ut2Oi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #16 from Benedikt Schäfer --- Package Name: l3afpad Short Description: Simple text editor Owners: ib54003 cwickert Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=S93PEoKZ5N&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=828993 Christoph Wickert changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags||fedora-cvs? --- Comment #17 from Christoph Wickert --- Benedikt, please make sure to use the template form the wiki *with* the heading. This is parsed by a tool and not done manually by a human. New Package SCM Request === Package Name: l3afpad Short Description: Simple text editor Owners: ib54003 cwickert Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m8qXzVcig9&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #15 from Benedikt Schäfer --- Ok, now it should be finished! Hopefully ;) Spec URL: http://ib54003.fedorapeople.org/rpm/l3afpad/l3afpad.spec SRPM URL: http://ib54003.fedorapeople.org/rpm/l3afpad/l3afpad-0.8.18.1.10-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #14 from Christoph Wickert --- You can do it in one step but please make sure to list all changes in the %changelog. E.g.: - Update to 0.8.18.1.10 - Fix this - Change that -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #13 from Benedikt Schäfer --- Ok do i have, first to correct the Specfile and than doing the upgrade to the new version or can i do it in one step. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #12 from Christoph Wickert --- New version 0.8.18.1.10 is out. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993
Christoph Wickert changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #11 from Christoph Wickert ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines (GPLv2+).
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[x]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later)", "GPL (v2 or later)". 2 files have unknown
license.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #10 from Christoph Wickert --- Spec URL: http://ib54003.fedorapeople.org/rpm/l3afpad/l3afpad.spec SRPM URL: http://ib54003.fedorapeople.org/rpm/l3afpad/l3afpad-0.8.18.1.9-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #9 from Benedikt Schäfer --- Ok, i finished the RPM! http://ib54003.fedorapeople.org/rpm/l3afpad/ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 John Morris changed: What|Removed |Added CC||j...@zultron.com --- Comment #8 from John Morris --- Christoph is right. Suggestion withdrawn. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993
Christoph Wickert changed:
What|Removed |Added
Flags|needinfo?(j...@zultron.com) |
--- Comment #7 from Christoph Wickert ---
$ rpm --eval %{_iconsdir}
/usr/share/icons
$ rpm --eval %{_desktopdir}
/usr/share/applications
So the two marcos are defined...
$ grep -r %_desktopdir /etc/rpm
/etc/rpm/macros.jpackage:%_desktopdir%{_datadir}/applications
$ grep -r %_iconsdir /etc/rpm
/etc/rpm/macros.jpackage:%_iconsdir%{_datadir}/icons
... and they are defined in /etc/rpm/macros.jpackage
$ rpm -qf /etc/rpm/macros.jpackage
jpackage-utils-1.7.5-18.1.fc17.x86_64
... which belongs to jpackage-utils. This means we either need "BuildRequires:
jpackage-utils" or use the %{_datadir} marco. I thin this is better because we
cannot be sure that jpackage-utils is always available. We should not require
anything just for two macro.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993
Christoph Wickert changed:
What|Removed |Added
Flags||needinfo?(j...@zultron.com)
--- Comment #6 from Christoph Wickert ---
The new package does not build:
Fehler beim Bauen des RPM:
Datei muss mit "/" beginnen: %{_desktopdir}/l3afpad.desktop
Datei muss mit "/" beginnen: %{_iconsdir}/hicolor/*/apps/
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
John, I never heard of %{_desktopdir} and %{_iconsdir}. Are you sure these
macros are defined in Fedora?
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #5 from Benedikt Schäfer --- Hi, sorry that i answer only now, but i completely forgot it. Here are the corrections: Spec URL: http://ib54003.fedorapeople.org/rpm/l3afpad/l3afpad.spec SRPM URL: http://ib54003.fedorapeople.org/rpm/l3afpad/l3afpad-0.8.18.1.9-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993
--- Comment #4 from John Morris ---
Hi Benedikt, here are a few issues, the first detected by fedora-review, the
rest I found myself. Be sure to check the attached review. I checked most of
the items, but left a few blank.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
** rm -rf %{buildroot} in %install; is this intended for EPEL5?
[!]: MUST Package consistently uses macros (instead of hard-coded directory
names).
** There is an %{_iconsdir} macro; could replace %{_datadir}/icons
** There is a %{_desktopdir} macro; could replace %{_datadir}/applications
[!]: MUST Package does not own files or directories owned by other packages.
** Does this pkg need to own all those directories in %{_iconsdir}?
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Patch0: l3afpad-0.8.18.1.9-missing-semicolon.patch
(l3afpad-0.8.18.1.9-missing-semicolon.patch)
** I'd put:
** Patch0: %{name}-%{version}-missing-semicolon.patch
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #3 from John Morris --- Created attachment 595172 --> https://bugzilla.redhat.com/attachment.cgi?id=595172&action=edit fedora-review for l3afpad Output of fedora-review; Items marked with a capital "X" are items I checked manually. Items needing attention pasted at bottom. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 --- Comment #2 from Christoph Wickert --- Yes, l3afpad is not leafpad but a fork of it that builds against GTK3 and includes some bugfixes. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 John Morris changed: What|Removed |Added CC||j...@zultron.com --- Comment #1 from John Morris --- Hi Benedikt, Is your package different from the one already available in Fedora? https://admin.fedoraproject.org/pkgdb/applications/Leafpad?_csrf_token=70d0c084cbc576fc84e1b9af29b57c12a06ac409 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 828993] Review Request: l3afpad - Simple text editor
https://bugzilla.redhat.com/show_bug.cgi?id=828993 Christoph Wickert changed: What|Removed |Added Summary|Review Request: |Review Request: l3afpad - |l3afpad-0.8.18.1.9-1 - Text |Simple text editor |Editor | Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
