[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=829970 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-18 23:27:39 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #15 from Jørn Lomax northlo...@gmail.com --- No problem, happy to be of assistance * This package is APPROVED* * -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #16 from Brendan Jones brendan.jones...@gmail.com --- Thanks for the review! New Package SCM Request === Package Name: synthv1 Short Description: 4 oscillator subtractive polyphonic synthesizer Owners: bsjones Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #14 from Brendan Jones brendan.jones...@gmail.com --- The website is back. Thanks for the review -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970
--- Comment #13 from Jørn Lomax northlo...@gmail.com ---
Seems like my laptop doesn't like doing reviews. Here is the full one:
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[ ]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Note: Unversioned so-files in non-devel package (fix or
explain):lv2-synthv1-0.0.9-0.2.svn762.fc17.i686.rpm :
/usr/lib/lv2/synthv1.lv2/synthv1.so
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package installs a %{name}.desktop using desktop-file-install if
there is such a file.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) GENERATED FILE, *No copyright* GENERATED FILE, GPL
(v2 or later) For detailed output of licensecheck see file:
/home/makerpm/rpmbuild/REVIEW/829970-synthv1/srpm/synthv1/licensecheck.txt
[ ]: MUST License file installed when any subpackage combination is installed.
[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[ ]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[ ]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[ ]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #6 from Jørn Lomax northlo...@gmail.com --- please add desktop-file-utils to the build requires and add a script or short comment on how to obtain the source code (or see guidelines for other options[1]) [1]http://fedoraproject.org/wiki/Packaging:SourceURL -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #7 from Brendan Jones brendan.jones...@gmail.com --- Added missing build requires. For some reason Rui's site is down at the moment. The tarball is downloaded from there as given via the SourceURL SRPM: http://bsjones.fedorapeople.org/synthv1-0.0.9-0.2.svn762.fc17.src.rpm SPEC: http://bsjones.fedorapeople.org/synthv1.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #8 from Jørn Lomax northlo...@gmail.com --- ahh, that explains it. It still needs desktop-file-utils added as a build require before it can be built -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #9 from Brendan Jones brendan.jones...@gmail.com --- Hmmm, it is there, -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|northlo...@gmail.com --- Comment #10 from Jørn Lomax northlo...@gmail.com --- My eyes deceive me! It's there, right in front of my eyes when i open the spec file again I can't seem to get it to build though, i get the following error: checking for suffix of object files... configure: error: in `/builddir/build/BUILD/synthv1-0.0.9svn762': configure: error: cannot compute suffix of object files: cannot compile -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #11 from Brendan Jones brendan.jones...@gmail.com --- I'm not sure why: I can do a scratch build in f18 / f19 just fine: koji build --scratch f19 /home/bsjones/rpmbuild/SRPMS/synthv1-0.0.9-0.2.svn762.fc17.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=4378347 If you are still having trouble can you attach the build log? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #12 from Jørn Lomax northlo...@gmail.com --- h I'll give it a go tomorrow on my desktop. It could be my laptop config that is borked -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #5 from Brendan Jones brendan.jones...@gmail.com --- New upstream version: SRPM: http://bsjones.fedorapeople.org/synthv1-0.0.9-0.1.svn762.fc17.src.rpm SPEC: http://bsjones.fedorapeople.org/synthv1.spec -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #4 from Jørn Lomax northlo...@gmail.com --- Now that i know how, here is a more formal (but still informal) review: There where a couple of rpmlint warnings: rpmlint synthv1-0.0.1-0.1.svn671.fc18.i686.rpm synthv1.i686: W: spelling-error Summary(en_US) subtractive - subtracting, subt$ synthv1.i686: W: spelling-error %description -l en_US subtractive - subtractin$ synthv1.i686: W: spelling-error %description -l en_US fx - Fox, fax, fix synthv1.i686: W: incoherent-version-in-changelog 0.0.1-1 ['0.0.1-0.1.svn671.fc1$ synthv1.i686: W: no-manual-page-for-binary synthv1_jack 1 packages and 0 specfiles checked; 0 errors, 5 warnings The second to last one can be fixed by just bumping the version number in the spec. The last line is fine, as synthv1_jack does not have a man page rpmlint lv2-synthv1-0.0.1-0.1.svn671.fc18.i686.rpm lv2-synthv1.i686: W: spelling-error %description -l en_US subtractive - subtra$ lv2-synthv1.i686: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. I would imagine it has the same documentation as synthv1, and i ll take a guess you are aware of it. [!]: MUST Development (unversioned) .so files in -devel subpackage, if present. Note: lv2-synthv1-0.0.1-0.1.svn671.fc18.i686.rpm : /usr/lib/lv2/synthv1.lv2/synthv1.so Since this .so file is application spesific, so there is no need for a -devel package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #3 from Jørn Lomax northlo...@gmail.com --- I have gone through the checklist, and can't find any issues. I tested it and it installs and runs on fedora 17 i686 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970
--- Comment #1 from Jørn Lomax northlo...@gmail.com ---
You might want to check the links:
URL: http://www.rnbc.org/
Source0: http://www.rncbc.org/snapshots/%{svnname}.tar.gz
I don't think either points to where you want it to point
Other than that it looks good
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 --- Comment #2 from Brendan Jones brendan.jones...@gmail.com --- SRPM: http://bsjones.fedorapeople.org/synthv1-0.0.1-0.2.svn671.fc17.src.rpm SPEC: http://bsjones.fedorapeople.org/synthv1.spec Indeed - the URL is incorrect - the Source is OK. There is no specific project page as yet, so linking directly to the authors site for now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 829970] Review Request: synthv1 - a 4 oscillator subtractive polyphonic synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=829970 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added Blocks||805236 (FedoraAudio) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
