[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2012-08-17 15:09:37 --- Comment #8 from Matthias Runge mru...@matthias-runge.de --- ok, it's built and imported. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 Matthias Runge mru...@matthias-runge.de changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Matthias Runge mru...@matthias-runge.de --- OK, finally package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 --- Comment #6 from Praveen Kumar kumarpraveen.nit...@gmail.com --- New Package SCM Request === Package Name: python-django-pylibmc Short Description: Django cache backend using pylibmc Owners: kumarpraveen Branches: devel -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 Praveen Kumar kumarpraveen.nit...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 --- Comment #4 from Praveen Kumar kumarpraveen.nit...@gmail.com --- Made minor changes according to review. Spec URL: http://kumarpraveen.fedorapeople.org/django-pylibmc/python-django-pylibmc.spec SRPM URL: http://kumarpraveen.fedorapeople.org/django-pylibmc/python-django-pylibmc-0.2.3-2.20120609git28874f.fc17.src.rpm Koji Task : http://koji.fedoraproject.org/koji/taskinfo?taskID=4211548 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 --- Comment #3 from Matthias Runge mru...@matthias-runge.de --- OK, thank you Michael, for the reminder. [mrunge@mrungexp review]$ rpm -qp --provides /var/lib/mock/fedora-rawhide-i386/result/python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.noarch.rpm django-pylibmc = 0.2.3-1.20120609git28874f.fc18 python-django-pylibmc = 0.2.3-1.20120609git28874f.fc18 [mrunge@mrungexp review]$ rpm -qp --requires /var/lib/mock/fedora-rawhide-i386/result/python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.noarch.rpm python(abi) = 2.7 rpmlib(CompressedFileNames) = 3.0.4-1 rpmlib(FileDigests) = 4.6.0-1 rpmlib(PartialHardlinkSets) = 4.0.4-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 rpmlib(PayloadIsXz) = 5.2-1 no python-django? I have missed that in my review. obsoletes: obsoletes the latest version before the rename. (OK) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421
Matthias Runge mru...@matthias-runge.de changed:
What|Removed |Added
Status|NEW |ASSIGNED
Blocks||736776
Flags||fedora-review?
--- Comment #1 from Matthias Runge mru...@matthias-runge.de ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package does not require other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[!]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.src.rpm
python-django-pylibmc.src: W: spelling-error Summary(en_US) backend - backed,
back end, back-end
python-django-pylibmc.src: W: spelling-error %description -l en_US memcached -
schemed
python-django-pylibmc.src: W: spelling-error %description -l en_US backend -
backed, back end, back-end
python-django-pylibmc.src: W: invalid-url Source0:
python-django-pylibmc-0.2.3.20120609git28874f.tar.xz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
rpmlint python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.noarch.rpm
python-django-pylibmc.noarch: W: spelling-error Summary(en_US) backend -
backed, back end, back-end
python-django-pylibmc.noarch: W: spelling-error %description -l en_US memcached
- schemed
python-django-pylibmc.noarch: W: spelling-error %description -l en_US backend
- backed, back end, back-end
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
Package has no sources or they are generated by developer
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 --- Comment #2 from Michael Schwendt mschwe...@gmail.com --- Please notice the MUST items at http://fedoraproject.org/wiki/Package_Renaming_Process which affect both the packager and the reviewer. [...] $ yum search django-avatar django-pylibmc Loaded plugins: auto-update-debuginfo, langpacks, presto, refresh-packagekit == N/S Matched: django-avatar == django-avatar.noarch : A django module for handling user avatars = N/S Matched: django-pylibmc == django-pylibmc.noarch : Django cache backend using pylibmc -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 830421] Review Request: python-django-pylibmc - Django cache backend using pylibmc
https://bugzilla.redhat.com/show_bug.cgi?id=830421 Praveen Kumar kumarpraveen.nit...@gmail.com changed: What|Removed |Added CC||mschwe...@gmail.com Assignee|nob...@fedoraproject.org|mru...@matthias-runge.de QA Contact|extras...@fedoraproject.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
