[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-02-09 23:29:54 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x1apBXgTM4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- crrcsim-0.9.12-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WWhY4oHM21a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- crrcsim-0.9.12-2.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UVwKVMfxpka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- crrcsim-0.9.12-2.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LuVejtJXCTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rpV1Vku2ZHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #3 from Miroslav Lichvar mlich...@redhat.com --- The FSF address should be updated too, but that's upstream's job. Please add the dependency to -doc and make it noarch and I think the package can be approved. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T01VBFci37a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #4 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Dependency and noarch for -doc added: Spec URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/crrcsim.spec SRPM URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/crrcsim-0.9.12-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UBdRGWS9qna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #5 from Miroslav Lichvar mlich...@redhat.com --- Looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=njQuAoBSPqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 Damian Wrobel dwro...@ertelnet.rybnik.pl changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- New Package SCM Request === Package Name: crrcsim Short Description: Model-Airplane Flight Simulation Program Owners: dwrobel Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=POw6MF5Ebwa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MZSbXyGWvPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HVnYLFPorXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- crrcsim-0.9.12-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/crrcsim-0.9.12-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J1crcKpTDWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- crrcsim-0.9.12-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/crrcsim-0.9.12-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rElai7a029a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mlich...@redhat.com Assignee|nob...@fedoraproject.org|mlich...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wBs1mMP985a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=832524
Miroslav Lichvar mlich...@redhat.com changed:
What|Removed |Added
Flags||needinfo?(dwrobel@ertelnet.
||rybnik.pl)
--- Comment #1 from Miroslav Lichvar mlich...@redhat.com ---
The package looks good, I see only two minor issues with the -doc subpackage.
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
= MUST items =
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install if there is
such a file.
[-]: Development files must be in a -devel package
[-]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Fully versioned dependency in subpackages, if present.
[!]: Package complies to the Packaging Guidelines
-doc doesn't depend on the base package (e.g. Requires: %{name}%{?_isa} =
%{version}-%{release})
Also, please make -doc noarch.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
GPLv2
[!]: License file installed when any subpackage combination is installed.
The dependency in -doc on the base package will fix this.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[-]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include
[Bug 832524] Review Request: crrcsim - Model-Airplane Flight Simulation Program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832524 Damian Wrobel dwro...@ertelnet.rybnik.pl changed: What|Removed |Added Flags|needinfo?(dwrobel@ertelnet. | |rybnik.pl) | --- Comment #2 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Miroslav, thanks for the review. (In reply to comment #1) The package looks good, I see only two minor issues with the -doc subpackage. Rpmlint --- crrcsim.x86_64: E: incorrect-fsf-address /usr/share/doc/crrcsim-0.9.12/COPYING crrcsim-doc.x86_64: E: incorrect-fsf-address /usr/share/doc/crrcsim/input_method/PARALLEL_1_to_3/crrcsim_at90s1200.asm I know about it, but based on an opinion from a different issue e.g. bug 700095, comment 1 it seems to be false positive. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=irsPpEIEyFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
