[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- kfaenza-icon-theme-0.8.9-3.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832666 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-28 06:26:28 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- kfaenza-icon-theme-0.8.9-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- kfaenza-icon-theme-0.8.9-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- kfaenza-icon-theme-0.8.9-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kfaenza-icon-theme-0.8.9-3.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- kfaenza-icon-theme-0.8.9-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kfaenza-icon-theme-0.8.9-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- kfaenza-icon-theme-0.8.9-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/kfaenza-icon-theme-0.8.9-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- kfaenza-icon-theme-0.8.9-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #11 from Minh Ngo nlmin...@gmail.com --- New Package SCM Request === Package Name: kfaenza-icon-theme Short Description: Faenza-Cupertino Icon Theme for KDE Owners: minh Branches: f16 f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags||needinfo?(nlmin...@gmail.co ||m) --- Comment #8 from Rex Dieter rdie...@math.unl.edu --- ping, it's been a little while, you still able and interested in kfaenza-icon-theme ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Flags|needinfo?(nlmin...@gmail.co | |m) | --- Comment #9 from Minh Ngo nlmin...@gmail.com --- Yes. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #10 from Rex Dieter rdie...@math.unl.edu --- On the other hand, pretty much all of my comments are non-blockers (even the scriptlet thing, it's only an optimization). APPROVED i'll try to look things over again once you've imported it to be sure, and please do address all those SHOULD items prior to doing any official builds. thanks. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #7 from Rex Dieter rdie...@math.unl.edu --- $ rpmlint kfaenza-icon-theme.spec kfaenza-icon-theme.spec: W: no-%build-section 0 packages and 1 specfiles checked; 0 errors, 1 warnings. naming: ok 1. SHOULD drop index.patch, I don't think it's helpful. Looks like faenza actually installs as Faenza ondisk, and the other inherits look legit to me. 2. MUST drop -f from gtk-update-icon-cache scriptlet calls (the guidelines were recently fixed to not include that) 3. SHOULD drop deprecated/unused .spec tags, including: Group: 4. SHOULD drop BuildRequires: gtk2 = 2.6.0 doesn't look like it's used or needed here (if it is, please document why in the .spec) 5. SHOULD ping upstream to include licensing information/file in their source tarball 6. SHOULD consider using the included INSTALL script in some form. it looks like it creates a bunch of compatibiliy symlinks for various things -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #6 from Minh Ngo nlmin...@gmail.com --- Hidden files have been removed: SPEC: https://raw.github.com/Ignotus/fedora-packages/cc195da803c2dd195727dc2ebb4399503e81677b/kfaenza-icon-theme/kfaenza-icon-theme.spec SRPM file is too large for uploading. Please use BUILD.sh script from https://github.com/Ignotus/fedora-packages/tree/cc195da803c2dd195727dc2ebb4399503e81677b/kfaenza-icon-theme for building. Patches are there too. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #5 from Minh Ngo nlmin...@gmail.com --- Have you tried to download this link (http://omploader.org/vYjR0NQ/kfaenza-icon-theme-0.8.9.tar.gz ) by wget? It works. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Brendan Jones brendan.jones...@gmail.com changed: What|Removed |Added CC||brendan.jones...@gmail.com --- Comment #4 from Brendan Jones brendan.jones...@gmail.com --- Hi, can you please address the invalid-url and hidden-file-or-dir warnings? f17laptop:~ $ rpmlint ~/Downloads/kfaenza-icon-theme-0.8.9-2.fc17.src.rpm kfaenza-icon-theme.src: W: spelling-error Summary(en_US) Faenza - Cadenza kfaenza-icon-theme.src: W: no-%build-section kfaenza-icon-theme.src: W: invalid-url Source0: http://ompldr.org/vYjR0NQ/kfaenza-icon-theme-0.8.9.tar.gz urlopen error [Errno 111] Connection refused 1 packages and 0 specfiles checked; 0 errors, 3 warnings. f17laptop:~ $ rpmlint /home/bsjones/rpmbuild/RPMS/noarch/kfaenza-icon-theme-0.8.9-2.fc17.noarch.rpm kfaenza-icon-theme.noarch: W: spelling-error Summary(en_US) Faenza - Cadenza kfaenza-icon-theme.noarch: W: no-documentation kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/32/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/emblems/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/32/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/emblems/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/32/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/actions/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/scalable/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/16/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/status/48/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/places/256/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/apps/128/.directory kfaenza-icon-theme.noarch: E: zero-length /usr/share/icons/KFaenza/actions/64/stock_new-address-book.png kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/128/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/devices/64/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/categories/22/.directory kfaenza-icon-theme.noarch: W: hidden-file-or-dir /usr/share/icons/KFaenza/mimetypes/256/.directory kfaenza-icon-theme.noarch: W:
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #3 from Minh Ngo nlmin...@gmail.com --- SRPM: https://www.dropbox.com/s/35ymr1akaxwlih6/kfaenza-icon-theme-0.8.9-2.fc17.src.rpm SPEC: https://dl-web.dropbox.com/get/rpm/kfaenza-icon-theme.spec?w=26907e7f -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #2 from Rex Dieter rdie...@math.unl.edu --- pre-review comments: 1. missing icon-related scriptlets, https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache Didn't look to check yet, but this theme may benefit from including Inherits=faenza in it's theme file. from faenza-icon-theme already in fedora. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 --- Comment #1 from Minh Ngo nlmin...@gmail.com --- *** Bug 832669 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832666] Review Request: kfaenza-icon-theme - Faenza-Cupertino Icon Theme for KDE
https://bugzilla.redhat.com/show_bug.cgi?id=832666 Minh Ngo nlmin...@gmail.com changed: What|Removed |Added Blocks||656997 (kde-reviews) Alias||kfaenza-icon-theme -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
