[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-07-07 17:55:23 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks|833641 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks|835338 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Krzysztof Daniel kdan...@redhat.com --- Thanks, for the package. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Gerard Ryan ger...@ryan.lt --- New Package SCM Request === Package Name: eclipse-wtp-jeetools Short Description: A set of Eclipse plugins that provides frameworks and tools focused on the development of J2EE artifacts Owners: galileo Branches: f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||835338 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Krzysztof Daniel kdan...@redhat.com changed: What|Removed |Added CC||kdan...@redhat.com Assignee|nob...@fedoraproject.org|kdan...@redhat.com --- Comment #2 from Krzysztof Daniel kdan...@redhat.com --- I'll review this one. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154
Krzysztof Daniel kdan...@redhat.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #3 from Krzysztof Daniel kdan...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[z]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[!]: MUST Package installs properly.
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.wsdl)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws.explorer)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.command.env.core)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: eclipse-wtp-webservices
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.wsdl.validation)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws.parser)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.ws.ui)
Error: Package: eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch
(/eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch)
Requires: osgi(org.eclipse.wst.command.env)
[!]: MUST Requires correct, justified where necessary.
Eclipse bundles should have version specified (as they are very version
sensitive).
[x]: MUST Rpmlint output is silent.
rpmlint eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint eclipse-wtp-jeetools-3.4.0-0.1.20120618cvs.fc18.src.rpm
eclipse-wtp-jeetools.src: W: invalid-url Source0:
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 --- Comment #4 from Gerard Ryan ger...@ryan.lt --- Thanks for taking this! Regarding Issue (1): Is this relating to the errors in this part?: [!]: MUST Package installs properly. All of the osgi packages that give an error there, are from eclipse-wtp-webservices, and indeed eclipse-wtp-webservices is throwing an error here. I don't understand this, as eclipse-wtp-webservices is already in rawhide[1]. Is it not finding this package, or am I misunderstanding the issue? [1] http://koji.fedoraproject.org/koji/packageinfo?packageID=14110 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 --- Comment #5 from Gerard Ryan ger...@ryan.lt --- Issue (3): For the eclipse bundles, I understand that the versions for the osgi bundles are specified in the MANIFEST.MF files for each plugin. At the moment, they look like this by default: org.eclipse.wst.wsdl;bundle-version=[1.2.0,1.3.0) - is that enough or should they require the exact bundle that's packaged in Fedora? In which case the above example would look like: org.eclipse.wst.wsdl;bundle-version=1.2.300 The default in that example seems to work fine[1]. I don't know why none of that stuff was being picked up when you tried to build. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4187879 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154
--- Comment #6 from Gerard Ryan ger...@ryan.lt ---
Spec URL:
http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.2.20120618cvs/eclipse-wtp-jeetools.spec
SRPM URL:
http://galileo.fedorapeople.org/eclipse-wtp-jeetools/3.4.0/0.2.20120618cvs/eclipse-wtp-jeetools-3.4.0-0.2.20120618cvs.fc17.src.rpm
- changed the patch names to be properly prefixed by %{name}
- added min versions to all BR/R except java and jpackage-utils
In your first review, it seems that eclipse-wtp-webservices wasn't included as
a dependency for some reason, even though it's in rawhide, as linked in comment
#4 above. Any ideas why that might be? Is there something I haven't done with
that package that's preventing it?
Thanks again for your time!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||833641 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833154] Review Request: eclipse-wtp-jeetools - Frameworks and tools for Eclipse, focused on the development of J2EE artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=833154 --- Comment #1 from Gerard Ryan ger...@ryan.lt --- Note: the following additional license files exist: ./plugins/org.eclipse.jst.j2ee/license/berkeley_license.html ./plugins/org.eclipse.jst.jee/license/berkeley_license.html but I haven't been able to find any code licensed under anything besides the EPL. I don't know why these files are here, and I haven't included them. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
