[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 --- Comment #11 from Fedora Update System --- ghc-data-inttrie-0.0.7-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 --- Comment #10 from Fedora Update System --- ghc-data-inttrie-0.0.7-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-11 20:30:04 --- Comment #9 from Fedora Update System --- ghc-data-inttrie-0.0.7-1.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- ghc-data-inttrie-0.0.7-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 --- Comment #7 from Fedora Update System --- ghc-data-inttrie-0.0.7-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ghc-data-inttrie-0.0.7-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 --- Comment #6 from Fedora Update System --- ghc-data-inttrie-0.0.7-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-data-inttrie-0.0.7-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 --- Comment #5 from Fedora Update System --- ghc-data-inttrie-0.0.7-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ghc-data-inttrie-0.0.7-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 Fedora Update System changed: What|Removed |Added Status|RELEASE_PENDING |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 Shakthi Kannan changed: What|Removed |Added Status|ASSIGNED|RELEASE_PENDING Flags||fedora-cvs? --- Comment #3 from Shakthi Kannan --- Thanks for the review. New Package SCM Request === Package Name: ghc-data-inttrie Short Description: A simple lazy, infinite trie from integers Owners: shakthimaan Branches: f16 f17 f18 InitialCC: haskell-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356
Lakshmi Narasimhan changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #2 from Lakshmi Narasimhan ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
ghc-data-inttrie.src: W: spelling-error Summary(en_US) trie -> tire, true, tie
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.src: W: spelling-error %description -l en_US trie -> tire,
true, tie
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.src: W: spelling-error %description -l en_US eg -> eh, e, g
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.src: W: spelling-error %description -l en_US foldr -> fold,
folder, folds
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.x86_64: W: spelling-error Summary(en_US) trie -> tire, true,
tie
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.x86_64: W: spelling-error %description -l en_US trie -> tire,
true, tie
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.x86_64: W: spelling-error %description -l en_US foldr -> fold,
folder, folds
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
ghc-data-inttrie-devel.x86_64: W: spelling-error Summary(en_US) trie -> tire,
true, tie
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie-devel.x86_64: W: spelling-error %description -l en_US trie ->
tire, true, tie
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie-devel.x86_64: W: spelling-error %description -l en_US eg ->
eh, e, g
The value of this tag appears to be misspelled. Please double-check.
ghc-data-inttrie-devel.x86_64: W: spelling-error %description -l en_US foldr ->
fold, folder, folds
The value of this tag appears to be misspelled. Please double-check.
3 packages and 1 specfiles checked; 0 errors, 13 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK, BSD
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Build Requires list - OK
Summary and description - OK
API documentation - OK, in devel package
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
The package has only one source file which mentions the license to be BSD. Also
.cabal file's license field is BSD.
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file is not included. Packager has requested upstream to include it
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
sha256sum data-inttrie-0.0.7.tar.gz
37828f696c966ad4b6b7f533bb348e77b5dcbdf9e9c69973bc68c82bae41a5a5
data-inttrie-0.0.7.tar.gz
sha256sum ghc-data-inttrie-0.0.7-1.fc16.src/data-inttrie-0.0.7.tar.gz
37828f696c966ad4b6b7f533bb348e77b5dcbdf9e9c69973bc68c82bae41a5a5
ghc-data-inttrie-0.0.7-1.fc16.src/data-inttrie-0.0.7.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 Lakshmi Narasimhan changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 Lakshmi Narasimhan changed: What|Removed |Added Status|NEW |ASSIGNED CC||lakshminaras2...@gmail.com Assignee|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 833356] Review Request: ghc-data-inttrie - A simple lazy, infinite trie from integers
https://bugzilla.redhat.com/show_bug.cgi?id=833356 Shakthi Kannan changed: What|Removed |Added CC||haskell-devel@lists.fedorap ||roject.org --- Comment #1 from Shakthi Kannan --- $ rpmlint ghc-data-inttrie.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint ghc-data-inttrie-0.0.7-1.fc16.x86_64.rpm ghc-data-inttrie.x86_64: W: spelling-error Summary(en_US) trie -> tire, true, tie ghc-data-inttrie.x86_64: W: spelling-error %description -l en_US trie -> tire, true, tie ghc-data-inttrie.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g ghc-data-inttrie.x86_64: W: spelling-error %description -l en_US foldr -> fold, folder, folds ghc-data-inttrie.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ rpmlint ghc-data-inttrie-devel-0.0.7-1.fc16.x86_64.rpm ghc-data-inttrie-devel.x86_64: W: spelling-error Summary(en_US) trie -> tire, true, tie ghc-data-inttrie-devel.x86_64: W: spelling-error %description -l en_US trie -> tire, true, tie ghc-data-inttrie-devel.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g ghc-data-inttrie-devel.x86_64: W: spelling-error %description -l en_US foldr -> fold, folder, folds 1 packages and 0 specfiles checked; 0 errors, 4 warnings. $ rpmlint ghc-data-inttrie-0.0.7-1.fc16.src.rpm ghc-data-inttrie.src: W: spelling-error Summary(en_US) trie -> tire, true, tie ghc-data-inttrie.src: W: spelling-error %description -l en_US trie -> tire, true, tie ghc-data-inttrie.src: W: spelling-error %description -l en_US eg -> eh, e, g ghc-data-inttrie.src: W: spelling-error %description -l en_US foldr -> fold, folder, folds 1 packages and 0 specfiles checked; 0 errors, 4 warnings. Successful Koji builds for F16, F17, and F18 respectively: http://koji.fedoraproject.org/koji/taskinfo?taskID=4176162 http://koji.fedoraproject.org/koji/taskinfo?taskID=4176160 http://koji.fedoraproject.org/koji/taskinfo?taskID=4176153 I have informed upstream to add a LICENSE file to the sources. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
