[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #28 from Darryl L. Pierce dpie...@redhat.com --- Package Change Request == Package Name: perl-qpid New Branches: epel7 Owners: mcpierce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #29 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #26 from Darryl L. Pierce dpie...@redhat.com --- Package Change Request == Package Name: perl-qpid New Branches: el5 el6 Owners: mcpierce -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eOep134YTsa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #27 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7wKFUACyrQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Pq8gxJ7B65a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #19 from Peter Lemenkov lemen...@gmail.com --- Fails to build in Rawhide (this is a blocker): * http://koji.fedoraproject.org/koji/taskinfo?taskID=4477233 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #20 from Darryl L. Pierce dpie...@redhat.com --- (In reply to comment #19) Fails to build in Rawhide (this is a blocker): * http://koji.fedoraproject.org/koji/taskinfo?taskID=4477233 Ugh, I was afraid of this. The problem is that I rebased the Perl package on 0.18 of Qpid which is still only in testing ATM. I'm going to revert back to being based only on 0.16 so we can work against what is the current stable release. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4477354 Reverted SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec Reverted SRPM: http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #21 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #20) (In reply to comment #19) Fails to build in Rawhide (this is a blocker): * http://koji.fedoraproject.org/koji/taskinfo?taskID=4477233 Ugh, I was afraid of this. The problem is that I rebased the Perl package on 0.18 of Qpid which is still only in testing ATM. I'm going to revert back to being based only on 0.16 so we can work against what is the current stable release. Yep, this sounds like a plan. Be right back - stay tuned. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070
Peter Lemenkov lemen...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #22 from Peter Lemenkov lemen...@gmail.com ---
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
work ~/Desktop: rpmlint perl-qpid-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
work ~/Desktop:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license (Apache
Software License v2).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
sulaco ~/rpmbuild/SOURCES: sha256sum perl-qpid-0.16.tar.gz*
266f0e187e9df43dc85422d4a1b934fcfbb15c83a50e1a8ac73a62ef47953ca4
perl-qpid-0.16.tar.gz
266f0e187e9df43dc85422d4a1b934fcfbb15c83a50e1a8ac73a62ef47953ca4
perl-qpid-0.16.tar.gz.1
sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
0 The package DOESN'T have a %clean section, so it won't build cleanly on
systems with old rpm (EL-4 and EL-5, not sure about EL-6). Beware.
+ The package consistently uses macros. Well, almost consistently. You should
change $RPM_BUILD_ROOT to %{buildroot} but this isn't a blocker from my PoV.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No C/C++ header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files without a suffix (e.g. libfoo.so)
in some of the dynamic linker's default paths.
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
0 At the beginning of %install, the package does not run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT) so it won't build cleanly on systems with old rpm (EL-4
and EL-5, not sure about EL-6). Beware.
+ All filenames in the package(s) are valid UTF-8.
APPROVED.
PS it will be great if you review this package in return:
* https://bugzilla.redhat.com/845221 - ilbc - Internet Low Bitrate Codec
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #23 from Darryl L. Pierce dpie...@redhat.com --- Thank you, Peter! New Package SCM Request === Package Name: perl-qpid Short Description: Perl bindings for the Qpid messaging framework Owners: mcpierce Branches: f16 f17 f18 InitialCC: mcpierce -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #24 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2012-09-12 11:36:15 --- Comment #25 from Darryl L. Pierce dpie...@redhat.com --- Thank you, Jon and Peter! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #17 from Darryl L. Pierce dpie...@redhat.com --- Updated SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.18-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com Assignee|nob...@fedoraproject.org|lemen...@gmail.com Flags||fedora-review? --- Comment #18 from Peter Lemenkov lemen...@gmail.com --- I'll review it. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Cheryn Tan che...@redhat.com changed: What|Removed |Added Blocks||853856 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Cheryn Tan che...@redhat.com changed: What|Removed |Added Blocks||853859 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|j...@di.uminho.pt|nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added CC|j...@di.uminho.pt| --- Comment #16 from Darryl L. Pierce dpie...@redhat.com --- Updated SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Blocks|808577 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 ppecka ppe...@redhat.com changed: What|Removed |Added Blocks||808577 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #13 from Darryl L. Pierce dpie...@redhat.com --- Just following up since another week has passed. I appreciate other things can come up, but can we go ahead an finish this review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #12 from Darryl L. Pierce dpie...@redhat.com --- Please, can we wrap up this package review? I understand that other tasks can pull you away, but it seems that I've met all review expectations and would like to get this package done. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Jose Pedro Oliveira j...@di.uminho.pt changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #10 from Jose Pedro Oliveira j...@di.uminho.pt --- Darryl L. Pierce, Is upstream really splitting the qpid monolithic tarball? I'm asking his because I saw the answer you got to your mail * 0.18 inclusion request - Perl upstream tarball changes http://qpid.2158936.n2.nabble.com/0-18-inclusion-request-Perl-upstream-tarball-changes-td7579593.html in the qpid developer and having separated tarballs doesn't seem to be in the roadmap. /jpo -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #11 from Darryl L. Pierce dpie...@redhat.com --- (In reply to comment #10) Darryl L. Pierce, Is upstream really splitting the qpid monolithic tarball? I'm asking his because I saw the answer you got to your mail * 0.18 inclusion request - Perl upstream tarball changes http://qpid.2158936.n2.nabble.com/0-18-inclusion-request-Perl-upstream- tarball-changes-td7579593.html in the qpid developer and having separated tarballs doesn't seem to be in the roadmap. Yes, it's the goal. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #9 from Darryl L. Pierce dpie...@redhat.com --- Would it be possible to wrap this review up in the next day or so? Also, please move the status from NEW to ASSIGNED. Thanks. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #7 from Jose Pedro Oliveira j...@di.uminho.pt --- (In reply to comment #6) If the above changes are sufficient, could we wrap up the review? Sorry but I won't be able to resume the review until Monday. This week has been rather complicated and I will be offline during the weekend. /jpo -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #8 from Darryl L. Pierce dpie...@redhat.com --- (In reply to comment #7) (In reply to comment #6) If the above changes are sufficient, could we wrap up the review? Sorry but I won't be able to resume the review until Monday. This week has been rather complicated and I will be offline during the weekend. Not a problem, and thank you for your time. Have a good weekend. :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #6 from Darryl L. Pierce dpie...@redhat.com --- If the above changes are sufficient, could we wrap up the review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070
--- Comment #5 from Darryl L. Pierce dpie...@redhat.com ---
(In reply to comment #4)
Great. The current installation Perl procedure was broken, or to be fair,
the current uninstallation procedure was broken as there is no reliable way
to remove a perl module via ExtUtils::Makemaker.
Will this tarball split be in place for the 0.18 beta? The qpid-perl tarball
isn't available in the 0.18 alpha release
(https://people.apache.org/~jross/qpid-0.18-alpha/).
I don't think so. I have a patch set that's pending review still in JIRA, but
our 0.18 alpha has already been cut. Since this isn't critical path for 0.18,
it'll likely be a part of our 0.20 release.
This is now noted in the specfile.
* contact the perl bindings author so that the patch in the upstream
ticket
QPID-3313 [2] can be applied (see comments in the upstream ticket)
I'll take care of this after the package finishes review. I wouldn't want to
introduce patches to the process at this point.
I've already tried to have it committed for qpid 0.14 but the patch author
(who also made the Qpid perl bindings) forgot to check the license checkbox
:(
Understood. I'll make it a priority post-review. :)
Regards,
jpo
[1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/
[2] - Update example scripts for perl binding.
https://issues.apache.org/jira/browse/QPID-3313
New SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec
New SRPM:
http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.1.src.rpm
Blocker:
* The change from %{perl_vendorarch}/* to %{perl_vendorarch} is a
blocker
as it makes the perl-qpid package own the perl_vendorarch directory.
Derp! Sorry, I didn't realize I'd removed the splat.
Note:
* You no longer need to add a defattr line to the %files section
The %files section can be something like:
--
%files
%doc LICENSE examples/
%{perl_vendorarch}/*
%exclude %dir %{perl_vendorarch}/auto/
--
* any particular reason why the release bump was not 2.fc17?
/jpo
Since we're only modifying the specfile and not the underlying code, I'm only
treating these as point releases on the spec.
Updated SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.2.src.rpm
Thank you. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Jose Pedro Oliveira j...@di.uminho.pt changed: What|Removed |Added Assignee|nob...@fedoraproject.org|j...@di.uminho.pt -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #1 from Jose Pedro Oliveira j...@di.uminho.pt --- Daryl, This is quick first review: Blocker: * The tarball isn't published by the upstream project [1]. A note in the specfile explaining how it is generated should be imperative so that the source files can be verified. (although I believe it's a subset of the main qpid-0.16 tarball). Minor: * Remove the comments in the %build and %install sections: this a binary RPM and not a noarch one (and perl packagers should be able to review either type). * There is a empty %doc line in the %files section Wishlist: * ship the examples as documentation files (%doc examples/) * contact the perl bindings author so that the patch in the upstream ticket QPID-3313 [2] can be applied (see comments in the upstream ticket) Regards, jpo [1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/ [2] - Update example scripts for perl binding. https://issues.apache.org/jira/browse/QPID-3313 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #2 from Jose Pedro Oliveira j...@di.uminho.pt --- This is annoying: * You are not authorized to access bug #450912. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 --- Comment #3 from Darryl L. Pierce dpie...@redhat.com --- (In reply to comment #1) Daryl, This is quick first review: Blocker: * The tarball isn't published by the upstream project [1]. A note in the specfile explaining how it is generated should be imperative so that the source files can be verified. (although I believe it's a subset of the main qpid-0.16 tarball). I'm on the upstream team. We're going to be publishing the Perl sources separately with an upcoming release. Previously the Perl bindings were a part of our monolithic qpid-cpp package but we want to break it out to be its own package. This is now noted in the specfile. Minor: * Remove the comments in the %build and %install sections: this a binary RPM and not a noarch one (and perl packagers should be able to review either type). Done. * There is a empty %doc line in the %files section Done Wishlist: * ship the examples as documentation files (%doc examples/) Done. * contact the perl bindings author so that the patch in the upstream ticket QPID-3313 [2] can be applied (see comments in the upstream ticket) I'll take care of this after the package finishes review. I wouldn't want to introduce patches to the process at this point. Regards, jpo [1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/ [2] - Update example scripts for perl binding. https://issues.apache.org/jira/browse/QPID-3313 New SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec New SRPM: http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070
--- Comment #4 from Jose Pedro Oliveira j...@di.uminho.pt ---
(In reply to comment #3)
(In reply to comment #1)
Daryl,
This is quick first review:
Blocker:
* The tarball isn't published by the upstream project [1].
A note in the specfile explaining how it is generated should be
imperative
so that the source files can be verified.
(although I believe it's a subset of the main qpid-0.16 tarball).
I'm on the upstream team. We're going to be publishing the Perl sources
separately with an upcoming release. Previously the Perl bindings were a
part of our monolithic qpid-cpp package but we want to break it out to be
its own package.
Great. The current installation Perl procedure was broken, or to be fair, the
current uninstallation procedure was broken as there is no reliable way to
remove a perl module via ExtUtils::Makemaker.
Will this tarball split be in place for the 0.18 beta? The qpid-perl tarball
isn't available in the 0.18 alpha release
(https://people.apache.org/~jross/qpid-0.18-alpha/).
This is now noted in the specfile.
* contact the perl bindings author so that the patch in the upstream ticket
QPID-3313 [2] can be applied (see comments in the upstream ticket)
I'll take care of this after the package finishes review. I wouldn't want to
introduce patches to the process at this point.
I've already tried to have it committed for qpid 0.14 but the patch author (who
also made the Qpid perl bindings) forgot to check the license checkbox :(
Regards,
jpo
[1] - https://www.apache.org/dyn/closer.cgi/qpid/0.16/
[2] - Update example scripts for perl binding.
https://issues.apache.org/jira/browse/QPID-3313
New SPEC: http://mcpierce.fedorapeople.org/rpms/perl-qpid.spec
New SRPM:
http://mcpierce.fedorapeople.org/rpms/perl-qpid-0.16-1.fc17.1.src.rpm
Blocker:
* The change from %{perl_vendorarch}/* to %{perl_vendorarch} is a blocker
as it makes the perl-qpid package own the perl_vendorarch directory.
Note:
* You no longer need to add a defattr line to the %files section
The %files section can be something like:
--
%files
%doc LICENSE examples/
%{perl_vendorarch}/*
%exclude %dir %{perl_vendorarch}/auto/
--
* any particular reason why the release bump was not 2.fc17?
/jpo
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 834070] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=834070 Darryl L. Pierce dpie...@redhat.com changed: What|Removed |Added Blocks||450912 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
