[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
https://bugzilla.redhat.com/show_bug.cgi?id=836945 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7q3YamZCQu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
https://bugzilla.redhat.com/show_bug.cgi?id=836945 Fedora Update System changed: What|Removed |Added Fixed In Version|java-xmlbuilder-0.6-1.fc19 |java-xmlbuilder-0.6-1.fc18 --- Comment #27 from Fedora Update System --- java-xmlbuilder-0.6-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2Ml5LNIBGH&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
https://bugzilla.redhat.com/show_bug.cgi?id=836945 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||java-xmlbuilder-0.6-1.fc19 Resolution|--- |ERRATA Last Closed||2013-05-24 16:21:22 --- Comment #26 from Fedora Update System --- java-xmlbuilder-0.6-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mxMz8wbUOY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System --- java-xmlbuilder-0.6-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0UsDx2BjMz&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #24 from Fedora Update System --- java-xmlbuilder-0.6-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/java-xmlbuilder-0.6-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OsvcrXcwCT&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #23 from Fedora Update System --- java-xmlbuilder-0.6-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/java-xmlbuilder-0.6-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ND449ddT8B&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KFrC4DVSUr&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? | Flags||fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3Wlhthz9gg&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #22 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=a7mN7WOhKL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from gil cattaneo --- New Package SCM Request === Package Name: java-xmlbuilder Short Description: XML Builder Java library for creating XML documents Owners: gil Branches: f18 f19 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ydYP1FSj3a&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 Orion Poplawski changed: What|Removed |Added Flags||fedora-review+ --- Comment #20 from Orion Poplawski --- Looks good then. Approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JMTsOHCcUM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #19 from gil cattaneo --- (In reply to comment #18) > - update to 0.6 resolved bundled iharder/base64. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DPI8U9as0G&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 Bug 836945 depends on bug 957544, which changed state. Bug 957544 Summary: Review Request: java-base64 - Java class for encoding and decoding Base64 notation https://bugzilla.redhat.com/show_bug.cgi?id=957544 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zD5CHPxyQP&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 gil cattaneo changed: What|Removed |Added Depends On||957544 --- Comment #18 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/java-xmlbuilder.spec SRPM URL: http://gil.fedorapeople.org/java-xmlbuilder-0.6-1.fc18.src.rpm - update to 0.6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c8tsjlvqhQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #17 from gil cattaneo --- FPC's trac link i broken or the page is currently offline thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TUXhF9avJM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #16 from Orion Poplawski --- https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=v0oC3msl5d&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #15 from gil cattaneo --- (In reply to comment #14) > Then you need to file for a bundling exception. I'm sorry, how? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=17PuGknGds&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #14 from Orion Poplawski --- Then you need to file for a bundling exception. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vW4LXNjsmE&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #13 from gil cattaneo --- (In reply to comment #12) > The blocker for me is bundling iharder/base64. That needs to be packaged > separately. the file is a customization version of iharder/base64... if i create anew package i must patch with the changes done by java-xmlbuilder developer ... and *i do not need* iharder/base64 in a separate new package -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lrU54wTfXO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #12 from Orion Poplawski --- The blocker for me is bundling iharder/base64. That needs to be packaged separately. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZgfYptbcPb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #11 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/java-xmlbuilder.spec SRPM URL: http://gil.fedorapeople.org/java-xmlbuilder-0.4-2.fc18.src.rpm - removed superfluous from Javadoc subpackages Requires: jpackage-utils -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Ydym4eq0ph&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #10 from Stanislav Ochotnicky --- (In reply to comment #7) > > - Javadoc subpackages do not have Requires: jpackage-utils > > Note: jpackage-utils requires are automatically generated by the > > buildsystem > > See: https://fedoraproject.org/wiki/Packaging:Java > J-U is already required Point was that there is no need to because RPM will automatically generate that requires. Wording of that check in f-r has been fixed now -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7e8YZPFQqD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #9 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/java-xmlbuilder.spec SRPM URL: http://gil.fedorapeople.org/java-xmlbuilder-0.4-2.fc18.src.rpm - install upstream license and notice files java-xmlbuilder don't include the license file in the stable branch -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ULp04Tr3lu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #8 from gil cattaneo --- (In reply to comment #5) > (In reply to comment #4) > > - I believe the standard now is to *not* separately download and include a > > license file. But upstream (http://code.google.com/p/java-xmlbuilder/) > > should be asked to include one. > > The thing is if we want to include ASL 2.0 code in Fedora it *has* to have > license included as per point 4.1 of the license[1]. > > [1] http://www.apache.org/licenses/LICENSE-2.0.html#redistribution open this bug http://code.google.com/p/java-xmlbuilder/issues/detail?id=13 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TmrTQf3dbG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #7 from gil cattaneo --- (In reply to comment #6) > Apart from that there's also this from fedora-review (RC) > > Issues: > === > - Maven packages should use new style packaging > Note: If possible update your package to latest guidelines i cant i use F18, for now > See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven > - Packages have proper BuildRequires/Requires on jpackage-utils > Note: Maven packages do not need to (Build)Require jpackage-utils. It is > pulled in by maven-local can remove in the next release ? > See: https://fedoraproject.org/wiki/Packaging:Java > - Javadoc subpackages do not have Requires: jpackage-utils > Note: jpackage-utils requires are automatically generated by the > buildsystem > See: https://fedoraproject.org/wiki/Packaging:Java J-U is already required -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2egIxLNbpU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #6 from Stanislav Ochotnicky --- Apart from that there's also this from fedora-review (RC) Issues: === - Maven packages should use new style packaging Note: If possible update your package to latest guidelines See: https://fedoraproject.org/wiki/Packaging:Java#Apache_Maven - Packages have proper BuildRequires/Requires on jpackage-utils Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local See: https://fedoraproject.org/wiki/Packaging:Java - Javadoc subpackages do not have Requires: jpackage-utils Note: jpackage-utils requires are automatically generated by the buildsystem See: https://fedoraproject.org/wiki/Packaging:Java -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mf9CRY9GKS&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 Stanislav Ochotnicky changed: What|Removed |Added CC||socho...@redhat.com --- Comment #5 from Stanislav Ochotnicky --- (In reply to comment #4) > - I believe the standard now is to *not* separately download and include a > license file. But upstream (http://code.google.com/p/java-xmlbuilder/) > should be asked to include one. The thing is if we want to include ASL 2.0 code in Fedora it *has* to have license included as per point 4.1 of the license[1]. [1] http://www.apache.org/licenses/LICENSE-2.0.html#redistribution -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DvzATUenHv&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #4 from Orion Poplawski --- - Still bundles iharder/base64 - Sorry about the - in the changelog, I guess that was old school - I believe the standard now is to *not* separately download and include a license file. But upstream (http://code.google.com/p/java-xmlbuilder/) should be asked to include one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lqQEqWiagB&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #3 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/java-xmlbuilder.spec SRPM URL: http://gil.fedorapeople.org/java-xmlbuilder-0.4-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FvNDYyfSx4&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=836945 --- Comment #2 from gil cattaneo --- (In reply to comment #1) > Problems - > - Looks like this bundles a copy of net/iharder/base64/Base64.java from > http://iharder.net/base64 > - Add "-" between name and version in %changelog entry never used... really required? > - Is upstream alive? Can you ask them to include a copy of the license? yes ... i think ... (the package contains a single java file... http://prdownloads.sourceforge.net/iharder/Base64-2.3.7.zip), i have some problem for do this now ( problem with my web connection ...) if you have time for this, please can you do this for me? http://sourceforge.net/projects/iharder/?source=navbar under Public Domain thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JI86swxDLC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836945
Orion Poplawski changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||or...@cora.nwra.com
Assignee|nob...@fedoraproject.org|or...@cora.nwra.com
--- Comment #1 from Orion Poplawski ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Problems -
- Looks like this bundles a copy of net/iharder/base64/Base64.java from
http://iharder.net/base64
- Add "-" between name and version in %changelog entry
- Is upstream alive? Can you ask them to include a copy of the license?
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-
xmlbuilder-javadoc
[x]: Package complies to the Packaging Guidelines
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 2 files have unknown license.
Detailed output of licensecheck in /export/home/orion/redhat/java-
xmlbuilder-0.4/review-java-xmlbuilder/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
https://bugzilla.redhat.com/show_bug.cgi?id=836945 gil cattaneo changed: What|Removed |Added Blocks||847109 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 836945] Review Request: java-xmlbuilder - XML Builder Java library for creating XML documents
https://bugzilla.redhat.com/show_bug.cgi?id=836945 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
