[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|NOTABUG |ERRATA --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- CardManager-1-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- CardManager-1-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 gil cattaneo punto...@libero.it changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NOTABUG Last Closed||2012-07-18 11:56:28 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- Package CardManager-1-1.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing CardManager-1-1.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-10694/CardManager-1-1.fc17 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #15 from jiri vanek jva...@redhat.com --- Thank to all participants! Package pushed and built. The post and postun have been removed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- CardManager-1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/CardManager-1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- CardManager-1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/CardManager-1-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 jiri vanek jva...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from jiri vanek jva...@redhat.com --- New Package SCM Request === Package Name: CardManager Short Description: network game for collectible card games Owners: jvanek Branches: f16 f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #9 from gil cattaneo punto...@libero.it --- ops can you remove %post %%postun scripts? CardManager.noarch: E: use-of-home-in-%post CardManager.noarch: E: use-of-home-in-%postun and add to InitialCC: java-sig regards -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #10 from jiri vanek jva...@redhat.com --- 2.f CardManager.noarch: E: use-of-home-in-%postun and %post - This is most discusable issue. I'm using it just for echo so I believe that it can stay in as serving good purpose. However, if you really insist I will remove it. As I told I use it only for echo and this echo is not bad. If you really insists (But not only because rpmlint is complaining :o) I will replace this scriplets with something like %post echo This application is using your your_home/CardManager directory as location with custom collections echo If this directory exists it will be used, otherwise it will be created during first launch %postun echo This application is using your your_home/CardManager directory as location with custom collections echo This directory was not removed during uninstall to not touch your private collections But imho the original scriplets with ~ are little bit better. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #11 from gil cattaneo punto...@libero.it --- no insists than ... but should you set the InitialCC field? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #12 from jiri vanek jva...@redhat.com --- New Package SCM Request === Package Name: CardManager Short Description: network game for collectible card games Owners: jvanek Branches: f16 f17 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 jiri vanek jva...@redhat.com changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #13 from Jason Tibbitts ti...@math.uh.edu --- Scriptlets really shouldn't do any output, and certainly not intentional output. yum is going to flag that output as an error. yum-cron is going to mail it to the admin (where it's almost certainly not useful). There's a short thread at http://lists.fedoraproject.org/pipermail/packaging/2009-March/005797.html. The scriptlet examples also take the care to redirect output to /dev/null. However, this isn't written in the guidelines anywhere. I will file a ticket to get that fixed now. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268
jiri vanek jva...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #4 from jiri vanek jva...@redhat.com ---
hi!
Thank you for very careful review!
most issues have been fixed:
http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager.spec
http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-1-1.fc16.src.rpm
http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-1-1.fc16.noarch.rpm
http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-javadoc-1-1.fc16.noarch.rpm
namely:
cp -r dist/javadoc/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}
FIXED - added asterix
the subpackage javadoc should got the license file and remove the
%%defattr(-,root,root,-) This is OK if
FIXED - both
edit /%{_datadir}/%{name}
FIXED - removed leading slash
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
FIXED - clean removed
[!]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files javadoc section. This is OK if
packaging for EPEL5. Otherwise not needed
FIXED - global defattr removed
Two not fixed:
1) See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
and
Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install
REASON: I must be blind but there is already
%install
rm -rf $RPM_BUILD_ROOT
...
2)[!]: MUST Rpmlint output is silent.
rpmlint CardManager-1-1.fc18.noarch.rpm
CardManager.noarch: W: spelling-error %description -l en_US multiplatform -
multiform, formulation, formulator
CardManager.noarch: W: spelling-error %description -l en_US downloadable -
down loadable, down-loadable, download able
CardManager-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java
docs,
CardManager.noarch: W: no-manual-page-for-binary CardManager
CardManager.noarch: E: use-of-home-in-%post
CardManager.noarch: E: use-of-home-in-%postun
CardManager.noarch: W: uncompressed-zip /usr/share/java/CardManager.jar
Well this rule was added recently and is going to be removed or touched as to
strict. I hope I have good excuse for all issues by rpmlint:
2.a multiplatform - I consider this word as correct
2.b downloadable - likewise
2.c Javadocs - likewise - copy-pasted from guidelines anyway;)
2.d no-manual-page-for-binary - gui application with own gui-help
2.e uncompressed-zip - what I can see in rpm is zip with mor ethen 50% of
compression. Bug in rpmlint?
2.f CardManager.noarch: E: use-of-home-in-%postun and %post - This is most
discusable issue. I'm using it just for echo so I believe that it can stay in
as serving good purpose. However, if you really insist I will remove it.
Thank you for your review again!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268
--- Comment #5 from gil cattaneo punto...@libero.it ---
hi
should remove rm -rf $RPM_BUILD_ROOT
should/must become
%install
#desktop
mkdir -p $RPM_BUILD_ROOT%{_datadir}/pixmaps
thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #6 from jiri vanek jva...@redhat.com --- ah sure. Sorry for misunderstanding. Removed. http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager.spec http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-1-1.fc16.src.rpm http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-1-1.fc16.noarch.rpm http://jvanek.fedorapeople.org/CardManagerReview/round2/CardManager-javadoc-1-1.fc16.noarch.rpm updated. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #7 from gil cattaneo punto...@libero.it --- Looks good now. *** APPROVED *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 gil cattaneo punto...@libero.it changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268
--- Comment #2 from gil cattaneo punto...@libero.it ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean is needed only if supporting EPEL
[ ]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm 4.4
Note: defattr() present in %files javadoc section. This is OK if
packaging for EPEL5. Otherwise not needed
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains a properly installed %{name}.desktop using desktop-
file-install file if it is a GUI application.
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf is only needed if supporting EPEL5
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
[ ]: MUST License file installed when any subpackage combination is installed.
[ ]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[ ]: MUST Package installs properly.
[ ]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint CardManager-1-1.fc18.noarch.rpm
CardManager.noarch: W: spelling-error %description -l en_US multiplatform -
multiform, formulation, formulator
CardManager.noarch: W: spelling-error %description -l en_US downloadable -
down loadable, down-loadable, download able
CardManager.noarch: W: no-manual-page-for-binary CardManager
CardManager.noarch: E: use-of-home-in-%post
CardManager.noarch: E: use-of-home-in-%postun
CardManager.noarch: W: uncompressed-zip /usr/share/java/CardManager.jar
1 packages and 0 specfiles checked; 2 errors, 4 warnings.
rpmlint CardManager-1-1.fc18.src.rpm
CardManager.src: W: spelling-error %description -l en_US multiplatform -
multiform, formulation, formulator
CardManager.src: W: spelling-error %description -l en_US downloadable - down
loadable, down-loadable, download able
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint CardManager-javadoc-1-1.fc18.noarch.rpm
CardManager-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java
docs, Java-docs, Avocados
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/gil/837268/CardManager_sources.zip :
MD5SUM this package : fd917a8408da1526167a3b536ca7f112
MD5SUM upstream package : fd917a8408da1526167a3b536ca7f112
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[ ]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[ ]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[ ]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268
--- Comment #3 from gil cattaneo punto...@libero.it ---
hi
Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install
change
cp -r dist/javadoc $RPM_BUILD_ROOT%{_javadocdir}/%{name}
with
cp -r dist/javadoc/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}
the subpackage javadoc should got the license file and remove the
%%defattr(-,root,root,-) This is OK if
packaging for EPEL5.
edit /%{_datadir}/%{name} in %{_datadir}/%{name}
%files
%{_datadir}/pixmaps/CardManager.png
%{_datadir}/applications/CardManager.desktop
%{_datadir}/%{name}
%attr(755,root,root) %{_bindir}/CardManager
%{_javadir}/*
%doc license.txt
%files javadoc
%{_javadocdir}/%{name}
%doc license.txt
remove %clean section
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 837268] Review Request: CardManager - network game for collectable card games
https://bugzilla.redhat.com/show_bug.cgi?id=837268 --- Comment #1 from jiri vanek jva...@redhat.com --- SPECS/CardManager.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. RPMS/noarch/CardManager-1-1.fc16.noarch.rpm CardManager.noarch: W: spelling-error %description -l en_US multiplatform - multiform, formulation, formulator CardManager.noarch: W: spelling-error %description -l en_US downloadable - down loadable, down-loadable, download able CardManager.noarch: W: no-manual-page-for-binary CardManager CardManager.noarch: E: use-of-home-in-%post CardManager.noarch: E: use-of-home-in-%postun CardManager.noarch: W: class-path-in-manifest /usr/share/java/CardManager.jar 1 packages and 0 specfiles checked; 2 errors, 4 warnings. RPMS/noarch/CardManager-javadoc-1-1.fc16.noarch.rpm CardManager-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs - Java docs, Java-docs, Avocados 1 packages and 0 specfiles checked; 0 errors, 1 warnings. SRPMS/CardManager-1-1.fc16.src.rpm CardManager.src: W: spelling-error %description -l en_US multiplatform - multiform, formulation, formulator CardManager.src: W: spelling-error %description -l en_US downloadable - down loadable, down-loadable, download able 1 packages and 0 specfiles checked; 0 errors, 2 warnings. CardManager.noarch: W: no-manual-page-for-binary CardManager - gui helpCardManager.noarch: E: use-of-home-in-%post and CardManager.noarch: E: use-of-home-in-%postun - just in echo command CardManager.noarch: W: class-path-in-manifest /usr/share/java/CardManager.jar - classpath is empty, and correctly set by jpackage -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
