[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-07-23 16:24:31 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- maven-wagon-ahc-1.2.1-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- maven-wagon-ahc-1.2.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/maven-wagon-ahc-1.2.1-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- maven-wagon-ahc-1.2.1-1.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mizde...@redhat.com Assignee|nob...@fedoraproject.org|mizde...@redhat.com Flags||fedora-review? --- Comment #2 from Mikolaj Izdebski mizde...@redhat.com --- I am taking this review. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 --- Comment #3 from Gerard Ryan ger...@ryan.lt --- Spec URL: http://galileo.fedorapeople.org/maven-wagon-ahc/1.2.1-2/maven-wagon-ahc.spec SRPM URL: http://galileo.fedorapeople.org/maven-wagon-ahc/1.2.1-2/maven-wagon-ahc-1.2.1-1.fc17.src.rpm Apache 2.0 license text added to srpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117
Mikolaj Izdebski mizde...@redhat.com changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #4 from Mikolaj Izdebski mizde...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint maven-wagon-ahc-javadoc-1.2.1-1.fc18.noarch.rpm
maven-wagon-ahc-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -
Java docs, Java-docs, Avocados
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint maven-wagon-ahc-1.2.1-1.fc18.src.rpm
maven-wagon-ahc.src: W: spelling-error %description -l en_US async - sync, a
sync
maven-wagon-ahc.src: W: spelling-error %description -l en_US http - HTTP
maven-wagon-ahc.src: W: invalid-url Source0: maven-wagon-ahc-1.2.1.tar.xz
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
rpmlint maven-wagon-ahc-1.2.1-1.fc18.noarch.rpm
maven-wagon-ahc.noarch: W: spelling-error %description -l en_US async - sync,
a sync
maven-wagon-ahc.noarch: W: spelling-error %description -l en_US http - HTTP
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
These warnings can be ignored.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[-]: SHOULD Package does not include license text
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Gerard Ryan ger...@ryan.lt --- New Package SCM Request === Package Name: maven-wagon-ahc Short Description: A wagon provider for HTTP transfers Owners: galileo Branches: f17 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Summary|Review Request: |Review Request: |maven-wagon-ahc - |maven-wagon-ahc - A wagon |http://galileo.fedorapeople |provider for HTTP transfers |.org/maven-wagon-ahc/1.2.1- | |1/maven-wagon-ahc-1.2.1-1.f | |c17.src.rpm | --- Comment #1 from Gerard Ryan ger...@ryan.lt --- Spec URL: http://galileo.fedorapeople.org/maven-wagon-ahc/1.2.1-1/maven-wagon-ahc.spec SRPM URL: http://galileo.fedorapeople.org/maven-wagon-ahc/1.2.1-1/maven-wagon-ahc-1.2.1-1.fc17.src.rpm Description: A wagon provider for HTTP transfers based on the async-http-client. Fedora Account System Username: galileo -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839117] Review Request: maven-wagon-ahc - A wagon provider for HTTP transfers
https://bugzilla.redhat.com/show_bug.cgi?id=839117 Gerard Ryan ger...@ryan.lt changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
