[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||crrcsim-addon-models-0.2.0- ||2.fc18 Resolution|--- |ERRATA Last Closed||2013-07-22 21:10:46 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- crrcsim-addon-models-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XHv4qIzoMca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|crrcsim-addon-models-0.2.0- |crrcsim-addon-models-0.2.0- |2.fc18 |2.fc19 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- crrcsim-addon-models-0.2.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=loHndjifQ5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- crrcsim-addon-models-0.2.0-2.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X4LQ7mTXFca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=INmtipRPkaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- crrcsim-addon-models-0.2.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/crrcsim-addon-models-0.2.0-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=u8l1TkcoVNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- crrcsim-addon-models-0.2.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/crrcsim-addon-models-0.2.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TH4Y00WfAqa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740
Miroslav Lichvar mlich...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|mlich...@redhat.com
Flags||fedora-review+
--- Comment #14 from Miroslav Lichvar mlich...@redhat.com ---
The package looks good. Approved.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
The licensing was clarified by email, which is included in %doc.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
It includes the CC-BY license.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
= EXTRA items =
Generic:
[x]:
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Damian Wrobel dwro...@ertelnet.rybnik.pl changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Miroslav, thank you for the review. New Package SCM Request === Package Name: crrcsim-addon-models Short Description: Addon models for Crrcsim Owners: dwrobel Branches: f18 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=riwATRR5NFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #16 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iC9q4d5QDia=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ipyNFDfZC9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #13 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Please find updated spec SRPM files: Spec URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/crrcsim-addon-models.spec SRPM URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/crrcsim-addon-models-0.2.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sMDAn8y7Kza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #10 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Created attachment 765805 -- https://bugzilla.redhat.com/attachment.cgi?id=765805action=edit license confirmation (from Jan Reucker) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c2Q6P3O9FJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Damian Wrobel dwro...@ertelnet.rybnik.pl changed: What|Removed |Added Attachment #763494|0 |1 is obsolete|| --- Comment #11 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Created attachment 765806 -- https://bugzilla.redhat.com/attachment.cgi?id=765806action=edit license confirmation (from Arthur Frenslich) Please confirm if it would be enough to attach those emails to the SRPM package + copy of the CC-BY license file? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=XW6hAxsvNga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Blocks|182235 (FE-Legal) | --- Comment #12 from Tom spot Callaway tcall...@redhat.com --- Yes, add them as SOURCE files, then make sure they're included in %doc. Lifting FE-Legal. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yMElTaUwTJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Damian Wrobel dwro...@ertelnet.rybnik.pl changed: What|Removed |Added Attachment #700667|0 |1 is obsolete|| --- Comment #6 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Created attachment 763494 -- https://bugzilla.redhat.com/attachment.cgi?id=763494action=edit mail regarding license Please find attached an answer from the author. Is it helpful? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tw0AuaudzFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #7 from Tom spot Callaway tcall...@redhat.com --- No, since he is not the creator of those files, he can't just make them free. We need to know who owns the copyright on each of those files and then, we need to ask each of those people what the license terms are. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Nmq1kMxSBNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #8 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- No, since he is not the creator of those files Locking only inside the files we're finally installing (as the rest of them are already installed by the crrcsim package) gives the information about two authors: Jan Reucker and Arthur Frenslich. I've emailed to both of them. Jan redirected me to Arthur which didn't raise any objections. $ grep author $(rpm -ql crrcsim-addon-models) | grep -v CRRCSim | grep -v Jan Reucker | grep -v Arthur Frenslich Returns empty list. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GBjW8azne0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #9 from Tom spot Callaway tcall...@redhat.com --- Okay. We just need these two people to confirm their licenses. I might suggest CC-BY if they have no preference. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i3UWpiZhWZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #5 from Tom spot Callaway tcall...@redhat.com --- Sorry for the delay in response. Yes, we would need the list of authors and then confirm the individual licensing with each of them. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x5m0TW49cQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Blocks||182235 (FE-Legal) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LjSGvmTrWva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #3 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- Created attachment 700667 -- https://bugzilla.redhat.com/attachment.cgi?id=700667action=edit mail regarding license I got a reply from author of the zip file, but I'm not quite sure whether it's satisfactory. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oHxsNGQK7La=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839740 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #4 from Miroslav Lichvar mlich...@redhat.com --- Hm, I think we would need to get a list of all authors whose work is included in that zip and get a statement from all of them. Tom, can you please confirm that? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jRsa2Boqo3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839740 Bug 839740 depends on bug 832524, which changed state. Bug 832524 Summary: Review Request: crrcsim - Model-Airplane Flight Simulation Program https://bugzilla.redhat.com/show_bug.cgi?id=832524 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OECOdrDXZFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839740 Miroslav Lichvar mlich...@redhat.com changed: What|Removed |Added CC||mlich...@redhat.com --- Comment #1 from Miroslav Lichvar mlich...@redhat.com --- I did just a quick check. The tarball doesn't seem to contain or mention the license. Can you please ask upstream to fix this or to confirm the licensing and include the mail in the package? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=d8KhwWEB67a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=839740 --- Comment #2 from Damian Wrobel dwro...@ertelnet.rybnik.pl --- (In reply to comment #1) I've asked upstream about that: https://sourceforge.net/tracker/?func=detailaid=3602436group_id=8823atid=358823 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TOWXGtVNjka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839740] Review Request: crrcsim-addon-models - Addon models for Crrcsim
https://bugzilla.redhat.com/show_bug.cgi?id=839740 Damian Wrobel dwro...@ertelnet.rybnik.pl changed: What|Removed |Added Depends On||832524 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
