[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Dan Mashal changed: What|Removed |Added Flags||fedora-cvs? --- Comment #26 from Dan Mashal --- New Package SCM Request === Package Name: mate-common Short Description: binaries for building all MATE desktop sub components Owners: vicodan rdieter Branches: f16 f17 InitialCC: vicodan rdieter -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #25 from Dan Mashal --- My mistake, misunderstood. I'll remove that. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Rex Dieter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #24 from Rex Dieter --- OK, looks good, APPROVED. curious why you added Requires: gnome-common though. ?? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Dan Mashal changed: What|Removed |Added QA Contact|extras...@fedoraproject.org |dan.mas...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #23 from Dan Mashal --- Updated license. It is GPLv3+. I will do the license review on a package by package basis. Most everything is GPLv2+, GPLv3(+), lGPL as per perberos. Added gnome-common to requires field. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-common.spec SRPM: http://vicodan.fedorapeople.org/materpms/srpms/mate-common-1.4.0-5.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #22 from Rex Dieter --- So, I just looked closer at the gnome-common analog, http://pkgs.fedoraproject.org/gitweb/?p=gnome-common.git;a=blob;f=gnome-common.spec and see some things we could... borrow here. :) stuff like: runtime requires better summary/description so, 1. MUST: add runtime deps Requires: automake autoconf libtool gettext pkgconfig 2. SHOULD: improve pkg summary/description as suggested 3. MUST: Licensing: so, .spec says GPLv2+, and none of the included files mention licensing, except for the embedded COPYING file, which is GPLv3. can you verify with upstream (if you haven't already), their intent here? (I'm assuming some GPLv2+ (with some/all libs LGPLv2+) combo like pre-forked gnome2...) naming: ok macros: ok scriptlets: n/a sources: ok $ md5sum *.xz bc49ff6897ef2303c6464a3ca46aaf35 mate-common-1.4.0.tar.xz -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Rex Dieter changed: What|Removed |Added Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Dan Mashal changed: What|Removed |Added Blocks|182235 (FE-Legal) | --- Comment #21 from Dan Mashal --- Hi Rex, Per our conversation on IRC I have updated the SPEC and SRPM. Please review it. Once mate-common gets approved I can make mate-common a requirement for every other spec. We will also track any legality issues in the main tracker bug. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-common.spec SRPM: http://vicodan.fedorapeople.org/materpms/srpms/mate-common-1.4.0-4.fc17.src.rpm Description: base files for building and installing MATE Desktop -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #20 from Dan Mashal --- one more try for srpm link: http://vicodan.fedorapeople.org/materpms/srpms/mate-common-1.4.0-3.src.rpm Sorry. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #19 from Dan Mashal --- updated urls; spec: http://vicodan.fedorapeople.org/matespec/mate-common.spec srpm: http://vicodan.fedorapeople.org/materpms/srpms/mate/mate-common-1.4.0-3.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #18 from Dan Mashal --- Thanks spot. Update spec and srpm here: spec: http://vicodan.fedorapeople.org/matespace/mate-common.spec srpm: http://vicodan.fedorapeople.org/materpms/srpms/mate/mate-common-1.4.0-3.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Tom "spot" Callaway changed: What|Removed |Added Assignee|tcall...@redhat.com |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #17 from Tom "spot" Callaway --- We probably cannot distribute "nyan cat" in source format either, without permission from the copyright holder. I have not looked at the source code at all, however, if only the image of "pop tart cat" is being used here, you may wish you ask the copyright holder (prguitarman ) for permission. The alternative would be to simply remove the "nyan cat" content from the source tarball entirely and make a "clean" tarball. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #16 from Dan Mashal --- Nelson, Thanks for the Nyan cat comment. Regarding those packages, they are out of date and heavily patched. I have been working with Nice&Gently. He is on vacation right now. Thanks, Dan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #15 from Nelson Marques --- Dan, I've found that also another person has a few very neat packages for Fedora; You can use them to improve your specs if you want or even contact the original author, tell him about your effort and maybe you guys can do this together. Take a look at this: https://github.com/mate-desktop/fedora-packages -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #14 from Nelson Marques --- Aditional Information: You can disable 'nyan cat' during build time if you want, you need to add this option to %configure (which you are neglecting currently): %build %configure --disable-nyancat And that should get rid of nyancat. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #13 from Nelson Marques --- Hi all, I've looked around and it seems that nyan cat is indeed copyrighted and there's currently 3 copyright holders: 1) 1 copyright holder for the animated gif; 2) 1 copyright holder for the music; 3) 1 copyright holder for the video; I've taken the liberty of opening a bug report upstream requesting for this issue to be cleared out; I will talk to Stefano and Perberos about this once I grab them online. Upstream: https://github.com/perberos/Mate-Desktop-Environment/issues/104 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #12 from Dan Mashal --- Thank you Rex and Mario. Rex, I will work with your suggestions this weekend. Mario, thanks for creating the tracker. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Mario Blättermann changed: What|Removed |Added Blocks||840149 Depends On|840149 | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED Blocks|840149 | Depends On||840149 --- Comment #11 from Mario Blättermann --- (In reply to comment #7) > Since MATE is a big collection of packages and would require quite a few > reviews, is it worth making a tracker bug for it that would help track the > reviews for its components? Done. Tracker is bug #840149. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Mario Blättermann changed: What|Removed |Added Blocks||840149 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Dan Mashal changed: What|Removed |Added Blocks||182235 (FE-Legal) Assignee|nob...@fedoraproject.org|tcall...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #10 from Dan Mashal --- Hi, All RPMs, SRPMs and SPEC files have been built and are uploaded here: http://vicodan.fedorapeople.org/ Please review. This will need legal review as well. It was brought to my attention "nyan cat" is copyrighted. Thanks, Dan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Nelson Marques changed: What|Removed |Added CC||nmo.marq...@gmail.com --- Comment #9 from Nelson Marques --- Anyone against that I help with this review ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #8 from Rex Dieter --- so, here's some suggested fixes: http://rdieter.fedorapeople.org/rpms/mate/ %changelog * Fri Jul 13 2012 Rex Dieter 1.4.0-2 - omit Group: tag - fix URL, Source0 - use %%configure macro - BuildArch: noarch the stuff about urls, and %configure macro usage you ought to adopt in your other mate-related pkgs too. and scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4238369 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Ankur Sinha (FranciscoD) changed: What|Removed |Added CC||sanjay.an...@gmail.com --- Comment #7 from Ankur Sinha (FranciscoD) --- (In reply to comment #5) > mate-common is the first basic component of mate so all that's required is > python auto make and gcc really. I can do fresh reinstall of fedora to > double check but I just did that. As for configure mate uses autogen.sh and > does not come with a configure script. Usr directory noted. Dan, You can just use mock or fire scratch builds at koji now that you're a packager. They use clean build environments and help in catching build requires. http://fedoraproject.org/wiki/Using_Mock_to_test_package_builds Since MATE is a big collection of packages and would require quite a few reviews, is it worth making a tracker bug for it that would help track the reviews for its components? I'll help with the reviewing when I find free cycles. Thanks, Ankur -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #6 from Dan Mashal --- All 21 RPMs are built. Will upload to fedora people and polish spec files for you within 24 hours sir. Thanks for your help. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #5 from Dan Mashal --- mate-common is the first basic component of mate so all that's required is python auto make and gcc really. I can do fresh reinstall of fedora to double check but I just did that. As for configure mate uses autogen.sh and does not come with a configure script. Usr directory noted. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #4 from Rex Dieter --- initial commments: no need to BuildRequires: gcc otherwise, the BuildRequires: are quite sparse, really, nothing? and, using a /usr/local prefix here is (probably) not acceptable, and try to use the default /usr prefix and %configure macro -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 --- Comment #3 from Dan Mashal --- Thank you Rex. Care to do the review? ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 839851] (MATE-desktop) Review Request: mate-common -- mate common files
https://bugzilla.redhat.com/show_bug.cgi?id=839851 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks|177841 (FE-NEEDSPONSOR) | Summary|(MATE-desktop) Review |(MATE-desktop) Review |Request: MATE desktop |Request: mate-common -- ||mate common files --- Comment #2 from Rex Dieter --- I believe you're already sponsored... :) removing FE-NEEDSPONSOR, and adjusting summary to match pkg %name and %summary -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
