[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #15 from Jerry James loganje...@gmail.com --- (In reply to comment #14) I would vote for renaming to surf-geometry, but not patching the package itself neither Singular, that is, keep the Conflicts with the current surf package. You will have to get the Fedora Packaging Committee's approval to keep the Conflicts. See https://fedoraproject.org/wiki/Packaging:Conflicts. I suspect they will tell you to rename the binary instead, but you are welcome to try. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #14 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- I think surf-geometry should be good enough. About patching, it should require significant patching to the package itself because surf is hardcoded everywhere in build environment, and almost all, if not all source files have this before the standard GPL text: * surf - visualizing algebraic curves and algebraic surfaces * Copyright (C) 1996-1997 Friedrich-Alexander-Universitaet * Erlangen-Nuernberg * 1997-2000 Johannes Gutenberg-Universitaet Mainz * Authors: Stephan Endrass, Hans Huelf, Ruediger Oertel, *Kai Schneider, Ralf Schmitt, Johannes Beigel [...] ./Makefile.am:bin_PROGRAMS = surf ./Makefile.am:EXTRA_DIST = background.pic Makefile.global aclocal.m4 surf.1 sur.xpm ./Makefile.am:man_MANS = surf.1 ./Makefile.am:pkgdata_DATA = surf.xpm ./Makefile.am:surf: $(LOCAL_OBJECTS) $(GTKGUI_OBJ) ./Makefile.am: $(CXX) $(LOCAL_OBJECTS) $(GTKGUI_OBJ) -o surf $(LDFLAGS) -lXmu -lXext -lXt @X_PRE_LIBS@ @X_LIBS@ -lX11 @X_EXTRA_LIBS@ $(LIBS) -lfl @GTK_LIBS@ -lcups [...] ./gtkgui/showAbout.cc: pixmap = gdk_pixmap_create_from_xpm (window-window, mask, style-bg[GTK_STATE_NORMAL], DATADIR /surf/surf.xpm); [...] I would vote for renaming to surf-geometry, but not patching the package itself neither Singular, that is, keep the Conflicts with the current surf package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #13 from Jerry James loganje...@gmail.com --- (In reply to comment #12) Changing package name should be trivial, but changing binary name should require patching Singular. Nothing else, at least in Fedora, should use this package. Well ... maybe. I think the concern in comment 3, which I share, is that while there are no other users of surf in Fedora *right now*, we can't be sure there won't be any more in the future. So tying surf to Singular feels wrong. I think the package should have a more general name, as well as the binary. I'm sorry about the necessity of patching Singular to make it use the right binary name, but that does appear necessary at this point. What do you think of the name surf-geometry, for both the package and the binary? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #11 from Jerry James loganje...@gmail.com --- That is a misleading message! Okay, so it looks like the main issue is the naming of the package and the binary. Do you have any thoughts on that? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244
--- Comment #12 from pcpa paulo.cesar.pereira.de.andr...@gmail.com ---
I think it is just the style used to check the tiff
version in ancient systems. Usually config.log has
several other test error results, but those are more
common.
Changing package name should be trivial, but changing
binary name should require patching Singular. Nothing
else, at least in Fedora, should use this package.
Quick and dirt strings check:
$ egrep -r '\surf\' /usr/lib64/Singular/
/usr/lib64/Singular/LIB/surfex.lib:This library uses the program surf
/usr/lib64/Singular/LIB/surfex.lib: This library requires the program surfex,
surf and java to be installed.
/usr/lib64/Singular/LIB/surfex.lib: surfex is a front-end for surf which aims
to be easier to use than
/usr/lib64/Singular/LIB/surfex.lib:LIB surf.lib;
/usr/lib64/Singular/LIB/surfex.lib:string
l=surf+string(system(pid))+.sux;
/usr/lib64/Singular/LIB/surfex.lib:// procedures used to produce the surf-code:
/usr/lib64/Singular/LIB/surfex.lib:RETURN: a string, that one can use with the
external program surf
/usr/lib64/Singular/LIB/resgraph.lib:NOTE: This library uses the external
programs surf, graphviz and xv.
/usr/lib64/Singular/LIB/resgraph.lib:finalCharts(L,...) pictures of final
charts of surface (uses surf)
/usr/lib64/Singular/LIB/resgraph.lib:CREATE: - new windows in which
surf-images of the final charts are presented
/usr/lib64/Singular/LIB/resgraph.lib:@* external programs 'surf' and 'xv'
[pcpa@localhost rpmbuild]$ egrep -rn '\surf\' /usr/lib64/Singular/
/usr/lib64/Singular/LIB/surfex.lib:8:This library uses the program surf
/usr/lib64/Singular/LIB/surfex.lib:13: This library requires the program
surfex, surf and java to be installed.
/usr/lib64/Singular/LIB/surfex.lib:17: surfex is a front-end for surf which
aims to be easier to use than
/usr/lib64/Singular/LIB/surfex.lib:37:LIB surf.lib;
/usr/lib64/Singular/LIB/surfex.lib:506:string
l=surf+string(system(pid))+.sux;
/usr/lib64/Singular/LIB/surfex.lib:547:// procedures used to produce the
surf-code:
/usr/lib64/Singular/LIB/surfex.lib:946:RETURN: a string, that one can use with
the external program surf
/usr/lib64/Singular/LIB/resgraph.lib:9:NOTE: This library uses the external
programs surf, graphviz and xv.
/usr/lib64/Singular/LIB/resgraph.lib:15:finalCharts(L,...) pictures of final
charts of surface (uses surf)
/usr/lib64/Singular/LIB/resgraph.lib:309:CREATE: - new windows in which
surf-images of the final charts are presented
/usr/lib64/Singular/LIB/resgraph.lib:312:@* external programs 'surf' and
'xv' (X11/Xorg package) need to be
/usr/lib64/Singular/LIB/resgraph.lib:413:// Go through all final charts and
write a separate surf input file for each
/usr/lib64/Singular/LIB/resgraph.lib:417: fname=fnamebase +
string(endCharts[i]) + .surf;
/usr/lib64/Singular/LIB/resgraph.lib:420://--- define surf's root finding
algorithm
/usr/lib64/Singular/LIB/resgraph.lib:516://--- 1) surf can only handle real
numbers == we ignore the other curves
/usr/lib64/Singular/LIB/resgraph.lib:576: j=system(sh, surf -n +
fnamebase +string(endCharts[i]) + .surf);
/usr/lib64/Singular/LIB/all.lib:94:LIB surf.lib;
/usr/lib64/Singular/LIB/COPYING:180:surf.libHans Schoenemann
han...@mathematik.uni-kl.de
/usr/lib64/Singular/LIB/surf.lib:2:version=$Id: surf.lib 14583 2012-02-13
15:00:05Z motsak $;
/usr/lib64/Singular/LIB/surf.lib:5:LIBRARY: surf.libProcedures for Graphics
with Surf
/usr/lib64/Singular/LIB/surf.lib:10: Using this library requires the program
@code{surf} to be installed.
/usr/lib64/Singular/LIB/surf.lib:11: You can download @code{surf} either from
/usr/lib64/Singular/LIB/surf.lib:12:
@uref{http://sourceforge.net/projects/sur}
/usr/lib64/Singular/LIB/surf.lib:67:NOTE: requires the external program `surf`
to be installed,
/usr/lib64/Singular/LIB/surf.lib:72: string extra_surf_opts= -x --auto-resize
; // remove this line for surf 0.9
/usr/lib64/Singular/LIB/surf.lib:73: string l = /tmp/surf +
string(system(pid));
/usr/lib64/Singular/LIB/surf.lib:156: surf_call = surf_call + /dev/null
21 ) sleep 5 (surf;
/usr/lib64/Singular/LIB/surf.lib:163: Press q to exit from `surf`.;
/usr/lib64/Singular/LIB/surf.lib:169:err_mes = calling `surf` failed
+ newline
/usr/lib64/Singular/LIB/surf.lib:182:surf_call = surf ;
/usr/lib64/Singular/LIB/surf.lib:195:Press q to exit from `surf`.;
/usr/lib64/Singular/LIB/surf.lib:199: err_mes = calling `surf` failed +
newline
/usr/lib64/Singular/info/singular.hlp:153:surf (used by surf.lib, *note
surf_lib::)
/usr/lib64/Singular/info/singular.hlp:155: `http://surf.sf.net'
/usr/lib64/Singular/info/singular.hlp:157:surfer (used by surf.lib, *note
surf_lib::)
/usr/lib64/Singular/info/singular.hlp:29453:generated automatically by using
external programs `surf' and `dot'
/usr/lib64/Singular/info/singular.hlp:43122: This library uses the external
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #10 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #8) I noticed that the configure script reports that it cannot find tiffio.h, even though that file is in libtiff-devel. Do you know what's going on there? Actually, it only checks for tiff34/tiffio.h and if found, it will link to -ltiff34, otherwise, it will include tiffio.h and link to -ltiff. The what link to is defined in configure, and the source that uses it is surf-1.0.6/image-formats/tiffprint.cc: #ifdef TIFF_HEADER_34 #include tiff34/tiffio.h #else #include tiffio.h #endif So, the message in config.log is a bit misleading, but is the expected result. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 Jerry James loganje...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|loganje...@gmail.com Flags||fedora-review? --- Comment #8 from Jerry James loganje...@gmail.com --- Since I made a hash of the original review (sorry, Mario!), the least I can do is see this one through. Things look pretty good in general. I understand that upstream is at least mostly dead, but Jussi's point in comment 3 is well taken. Shouldn't this package have a more general name? (That's why I called my version surf-geometry.) According to http://sagemath.org/packages/experimental/, Sage is using surf version 1.1! Where did that version come from? Do you know? The conflict with the existing surf package can cause problems. Can we rename the binary in this package instead so they don't conflict? Again, I realize that this makes us nonstandard and that we can't talk to upstream about it because upstream mostly isn't there anymore, but that seems to be a better path to me. I noticed that the configure script reports that it cannot find tiffio.h, even though that file is in libtiff-devel. Do you know what's going on there? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #9 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #8) According to http://sagemath.org/packages/experimental/, Sage is using surf version 1.1! Where did that version come from? Do you know? Looking at the spkg contents: $ cat surf-1.1/get_from_cvs echo Enter a blank password cvs -d:pserver:anonym...@cvs.sourceforge.net:/cvsroot/surf login cvs -z3 -d:pserver:anonym...@cvs.sourceforge.net:/cvsroot/surf co -P surf But it looks seriously outdated: $ cat surf-1.1/SAGE.txt This is the 2006-02-12 CVS version of surf 1.1.0, obtained using cvs -d:pserver:anonym...@cvs.sourceforge.net:/cvsroot/surf login cvs -z3 -d:pserver:anonym...@cvs.sourceforge.net:/cvsroot/surf co -P surf I'm using the cvs version since I couldn't get the download version from 2003 to compile (it's just too out of date). I then ran autogen.sh to create the configure script. -- I had to change the source code in two files to get surf to compile with GCC 4.0.2 on my system: * Deleted IO:: in three places in surf/misc/IO.cc lines 207, 218, and 228 * Also in misc/IO.cc, changed line 121 to #ifdef XHAVE_LIBREADLINE so that chunk of code that uses readline isn't used. (It seems to be out of date. Since we're only using surf from singular, not having readline somewhere shouldn't be a big problem.) PACKAGE MAINTAINER: William Stein I actually did never check on actual upstream sagemath binaries. Maybe the singular examples using surf are not working in recent sagemath; I know it works in my Mandriva and current work in progress Fedora sagemath rpm package, using the package proposed here. Yes, BTW the sagemath version looks quite bogus... The conflict with the existing surf package can cause problems. Can we rename the binary in this package instead so they don't conflict? Again, I realize that this makes us nonstandard and that we can't talk to upstream about it because upstream mostly isn't there anymore, but that seems to be a better path to me. Renaming the binary should be trivial, I was not much happy with needing to patch Singular scripts to match the new name, but should also not be a big deal. But then, the surf package, for the single webkit window appears to be quite outdated. I noticed that the configure script reports that it cannot find tiffio.h, even though that file is in libtiff-devel. Do you know what's going on there? Looks like something bogus, and should be corrected, (or just ignore tiff support :-) dnl check for tiff library and header file (FreeBSD 3.0 has tiff34.so dnl instead of tiff.so and the header files are in /usr/local/lib/tiff34): AC_CHECK_LIB(tiff, main,, AC_CHECK_LIB(tiff34, main,, AC_MSG_ERROR([Sorry: can't find libtiff]))) AC_CHECK_HEADER(tiffio.h,, [AC_CHECK_HEADER(tiff34/tiffio.h,AC_DEFINE(TIFF_HEADER_34))], [AC_MSG_ERROR([Sorry: cannot find header file tiffio.h])] ) Thanks for spotting it. I will check if autoreconf does work, otherwise, could patch the configure script instead. Actually, the surfex java interface in Singular-surfex should be good for most if not all uses, just that the surf binary and the associated sagemath tutorial examples expect to use Singular's surf.lib that uses the surf binary. As noted in #c2 but link here for easier access, this is how it looks like in the sagemath tutorial http://fedorapeople.org/~pcpa/rawhide-sage-notebook4.png -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC||loganje...@gmail.com --- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com --- *** Bug 697680 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244
Jussi Lehtola jussi.leht...@iki.fi changed:
What|Removed |Added
CC||jussi.leht...@iki.fi
--- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi ---
%{?_dist} is wrong, it should read %{?dist}.
**
%dir %{_datadir}/surf
%{_datadir}/surf/surf.xpm
Why do things so complex? This is the same as
%{_datadir}/surf/
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #3 from Jussi Lehtola jussi.leht...@iki.fi --- I think that you can't assume that only Singular uses the application, since it looks like a rather general use application (it has a GUI after all). Please contact upstream, and ask them to come up with a less general name for the application. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244
--- Comment #4 from pcpa paulo.cesar.pereira.de.andr...@gmail.com ---
(In reply to comment #2)
%{?_dist} is wrong, it should read %{?dist}.
**
Thanks. I messed something when finishing the package and uploading,
as I had it correct in my computer:
$ rpm -q Singular-surf
Singular-surf-1.0.6-1.x86_64
%dir %{_datadir}/surf
%{_datadir}/surf/surf.xpm
Why do things so complex? This is the same as
%{_datadir}/surf/
Thanks. For some reason I made this mistake when packaging version
1.0.5 in Mandriva some years ago.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #5 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- (In reply to comment #3) I think that you can't assume that only Singular uses the application, since it looks like a rather general use application (it has a GUI after all). Yes. I did choose it because it actually gets a lot of google hits. Please contact upstream, and ask them to come up with a less general name for the application. I can open a bug report, but I am afraid chances are very small of upstream changing the name, but as I said in the initial comment, I can patch Singular to use another name. I do not know why the surf package has not been rebuilt for some time also: $ repoquery -i surf Name: surf Version : 0.4.1 Release : 3.fc15 Architecture: x86_64 Size: 31272 Packager: Fedora Project Group : Applications/Internet URL : http://surf.suckless.org/ Repository : rawhide Summary : Simple web browser Source : surf-0.4.1-3.fc15.src.rpm Description : surf is a simple web browser based on WebKit/GTK+. but git log shows release was bumped for f17 mass rebuild. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #6 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- Contacted upstream about name issue https://sourceforge.net/tracker/?func=detailaid=3545933group_id=3275atid=103275 Correction to packaging problems: Spec URL: http://fedorapeople.org/~pcpa/Singular-surf.spec SRPM URL: http://fedorapeople.org/~pcpa/Singular-surf-1.0.6-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: Singular-surf - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #1 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- This package is based on the Mandriva surf package http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/surf/ it is required for a functional sagemath tutorial, an example screenshot http://fedorapeople.org/~pcpa/rawhide-sage-notebook4.png The package was named Singular-surf because only Singular should use it, it is the most common alternate name I could find, and there is already a surf package in fedora, that the new package explicitly conflicts to, but if mandatory I can work on patching Singular to want something else, and the package rename installed files. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
