[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840244 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yUV7w4ljcMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- surf-geometry-1.0.6-5.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IogmUvTdrYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #27 from Fedora Update System upda...@fedoraproject.org --- surf-geometry-1.0.6-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/surf-geometry-1.0.6-5.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HD1vyx59rIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840244 Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #24 from Paulo Andrade paulo.cesar.pereira.de.andr...@gmail.com --- Package Change Request == Package Name: surf-geometry New Branches: f18 Owners: pcpa InitialCC: pcpa Required to simplify a possible sagemath update package by having f19 dependencies built in f18. This package was approved shortly after the f18 branch. It should also simplify the Singular package, that would then not need a spec for f18 and another for f19+. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qdflr1e3aya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #25 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=G0QBqOrutba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- surf-geometry-1.0.6-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/surf-geometry-1.0.6-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EXUB80IptJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244
--- Comment #20 from pcpa paulo.cesar.pereira.de.andr...@gmail.com ---
(In reply to comment #19)
You've still got one instance of %{buildroot} in %install, on the mkdir
line. Just fix that before you import the package into git. This package
is APPROVED.
Ops, sorry about another instance of %{buildroot}, I adapted it
from 4ti2.spec and for some reason 'got blind when looking before
my adaptations to the sed command. Will correct it before import.
Thanks for the review!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 pcpa paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- New Package SCM Request === Package Name: surf-geometry Short Description: Tool to visualize some real algebraic geometry Owners: pcpa Branches: InitialCC: pcpa -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #22 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 pcpa paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2012-09-02 21:22:53 --- Comment #23 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- The surf-geometry package has been built for rawhide. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244
Jerry James loganje...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #19 from Jerry James loganje...@gmail.com ---
You've still got one instance of %{buildroot} in %install, on the mkdir line.
Just fix that before you import the package into git. This package is
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 --- Comment #18 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- May thanks for the review! New package addressing the issues: Spec URL: http://fedorapeople.org/~pcpa/surf-geometry.spec SRPM URL: http://fedorapeople.org/~pcpa/surf-geometry-1.0.6-4.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244
--- Comment #17 from Jerry James loganje...@gmail.com ---
Sorry for the delay, Paulo. There are just a few things to fix:
(1) https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net says
that the source URL ought to look like this:
Source0:http://downloads.sourceforge.net/surf/surf-%{version}.tar.gz
(2) Use either %{buildroot} or $RPM_BUILD_ROOT, not both.
(3) Some source files have executable bits set. See below.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) (with incorrect FSF address), GPL (with incorrect
FSF address) For detailed output of licensecheck see file:
/home/jamesjer/840244-surf-geometry/licensecheck.txt
[!]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL5 is required
[x]: SHOULD If the source package does not include license text(s) as
[Bug 840244] Review Request: surf-geometry - Tool to visualize some real algebraic geometry
https://bugzilla.redhat.com/show_bug.cgi?id=840244 pcpa paulo.cesar.pereira.de.andr...@gmail.com changed: What|Removed |Added Summary|Review Request: |Review Request: |Singular-surf - Tool to |surf-geometry - Tool to |visualize some real |visualize some real |algebraic geometry |algebraic geometry --- Comment #16 from pcpa paulo.cesar.pereira.de.andr...@gmail.com --- I changed the package to use environment-modules. I should add something like: module load surf-geometry-`rpm -E %_arch` to the sagemath and singular scripts (for sagemath only required in sage -shell). New package: Spec URL: http://fedorapeople.org/~pcpa/surf-geometry.spec SRPM URL: http://fedorapeople.org/~pcpa/surf-geometry-1.0.6-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
