[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- erlang-riak_search-1.1.4-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- erlang-riak_search-1.1.4-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/erlang-riak_search-1.1.4-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766
--- Comment #4 from Patrick Uiterwijk puiterw...@gmail.com ---
Since erlang-riak_kv has now made it into a rawhide compose, hereby a review:
- With this package, you again have a sed line. Please replace this with a
patch.
- Here the ouput from fedora-review:
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[!]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[!]: MUST Requires correct, justified where necessary.
Note: Please add a comment why the %{?_isa} are needed
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[!]: MUST Useful -debuginfo package or justification otherwise.
Note: Please add a description to %global debug_package %{nil} please
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[!]: SHOULD Latest version is packaged.
Note: 1.1.4 is release about a month ago
[x]: SHOULD Package does not include license text files separate from
upstream.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Source0 (basho-riak_search-1.1.2-0-g31220b9.tar.gz)
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766
--- Comment #5 from Peter Lemenkov lemen...@gmail.com ---
Thanks!
(In reply to comment #4)
- With this package, you again have a sed line. Please replace this with a
patch.
Done.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at
the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
This package isn't intended for EL5.
[!]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
Note: Using both %{buildroot} and $RPM_BUILD_ROOT
Done.
[!]: MUST Requires correct, justified where necessary.
Note: Please add a comment why the %{?_isa} are needed
This package is arch-dependent (due to installation into arch-dependent
directory - %{_libdir}erlang/lib) so I have to obey Fedora guidelines for
arch-specific packages.
[!]: MUST Useful -debuginfo package or justification otherwise.
Note: Please add a description to %global debug_package %{nil} please
Done. Comment added.
[!]: SHOULD Latest version is packaged.
Note: 1.1.4 is release about a month ago
Done.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Source0 (basho-riak_search-1.1.2-0-g31220b9.tar.gz)
That's how GitHub names git snapshots. We can't do much here.
New package:
* http://peter.fedorapeople.org/erlang-riak_search.spec
* http://peter.fedorapeople.org/erlang-riak_search-1.1.4-1.fc18.src.rpm
Koji scratchbuild for Rawhide:
* http://koji.fedoraproject.org/koji/taskinfo?taskID=4340192
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Patrick Uiterwijk puiterw...@gmail.com --- Apart from those, I could not find any problems, so I declare this package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Peter Lemenkov lemen...@gmail.com --- (In reply to comment #6) Apart from those, I could not find any problems, so I declare this package APPROVED Thanks! New Package SCM Request === Package Name: erlang-riak_search Short Description: Full-text search engine based on Riak Owners: peter Branches: f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2012-07-30 01:41:03 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Whiteboard|NotReady| --- Comment #1 from Peter Lemenkov lemen...@gmail.com --- Unblocking NotReady - all dependencies are availabne at least in Rawhide and it builds just fine now: Koji scratchbuild for Rawhide: * http://koji.fedoraproject.org/koji/taskinfo?taskID=4330596 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||puiterw...@gmail.com Assignee|nob...@fedoraproject.org|puiterw...@gmail.com --- Comment #2 from Patrick Uiterwijk puiterw...@gmail.com --- I'll review this one -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Flags||fedora-review? --- Comment #3 from Patrick Uiterwijk puiterw...@gmail.com --- This cannot be reviewed yet, as erlang-riak_kv is not yet available in rawhide. I will do this tomorrow, after the new rawhide compose, as this package was built yesterday. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Bug 841766 depends on bug 652629, which changed state. Bug 652629 Summary: Review Request: erlang-riak_kv - Riak Key/Value Store https://bugzilla.redhat.com/show_bug.cgi?id=652629 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Depends On||639263, 671884, 739014, ||652585, 822472, 591926, ||652598, 652629, 823101, ||652546 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841766] Review Request: erlang-riak_search - Full-text search engine based on Riak
https://bugzilla.redhat.com/show_bug.cgi?id=841766 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||652682 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
