[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Aman Mishra changed: What|Removed |Added Flags|needinfo?(danis...@gmail.co | |m) | CC||mishra33a...@proton.me --- Comment #24 from Aman Mishra --- Title: "Game about the geography of India" Comment: "Exploring India's geography just got more engaging with this innovative game! Dive into the rich landscapes, landmarks, and cultures of India while having fun and learning simultaneously. Discover the beauty and diversity of India's geography through gameplay. Check it out on https://techylist.com/ " -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=843646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20843646%23c24 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 SonaKearney changed: What|Removed |Added CC||sonakear...@hotmail.com --- Comment #23 from SonaKearney --- Interesting, thank you for sharing, see more games and applications at https://apktodo.io/es/ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=843646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20843646%23c23 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 appsandgames changed: What|Removed |Added Flags||needinfo?(danis...@gmail.co ||m) CC||channarmalik...@gmail.com --- Comment #22 from appsandgames --- I Love it, Keep Working Hard. The Content + Comments are Very HelpFull. Mallik fom https://tecnologynew.com";>tecnology of Apps andgames Moded vresion Say's Hy. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=843646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20843646%23c22 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 ElsieBell changed: What|Removed |Added CC||fincuse...@outlook.com --- Comment #21 from ElsieBell --- Game about Indian geography APK mod can be found and downloaded for free by everyone on https://apkclasico.com/. It is completely suitable for you to explore -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=843646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20843646%23c21 -- ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 --- Comment #20 from Oliver Moore --- Finding errors is not easy and requires us to have a clear and specific strategy at https://modilimitado.com. I found and checked how they did it. See what they fixed for spotify premium is really quite great. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=843646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20843646%23c20 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Oliver Moore changed: What|Removed |Added CC||bethanysharp2...@outlook.co ||m --- Comment #19 from Oliver Moore --- Finding bugs is not easy and requires us to have a clear and specific strategy -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=843646 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%20843646%23c19 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 --- Comment #17 from Isabella --- Hi, although we are professional developers but i could not understand completely. So, it's better to visit this website that can may be helpful to you. https://bugzilla.redhat.com/show_bug.cgi?id=843646 https://lunchtimeprediction.com/ https://redhat.com/show_bug.cgi?id=843646 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=843646 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Isabella changed: What|Removed |Added CC||lunchitmeti...@gmail.com Flags||needinfo?(ElenaHughes68@out ||look.com) --- Comment #16 from Isabella --- Hi, your questions is not acceptable. because i could not understand completely. So, it's better to visit this website that can may be helpful to you. https://bugzilla.redhat.com/show_bug.cgi?id=843646 https://lunchtimeprediction.com/ https://redhat.com/show_bug.cgi?id=843646 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=843646 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 ElenaHughes changed: What|Removed |Added CC||elenahughe...@outlook.com --- Comment #15 from ElenaHughes --- Tag After School Game APK is an interesting Android game. This game takes the classic childhood chase game to the next level! download at https://apkgosu.com/tag-after-school -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=843646 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 vreatedb...@proton.me changed: What|Removed |Added CC||vreatedb...@proton.me --- Comment #14 from vreatedb...@proton.me --- That sounds like a great educational game! Learning geography can be challenging, but games can make it fun and interactive. Including the names of states and their capital cities is a good starting point to help players familiarize themselves with the geography of India. To enhance the game, you could consider adding additional information about each state such as its area, population, major landmarks, and tourist attractions. You could also include questions about famous people, cuisines, and cultures associated with each state. Another idea is to add a timed element to the game, where players have to answer as many questions as they can within a certain amount of time. You could also add a multiplayer mode where players can compete against each other. Overall, the possibilities for improving and expanding this game are endless. Good luck with the development and I hope players will enjoy learning about the geography of India through your game. http://azstream.net/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=843646 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 BrendaPerez changed: What|Removed |Added CC||janethil...@outlook.com --- Comment #13 from BrendaPerez --- A shop to change fonts for phones and computers for you is https://apktodo.com/vi/stick-war-legacy, quality and prestige. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=843646 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646
dorothy changed:
What|Removed |Added
CC||babydoroth...@gmail.com
--- Comment #12 from dorothy ---
(In reply to Michael S. from comment #1)
> Hi,
>
> while doing the review, I noted the font embedded is non free :
>
> https://yofonts.com/ ( has font but not displayed )
>
> http://www.dafont.com/share-regular.font ( and the code speak of
> urbanfonts.com but the font is not there ).
>
> The bundled sound is also under creative common license, but that's not
> clear of the version and type of CC (
> http://www.freesound.org/people/junggle/sounds/29297/ ). Ie CC-BY-NC would
> not be ok.
>
> There is also some bundled code ( sugargame ) and I think there is a missing
> requires on pygame.
>
> And since there is bundled flag, I think a exception should be granted by
> FESCO :
> http://fedoraproject.org/wiki/Package_Maintainers_Flags_Policy
>
>
> Anyway :
>
>
> Package Review
> ==
>
> Key:
> - = N/A
> x = Pass
> ! = Fail
> ? = Not evaluated
>
>
>
> Generic
> [x]: EXTRA Rpmlint is run on all installed packages.
> Note: There are rpmlint messages (see attachment).
> [x]: EXTRA Spec file according to URL is the same as in SRPM.
> [!]: MUST Package is licensed with an open-source compatible license and
> meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [x]: MUST Package successfully compiles and builds into binary rpms on at
> least one supported primary architecture.
> [-]: MUST %build honors applicable compiler flags or justifies otherwise.
> [x]: MUST All build dependencies are listed in BuildRequires, except for any
> that are listed in the exceptions section of Packaging Guidelines.
> [x]: MUST Buildroot is not present
> Note: Unless packager wants to package for EPEL5 this is fine
> [!]: MUST Package contains no bundled libraries.
> [x]: MUST Changelog in prescribed format.
> [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
> $RPM_BUILD_ROOT)
> Note: Clean would be needed if support for EPEL is required
> [x]: MUST Sources contain only permissible code or content.
> [x]: MUST Each %files section contains %defattr if rpm < 4.4
> Note: Note: defattr macros not found. They would be needed for EPEL5
> [x]: MUST Macros in Summary, %description expandable at SRPM build time.
> [-]: MUST Package contains desktop file if it is a GUI application.
> [-]: MUST Development files must be in a -devel package
> [x]: MUST Package requires other packages for directories it uses.
> [x]: MUST Package uses nothing in %doc for runtime.
> [x]: MUST Package is not known to require ExcludeArch.
> [x]: MUST Permissions on files are set properly.
> [x]: MUST Package does not contain duplicates in %files.
> [x]: MUST Package complies to the Packaging Guidelines
> [x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
> [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at
> the
> beginning of %install.
> Note: rm -rf would be needed if support for EPEL5 is required
> [x]: MUST Large documentation files are in a -doc subpackage, if required.
> [x]: MUST If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %doc.
> [!]: MUST License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses found:
> "GPL (v3 or later)" For detailed output of licensecheck see file:
> /home/misc/checkout/git/FedoraReview/843646-sugar-india/licensecheck.txt
> [x]: MUST Package consistently uses macro is (instead of hard-coded directory
> names).
> [x]: MUST Package is named using only allowed ascii characters.
> [x]: MUST Package is named according to the Package Naming Guidelines.
> [x]: MUST Package does not generate any conflict.
> Note: Package contains no Conflicts: tag(s)
> [x]: MUST Package obeys FHS, except libexecdir and /usr/target.
> [-]: MUST If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: MUST Package must own all directories that it creates.
> [x]: MUST Package does not own files or directories owned by other packages.
> [x]: MUST Package installs properly.
> [x]: MUST Package is not relocatable.
> [x]: MUST Requires correct, justified where necessary.
> [x]: MUST Rpmlint is run on all rpms the build produces.
> Note: No rpmlint messages.
> [x]: MUST Sources used to build the package match the upstream source, as
> provided in the spec URL.
> [x]: MUST Spec file is legible and written in American English.
> [x]: MUST Spec file name must match the spec package %{name}, in t
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Nelson Mcgee changed: What|Removed |Added CC||mattiehogan...@outlook.com --- Comment #11 from Nelson Mcgee --- A shop to change fonts for phones and computers for you is https://yofonts.com, quality and prestige. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=843646 ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Ben Rosser changed: What|Removed |Added Resolution|WONTFIX |NOTABUG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Ben Rosser changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks||201449 (FE-DEADREVIEW) Resolution|--- |WONTFIX Last Closed||2018-05-07 17:19:15 --- Comment #10 from Ben Rosser --- Going to close this, since there was no response. Please open a new ticket if you'd like to re-submit the package. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 --- Comment #9 from Ben Rosser --- Ping; are you still interested in this (and the other ticket, sugar-tuxmath)? Do you intend to continue working on these packages? It's been many months since my last comment. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews, please respond within a week. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646
--- Comment #8 from Ben Rosser ---
Okay, great.
According to https://activities.sugarlabs.org/en-US/sugar/addon/4587, the
latest version is "7"; the package listed here is version "2". If you are
interested in continuing the review, please update the package to the latest
version.
Also please look through the package and identify any bundled code and
libraries. Fedora policy no longer *requires* removing bundled libraries but it
strongly encourages it if possible. If it's not possible through, you MUST add
lines of the following form to your spec:
Provides: bundled(name) = version
Where "name" is the name of the bundled library and "version" the version (omit
version if you cannot determine one). You MUST also update the License tag
accordingly with the bundled licenses.
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License:_field
Also, note that you can now replace "%{__python} ./setup.py build" with
"%py2_build".
Please make these changes, and I will be happy to review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Danishka Navin changed: What|Removed |Added Flags|needinfo?(danis...@gmail.co | |m) | --- Comment #7 from Danishka Navin --- Yes,I would like to resume working on this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Ben Rosser changed: What|Removed |Added CC||danis...@gmail.com, ||rosser@gmail.com Flags||needinfo?(danis...@gmail.co ||m) --- Comment #6 from Ben Rosser --- Are you still interested in this review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Ben Rosser changed: What|Removed |Added Blocks||1364745 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] (FE-GAMESIG) Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 --- Comment #5 from Michael Scherer --- There is various issues around bundling to fix, so I think you need to find a fix for them first to have it approved. I am not fully sure to understand your question. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rwNpcI4Qeb&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Danishka Navin changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | --- Comment #4 from Danishka Navin --- Michael, Shall I proceed this bug? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZOWdfBzxyx&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Danishka Navin changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 --- Comment #3 from Michael Scherer --- It seems the flag policy is not in effect, so that part should be good, even if I would prefer to have a 2nd opinion from FESCO. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 --- Comment #2 from Michael Scherer --- Also, mathieu Bridon ( bochecha ) told me on irc that this would be a rather touchy subject, since India and neighboring country do not agree on their own borders. Not sure if that important in the OLPC project. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646
Michael Scherer changed:
What|Removed |Added
CC||m...@zarb.org
Assignee|nob...@fedoraproject.org|m...@zarb.org
Flags||fedora-review?
--- Comment #1 from Michael Scherer ---
Hi,
while doing the review, I noted the font embedded is non free :
http://www.dafont.com/share-regular.font ( and the code speak of urbanfonts.com
but the font is not there ).
The bundled sound is also under creative common license, but that's not clear
of the version and type of CC (
http://www.freesound.org/people/junggle/sounds/29297/ ). Ie CC-BY-NC would not
be ok.
There is also some bundled code ( sugargame ) and I think there is a missing
requires on pygame.
And since there is bundled flag, I think a exception should be granted by FESCO
:
http://fedoraproject.org/wiki/Package_Maintainers_Flags_Policy
Anyway :
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[!]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[!]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[x]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v3 or later)" For detailed output of licensecheck see file:
/home/misc/checkout/git/FedoraReview/843646-sugar-india/licensecheck.txt
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the p
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Danishka Navin changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 843646] Review Request: sugar-india - Game about the geography of India
https://bugzilla.redhat.com/show_bug.cgi?id=843646 Danishka Navin changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
