[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-09-02 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Blocks|849709  |
   |(mate-control-center)   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #56 from Fedora Update System  ---
mate-conf-1.4.0-15.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/mate-conf-1.4.0-15.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-26 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Blocks|844162  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #55 from Fedora Update System  ---
mate-conf-1.4.0-14.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/mate-conf-1.4.0-14.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-21 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #54 from Fedora Update System  ---
mate-conf-1.4.0-14.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/mate-conf-1.4.0-14.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Mario Blättermann  changed:

   What|Removed |Added

 Blocks||849709
   ||(mate-control-center)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Thomas Spura  changed:

   What|Removed |Added

 Blocks||844162
   ||(mate-session-manager)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2012-07-27 19:54:47 |2012-08-10 18:34:46

--- Comment #53 from Fedora Update System  ---
mate-conf-1.4.0-14.fc17 has been pushed to the Fedora 17 stable repository.  If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

leigh scott  changed:

   What|Removed |Added

 Blocks|845694  |
   |(mate-system-monitor)   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Blocks||845694
   ||(mate-system-monitor)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #52 from Dan Mashal  ---
Leigh, 

please see my comment in the bug I inked.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #51 from leigh scott  ---
@Dan How the frig can mate-conf block anything when it's already in the repo.
In future leave the block tag alone as you don't have a clue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

leigh scott  changed:

   What|Removed |Added

 Blocks|845694  |
   |(mate-system-monitor),  |
   |846794 (libmateui)  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Blocks||846794 (libmateui)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #50 from Fedora Update System  ---
mate-conf-1.4.0-14.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/mate-conf-1.4.0-14.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #49 from Fedora Update System  ---
mate-conf-1.4.0-14.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-conf-1.4.0-14.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Thomas Spura  changed:

   What|Removed |Added

 Blocks||845694

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-08-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |ON_QA

--- Comment #48 from Fedora Update System  ---
mate-conf-1.4.0-11.fc16 has been pushed to the Fedora 16 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #47 from leigh scott  ---
can you both stop editing the blocks as the spam it generates is starting to
piss me off.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Blocks|844150 (mate-desktop),  |
   |844152 (mate-file-manager), |
   |844165  |
   |(mate-window-manager)   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Wolfgang Ulbrich  changed:

   What|Removed |Added

 Blocks||844150 (mate-desktop)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Wolfgang Ulbrich  changed:

   What|Removed |Added

 Blocks||844152 (mate-file-manager)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Wolfgang Ulbrich  changed:

   What|Removed |Added

 Blocks|844152 (mate-file-manager)  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #46 from Jon Ciesla  ---
Don't re-set cvs flag, already done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Wolfgang Ulbrich  changed:

   What|Removed |Added

 Status|MODIFIED|NEW
  Flags|fedora-cvs+ |fedora-cvs?

--- Comment #45 from Wolfgang Ulbrich  ---
Yeap, it's done.
pls, can you test it and leave karma.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #44 from Fedora Update System  ---
mate-conf-1.4.0-11.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/mate-conf-1.4.0-11.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #43 from Fedora Update System  ---
mate-conf-1.4.0-11.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mate-conf-1.4.0-11.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #42 from Jon Ciesla  ---
Git done (by process-git-requests).

Branches are f16 and f17, not fc16 and fc17.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #41 from Wolfgang Ulbrich  ---
New Package SCM Request
===
Package Name: mate-conf
Short Description: A process-transparent configuration system
Owners: raveit65
Branches: fc16 fc17
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Wolfgang Ulbrich  changed:

   What|Removed |Added

  Flags||fedora-cvs?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #40 from Wolfgang Ulbrich  ---
(In reply to comment #39)
> 
> Package APPROVED
> 
> Please make these changes when you import.
> 
> 1. Please remove this from the files section
> 
> %defattr(-, root, root)
> 
> And this from the install section
> 
> rm -rf $RPM_BUILD_ROOT
> 
> 2. Please rename this patch from
> 
> GConf-2.18.0.1-reload.patch
> 
> to
> 
> %{name}-1.4.0-reload.patch
> 
> or someting similar

done

%changelog
* Tue Jul 31 2012 Wolfgang Ulbrich  - 1.4.0-11
- remove %%defattr(-, root, root)
- remove rm -rf $RPM_BUILD_ROOT from install section
- rename GConf-2.18.0.1-reload.patch to mate-conf-1.4.0-reload.patch

* Mon Jul 30 2012 Wolfgang Ulbrich  - 1.4.0-10
- remove double BuildRequires

* Sun Jul 29 2012 Wolfgang Ulbrich  - 1.4.0-9
- fix rpmlint error
- add %%doc COPYING NEWS README to mate-conf-gtk as rpmlint want this

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-8
- fix licence information
- add information to macro
- fix url
- update specific versions from dependencies from configure.in
- Change %%defines to %%global

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-7
- remove *.la files

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-6
- initial package for fedora

* Sun Dec 25 2011 Wolfgang Ulbrich  - 1.1.0-1
- mate-conf.spec based on GConf2-2.32.4-1.fc16 spec

http://koji.fedoraproject.org/koji/taskinfo?taskID=4344924

SPEC: http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec

SRPM:
http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-11.fc18.src.rpm

Thank you Leigh for doing the review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

leigh scott  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #39 from leigh scott  ---

Package Review
==

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



 C/C++ 
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST ldconfig called in %post and %postun if required.
[x]: MUST Package does not contain any libtool archives (.la)
[-]: MUST Package does not contain kernel modules.
[-} MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if
 present.
 Note: Unversioned so-files in non-devel package (fix or explain):mate-
 conf-1.4.0-10.fc18.x86_64.rpm : /usr/lib64/MateConf/2/libmateconfbackend-
 evoldap.so mate-conf-1.4.0-10.fc18.x86_64.rpm : /usr/lib64/MateConf/2
 /libmateconfbackend-oldxml.so mate-conf-1.4.0-10.fc18.x86_64.rpm :
 /usr/lib64/MateConf/2/libmateconfbackend-xml.so mate-
 conf-1.4.0-10.fc18.x86_64.rpm :
 /usr/lib64/gio/modules/libgsettingsmateconfbackend.so

These are private libaries so they are exempt.

 Generic 
[x]: EXTRA Rpmlint is run on all installed packages.
 Note: No rpmlint messages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
 least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
 Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
 Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST %config files are marked noreplace or the reason is justified.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
 Note: defattr() present in %files gtk section. This is OK if
 packaging for EPEL5. Otherwise not needed
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[!]: MUST Package installs a %{name}.desktop using desktop-file-install if
 there is such a file.
[x]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "LGPL (v2 or later)", "*No copyright* UNKNOWN", "*No copyright* GENERATED
 FILE", "GPL (v2 or later)", "LGPL (v2 or later) (with incorrect FSF
 address)" For detailed output of licensecheck see file:
 /home/leigh/Desktop/844015-mate-conf/licensecheck.txt
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
 names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST No %config files under /usr.
[!]: MUST Package does not generate any conflict.
 Note: Package contains Conflicts: tag(s) needing fix or justification.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by o

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

leigh scott  changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

leigh scott  changed:

   What|Removed |Added

   Keywords|Reopened|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #38 from leigh scott  ---
(In reply to comment #33)
> new scratch build for a new reviewer
> 
> mate-conf-1.4.0-10.fc18
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4343862
> 
> http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec
> 
> http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-10.
> fc18.src.rpm
> 

Can you the correct format as my review tool needs it


SPEC: http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec

SRPM:
http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-10.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

leigh scott  changed:

   What|Removed |Added

 Blocks||844152 (mate-file-manager),
   ||844165
   ||(mate-window-manager)
   Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co
   ||m

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Blocks|844152 (mate-file-manager), |
   |844165  |
   |(mate-window-manager)   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|dan.mas...@gmail.com|nob...@fedoraproject.org

--- Comment #37 from Dan Mashal  ---
I'm stepping back from this review as per the following rule:

http://fedoraproject.org/wiki/Package_Review_Process

The Reviewer can be any Fedora account holder, who is a member of the packager
group. There is one exception: If it is the first package of a Contributor, the
Reviewer must be a Sponsor. You can check if a Contributor has already been
sponsored by looking the e-mail address up in the packager group of the account
system.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Steve Zesch  changed:

   What|Removed |Added

 CC||stevezes...@gmail.com

--- Comment #36 from Steve Zesch  ---
Upstream dev here.

macros.mateconf is not required to build mate-conf nor is it required for
mate-conf to function properly. Its purpose is to allow for schema removal when
mate-conf is removed and to handle upgrades. Basically, it's something that's
nice to have but it's not a necessity. We use something similar in our packages
for other distros.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Wolfgang Ulbrich  changed:

   What|Removed |Added

  Flags|fedora-review?  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #35 from Wolfgang Ulbrich  ---
wir harren der Dinge die da kommen!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #34 from Dan Mashal  ---
Wolfgang, I am doing the review. I appreciate your patience and explanation of
the questions I had tonight. 

Please be patient. Reviews don't happen over night.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #33 from Wolfgang Ulbrich  ---
new scratch build for a new reviewer

mate-conf-1.4.0-10.fc18

http://koji.fedoraproject.org/koji/taskinfo?taskID=4343862

http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec

http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-10.fc18.src.rpm

changelog
* Mon Jul 30 2012 Wolfgang Ulbrich  - 1.4.0-10
- remove double BuildRequires

* Sun Jul 29 2012 Wolfgang Ulbrich  - 1.4.0-9
- fix rpmlint error
- add %%doc COPYING NEWS README to mate-conf-gtk as rpmlint want this

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-8
- fix licence information
- add information to macro
- fix url
- update specific versions from dependencies from configure.in
- Change %%defines to %%global

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-7
- remove *.la files

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-6
- initial package for fedora

* Sun Dec 25 2011 Wolfgang Ulbrich  - 1.1.0-1
- mate-conf.spec based on GConf2-2.32.4-1.fc16 spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #32 from Wolfgang Ulbrich  ---
pls, can anyone other do the review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Wolfgang Ulbrich  changed:

   What|Removed |Added

  Flags|fedora-review?  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #31 from leigh scott  ---
(In reply to comment #30)
> I did a chat with Dan. 
> He told me to add a url or source1.
> like http://raveit65.fedorapeople.org/Test/macros.mateconf
> I don't find any hint of this concern in package guide line
> Can anyone confirm if this is necessary or only a idea?

macros.mateconf doesn't require a source URL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #30 from Wolfgang Ulbrich  ---
I did a chat with Dan. 
He told me to add a url or source1.
like http://raveit65.fedorapeople.org/Test/macros.mateconf
I don't find any hint of this concern in package guide line
Can anyone confirm if this is necessary or only a idea?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #29 from Dan Mashal  ---
f17 and f18 reviews were successful with Wolfgang's srpm. Will complete review
first thing tomorrow.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #28 from leigh scott  ---
(In reply to comment #27)

> I am trying to do some koji builds with your srpm and I'll see what happens,
> however please take a look at my spec for some hints, you will see why I
> raised the initial concerns that I did. And again, I'm not saying you don't
> make valid points.


Your concerns are aren't valid please stick to the review guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #27 from Dan Mashal  ---
$ fedora-review -b 844015
Processing bugzilla bug: 844015
Bugzilla v0.7.0 initializing
Chose subclass RHBugzilla v0.1
Trying bugzilla cookies for authentication
Getting .spec and .srpm Urls from : 844015
  --> SRPM url:
http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-9.fc18.src.rpm
  --> Spec url:
http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec
Using review directory: /home/dan/844015-mate-conf
Downloading .spec and .srpm files
Downloading (Source0):
http://pub.mate-desktop.org/releases/1.4/mate-conf-1.4.0.tar.xz
No upstream for (Source1): macros.mateconf
Running checks and generate report

Rebuilding /home/dan/844015-mate-conf/srpm/mate-conf-1.4.0-9.fc18.src.rpm using
default root
ERROR:
Exception(/home/dan/844015-mate-conf/srpm/mate-conf-1.4.0-9.fc18.src.rpm)
Config(fedora-17-x86_64) 0 minutes 10 seconds
INFO: Results and/or logs in: /home/dan/844015-mate-conf/results
ERROR: Command failed: 
Build failed rc = Build error(s)
Exception down the road...


build.log:

Start: device setup
Finish: device setup
Start: yum update
Finish: yum update
Finish: lock buildroot
Finish: chroot init
INFO: Installed packages:
Start: build phase for mate-conf-1.4.0-9.fc18.src.rpm
Start: device setup
Finish: device setup
Start: build setup for mate-conf-1.4.0-9.fc18.src.rpm
ERROR:
Exception(/home/dan/844015-mate-conf/srpm/mate-conf-1.4.0-9.fc18.src.rpm)
Config(fedora-17-x86_64) 0 minutes 10 seconds
INFO: Results and/or logs in: /home/dan/844015-mate-conf/results
ERROR: Command failed:
 # ['/usr/bin/yum-builddep', '--installroot',
'/var/lib/mock/fedora-17-x86_64/root/',
'/var/lib/mock/fedora-17-x86_64/root///builddir/build/SRPMS/mate-conf-1.4.0-9.fc17.src.rpm']
Getting requirements for mate-conf-1.4.0-9.fc17.src
 --> libxml2-devel-2.7.8-7.fc17.x86_64
 --> libxslt-devel-1.1.26-9.fc17.x86_64
Error: No Package found for mate-corba-devel >= 1.1.0



The buildroot override expired today but I re enabled it before running the
review.

Please review my spec file here:

http://vicodan.fedorapeople.org/matespec/mate-conf.spec

[dan@Fedora18 x86_64]$ rpmbuild -bs ../../SPECS/mate-conf.spec 
Wrote: /home/dan/rpmbuild/SRPMS/mate-conf-1.4.0-2.fc17.src.rpm
[dan@Fedora18 x86_64]$ rpmlint mate-conf-1.4.0-2.fc17.x86_64.rpm 
mate-conf.x86_64: E: incorrect-fsf-address
/usr/share/doc/mate-conf-1.4.0/COPYING
mate-conf.x86_64: E: incorrect-fsf-address
/usr/bin/mateconf-gsettings-schema-convert
mate-conf.x86_64: W: no-manual-page-for-binary mateconf-merge-tree
1 packages and 0 specfiles checked; 2 errors, 1 warnings.


[dan@Fedora18 x86_64]$ rpmlint mate-conf-devel-1.4.0-2.fc17.x86_64.rpm 
mate-conf-devel.x86_64: W: no-dependency-on
mate-conf/mate-conf-libs/libmate-conf
mate-conf-devel.x86_64: W: spelling-error %description -l en_US Lbraries ->
Libraries, Brasseries
mate-conf-devel.x86_64: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


$ rpmlint mate-conf-1.4.0-2.fc17.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


$ rpmlint mate-conf.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ koji build --scratch f17 mate-conf-1.4.0-2.fc17.src.rpm 
Uploading srpm: mate-conf-1.4.0-2.fc17.src.rpm
[] 100% 00:00:02 941.21 KiB 331.41 KiB/sec
Created task: 4341365
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4341365
Watching tasks (this may be safely interrupted)...
4341365 build (f17, mate-conf-1.4.0-2.fc17.src.rpm): free
4341365 build (f17, mate-conf-1.4.0-2.fc17.src.rpm): free -> open
(x86-04.phx2.fedoraproject.org)
  4341367 buildArch (mate-conf-1.4.0-2.fc17.src.rpm, i686): open
(buildvm-12.phx2.fedoraproject.org)
  4341366 buildArch (mate-conf-1.4.0-2.fc17.src.rpm, x86_64): open
(buildvm-02.phx2.fedoraproject.org)
  4341366 buildArch (mate-conf-1.4.0-2.fc17.src.rpm, x86_64): open
(buildvm-02.phx2.fedoraproject.org) -> closed
  0 free  2 open  1 done  0 failed
  4341367 buildArch (mate-conf-1.4.0-2.fc17.src.rpm, i686): open
(buildvm-12.phx2.fedoraproject.org) -> closed
  0 free  1 open  2 done  0 failed
4341365 build (f17, mate-conf-1.4.0-2.fc17.src.rpm): open
(x86-04.phx2.fedoraproject.org) -> closed
  0 free  0 open  3 done  0 failed
$ koji build --scratch f18 mate-conf-1.4.0-2.fc17.src.rpm 
Uploading srpm: mate-conf-1.4.0-2.fc17.src.rpm
[] 100% 00:00:02 941.21 KiB 370.61 KiB/sec
Created task: 4341368
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=4341368
Watching tasks (this may be safely interrupted)...
4341368 build (f18, mate-conf-1.4.0-2.fc17.src.rpm): free
4341368 build (f18, mate-conf-1.4.0-2.fc17.src.rpm): free -> open
(buildvm-04.phx2.fedoraproject.org)
  4341370 buildArch (mate-conf-1.4.0-2.fc17.src.rpm, i686): free
  4341369 buildArch (mate-conf-1.4.0-2.fc17.src.rpm, x86_64): free
  4341369 buildArch (mate-conf-1.4.0-2.fc17.src.rpm, x86_64)

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #26 from Dan Mashal  ---
Have a few errands to run. Will do the review in a few hours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #25 from Wolfgang Ulbrich  ---
Dan Mashal, are you threre?
can you do the review pls?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #24 from leigh scott  ---
(In reply to comment #23)
> 
> 
> mate-conf.x86_64: W: no-manual-page-for-binary mateconf-merge-tree
> Each executable in standard binary directories should have a man page.
> 
> I don't now how to fix it.
> 

You don't fix it as it's a upstream issue so you can ignore it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #23 from leigh scott  ---
(In reply to comment #22)
> new scratch build
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=4340424
> 
> 
> %changelog
> * Sun Jul 29 2012 Wolfgang Ulbrich  - 1.4.0-9
> - fix rpmlint error
> - add %%doc COPYING NEWS README to mate-conf-gtk as rpmlint want this
> 
> * Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-8
> - fix licence information
> - add information to macro
> - fix url
> - update specific versions from dependencies from configure.in
> - Change %%defines to %%global
> 
> * Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-7
> - remove *.la files
> 
> * Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-6
> - initial package for fedora
> 
> * Sun Dec 25 2011 Wolfgang Ulbrich  - 1.1.0-1
> - mate-conf.spec based on GConf2-2.32.4-1.fc16 spec
> 
> 
> 
> http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec
> 
> http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-9.
> fc18.src.rpm
> 
> 
> [rave@mother 1.4.0-8]$ rpmlint -iv
> /media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.
> fc18.src/mate-conf.spec 
> /media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.
> fc18.src/mate-conf.spec: I: checking-url
> http://pub.mate-desktop.org/releases/1.4/mate-conf-1.4.0.tar.xz (timeout 10
> seconds)
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
> 
> 
> [rave@mother 1.4.0-8]$ rpmlint -iv
> /media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.
> fc18.src.rpm 
> mate-conf.src: I: checking
> mate-conf.src: I: checking-url http://mate-desktop.org (timeout 10 seconds)
> mate-conf.src: I: checking-url
> http://pub.mate-desktop.org/releases/1.4/mate-conf-1.4.0.tar.xz (timeout 10
> seconds)
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> 
> [rave@mother 1.4.0-8]$ rpmlint -iv
> /media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.
> fc18.x86_64.rpm 
> mate-conf.x86_64: I: checking
> mate-conf.x86_64: I: checking-url http://mate-desktop.org (timeout 10
> seconds)
> mate-conf.x86_64: E: incorrect-fsf-address
> /usr/share/doc/mate-conf-1.4.0/COPYING
> The Free Software Foundation address in this file seems to be outdated or
> misspelled.  Ask upstream to update the address, or if this is a license
> file,
> possibly the entire file with a new copy available from the FSF.
> 
> mate-conf.x86_64: E: incorrect-fsf-address
> /usr/bin/mateconf-gsettings-schema-convert
> The Free Software Foundation address in this file seems to be outdated or
> misspelled.  Ask upstream to update the address, or if this is a license
> file,
> possibly the entire file with a new copy available from the FSF.
> 
> mate-conf.x86_64: W: no-manual-page-for-binary mateconf-merge-tree
> Each executable in standard binary directories should have a man page.
> 
> 1 packages and 0 specfiles checked; 2 errors, 1 warnings.
> 
> 
> [rave@mother 1.4.0-8]$ rpmlint -iv
> /media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-devel-1.
> 4.0-9.fc18.x86_64.rpm 
> mate-conf-devel.x86_64: I: checking
> mate-conf-devel.x86_64: I: checking-url http://mate-desktop.org (timeout 10
> seconds)
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> 
> [rave@mother 1.4.0-8]$ rpmlint -iv
> /media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-
> debuginfo-1.4.0-9.fc18.x86_64.rpm 
> mate-conf-debuginfo.x86_64: I: checking
> mate-conf-debuginfo.x86_64: I: checking-url http://mate-desktop.org (timeout
> 10 seconds)
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> 
> [rave@mother 1.4.0-8]$ rpmlint -iv
> /media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-gtk-1.4.
> 0-9.fc18.x86_64.rpm 
> mate-conf-gtk.x86_64: I: checking
> mate-conf-gtk.x86_64: I: checking-url http://mate-desktop.org (timeout 10
> seconds)
> mate-conf-gtk.x86_64: E: incorrect-fsf-address
> /usr/share/doc/mate-conf-gtk-1.4.0/COPYING
> The Free Software Foundation address in this file seems to be outdated or
> misspelled.  Ask upstream to update the address, or if this is a license
> file,
> possibly the entire file with a new copy available from the FSF.
> 
> 1 packages and 0 specfiles checked; 1 errors, 0 warnings.
> 
> 
> @rpmlint
> for incorrect-fsf-address i notice upstream in comment 9
> 
> mate-conf.x86_64: W: no-manual-page-for-binary mateconf-merge-tree
> Each executable in standard binary directories should have a man page.
> 
> I don't now how to fix it.
> 
> Pls take a look at all.
> 
> TODO:
> waiting for last mate-common in stable to remove unnecessaries BuildRequires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #22 from Wolfgang Ulbrich  ---
new scratch build

http://koji.fedoraproject.org/koji/taskinfo?taskID=4340424


%changelog
* Sun Jul 29 2012 Wolfgang Ulbrich  - 1.4.0-9
- fix rpmlint error
- add %%doc COPYING NEWS README to mate-conf-gtk as rpmlint want this

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-8
- fix licence information
- add information to macro
- fix url
- update specific versions from dependencies from configure.in
- Change %%defines to %%global

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-7
- remove *.la files

* Sat Jul 28 2012 Wolfgang Ulbrich  - 1.4.0-6
- initial package for fedora

* Sun Dec 25 2011 Wolfgang Ulbrich  - 1.1.0-1
- mate-conf.spec based on GConf2-2.32.4-1.fc16 spec



http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec

http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-9.fc18.src.rpm


[rave@mother 1.4.0-8]$ rpmlint -iv
/media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.fc18.src/mate-conf.spec
 
/media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.fc18.src/mate-conf.spec:
I: checking-url http://pub.mate-desktop.org/releases/1.4/mate-conf-1.4.0.tar.xz
(timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.


[rave@mother 1.4.0-8]$ rpmlint -iv
/media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.fc18.src.rpm
 
mate-conf.src: I: checking
mate-conf.src: I: checking-url http://mate-desktop.org (timeout 10 seconds)
mate-conf.src: I: checking-url
http://pub.mate-desktop.org/releases/1.4/mate-conf-1.4.0.tar.xz (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[rave@mother 1.4.0-8]$ rpmlint -iv
/media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-1.4.0-9.fc18.x86_64.rpm
 
mate-conf.x86_64: I: checking
mate-conf.x86_64: I: checking-url http://mate-desktop.org (timeout 10 seconds)
mate-conf.x86_64: E: incorrect-fsf-address
/usr/share/doc/mate-conf-1.4.0/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

mate-conf.x86_64: E: incorrect-fsf-address
/usr/bin/mateconf-gsettings-schema-convert
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

mate-conf.x86_64: W: no-manual-page-for-binary mateconf-merge-tree
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 2 errors, 1 warnings.


[rave@mother 1.4.0-8]$ rpmlint -iv
/media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-devel-1.4.0-9.fc18.x86_64.rpm
 
mate-conf-devel.x86_64: I: checking
mate-conf-devel.x86_64: I: checking-url http://mate-desktop.org (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[rave@mother 1.4.0-8]$ rpmlint -iv
/media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-debuginfo-1.4.0-9.fc18.x86_64.rpm
 
mate-conf-debuginfo.x86_64: I: checking
mate-conf-debuginfo.x86_64: I: checking-url http://mate-desktop.org (timeout 10
seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


[rave@mother 1.4.0-8]$ rpmlint -iv
/media/Jackass/Downloads/fc16/Mate/mate-conf/fc18/1.4.0-9/mate-conf-gtk-1.4.0-9.fc18.x86_64.rpm
 
mate-conf-gtk.x86_64: I: checking
mate-conf-gtk.x86_64: I: checking-url http://mate-desktop.org (timeout 10
seconds)
mate-conf-gtk.x86_64: E: incorrect-fsf-address
/usr/share/doc/mate-conf-gtk-1.4.0/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

1 packages and 0 specfiles checked; 1 errors, 0 warnings.


@rpmlint
for incorrect-fsf-address i notice upstream in comment 9

mate-conf.x86_64: W: no-manual-page-for-binary mateconf-merge-tree
Each executable in standard binary directories should have a man page.

I don't now how to fix it.

Pls take a look at all.

TODO:
waiting for last mate-common in stable to remove unnecessaries BuildRequires

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Michael Scherer  changed:

   What|Removed |Added

 Blocks||844152 (mate-file-manager)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Michael Scherer  changed:

   What|Removed |Added

 Blocks||844165
   ||(mate-window-manager)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

raveit65  changed:

   What|Removed |Added

 CC||chat-to...@raveit.de

--- Comment #21 from raveit65  ---
(In reply to comment #10)
> 1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in
> source folder)
done

> 2) Please remove source1
Can you explain me specific why this macro is bad if it isn't forbidden in
package guide lines?
'why' is declared inside the macro.
# Copy schemas from old package for later uninstall on upgrade
# Macro to remove schemas.  Not meant to be used publically
# Remove schemas unconditionally
# Remove schemas on package removal (not upgrade)

Same macro is also used by latest GConf2-3.2.5-2.fc18.src.rpm
http://koji.fedoraproject.org/koji/rpminfo?rpmID=3204445

If gnome can why not me?


> 3) Please update URL to http://mate-desktop.org

done
> 4) Please remove specific versions from dependencies (see below).

Specific version are mostly declared in configure.ac or configure.n in source
code. So i have to to it.
But, I will take a look in configure.in for using the correct version no.

> 5) Please remove unneeded defines in top of spec file.

done

> 6) Please remove patches and submit them to upstream, or give a logical
> explanation of why they MUST be in this package.
> Specific versions in the spec file because are not necessary.

This patched wasn't upstreamed to gnome git before perberos forked GConf2.
Without this patch we can run into this bug.
http://bugzilla.gnome.org/show_bug.cgi?id=568845


> 
> 
> tail of fedora-review build.log:
> 
> INFO: Installed packages:
> Start: build phase for mate-conf-1.4.0-7.fc18.src.rpm
> Start: device setup
> Finish: device setup
> Start: build setup for mate-conf-1.4.0-7.fc18.src.rpm
> ERROR:
> Exception(/home/dan/844015-mate-conf/srpm/mate-conf-1.4.0-7.fc18.src.rpm)
> Config(fedora-17-x86_64) 0 minutes 11 seconds
> INFO: Results and/or logs in: /home/dan/844015-mate-conf/results
> ERROR: Command failed:
>  # ['/usr/bin/yum-builddep', '--installroot',
> '/var/lib/mock/fedora-17-x86_64/root/',
> '/var/lib/mock/fedora-17-x86_64/root///builddir/build/SRPMS/mate-conf-1.4.0-
> 7.fc17.src.rpm']
> Getting requirements for mate-conf-1.4.0-7.fc17.src
>  --> libxml2-devel-2.7.8-7.fc17.x86_64
>  --> libxslt-devel-1.1.26-9.fc17.x86_64
> Error: No Package found for mate-corba-devel >= 1.1.0
> 


Weird,
see root.log in my scratch build

DEBUG util.py:257:   Package   Arch Version
  Repository
DEBUG util.py:257: 
   Size
DEBUG util.py:257: 

DEBUG util.py:257:  Installing:
DEBUG util.py:257:   autoconf  noarch   2.69-3.fc18
  build   701 k
DEBUG util.py:257:   automake  noarch   1.12.2-2.fc18  
  build   664 k
DEBUG util.py:257:   dbus-glib-devel   x86_64   0.100-1.fc18   
  build51 k
DEBUG util.py:257:   gettext   x86_64   0.18.1.1-16.fc18   
  build   1.1 M
DEBUG util.py:257:   glib2-devel   x86_64   2.33.6-2.fc18  
  build   1.9 M
DEBUG util.py:257:   gobject-introspection-devel   x86_64   1.33.4-2.fc18  
  build   1.0 M
DEBUG util.py:257:   gtk-doc   noarch   1.18-3.fc18
  build   266 k
DEBUG util.py:257:   gtk2-develx86_64   2.24.11-2.fc18 
  build   2.9 M
DEBUG util.py:257:   intltool  noarch   0.50.2-3.fc18  
  build58 k
DEBUG util.py:257:   libtool   x86_64   2.4.2-6.fc18   
  build   586 k
DEBUG util.py:257:   libxml2-devel x86_64   2.8.0-2.fc18   
  build   1.2 M
DEBUG util.py:257:   libxslt-devel x86_64   1.1.26-10.fc18 
  build   304 k
DEBUG util.py:257:   mate-common   noarch   1.4.0-6.fc18   
  build13 k
DEBUG util.py:257:   mate-corba-devel  x86_64   1.4.0-9.fc18   
  build   162 k


1.4.0 > 1.1.0 right?



> =
> ===
> 
> rmlint on srpm:
> 
> 
> $ rpmlint mate-conf-1.4.0-7.fc18.src.rpm 
> mate-conf.src: W: spelling-error %description -l en_US pluggable -> plug
> gable, plug-gable, plugged
> mate-conf.src: W: spelling-error %description -l en_US backends -> back
> ends, back-ends, backhands
> mate-conf.src: W: spelling-error %description -l en_US workgroup -> work
> group, work-group, groundwork
> mate-conf.src:113: W: deprecated-grep [u'fgrep']
> mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line
> 7)
> 1 

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #20 from raveit65  ---
Sorry:

TODO:
rpmlint errors
remove of BuildRequires: autoconf automake libtool gettext
if mate-common-1.4.0-6.fc16 is in stable

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #19 from raveit65  ---
http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec

http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-8.fc18.src.rpm


(In reply to comment #11)
> (In reply to comment #10)
> > Hi Wolfgang,
> > 
> > Thanks for taking the time to help contribute to the work going in to MATE
> > Desktop for Fedora.
> > 
> > Some initial thoughts:
> > 
> > Easy stuff:
> > 
> > 1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in
> > source folder)
> 
> This is a must

Done.

> > 2) Please remove source1
> 
> This is allowed (show me the guideline that prohibits this)
> 
> > 3) Please update URL to http://mate-desktop.org
> 
> This is a must.

done

> > 4) Please remove specific versions from dependencies (see below).
> 
> This is allowed and needed. (show me the guideline that prohibits this)

Correct specific versions from dependencies as in configure.in

> > 5) Please remove unneeded defines in top of spec file.
> 
> This is a must.
> 
> Change %defines to %global

Done

> 
> > 6) Please remove patches and submit them to upstream, or give a logical
> > explanation of why they MUST be in this package.
> 
> This is allowed. (show me the guideline that prohibits this)

+
add information to macro

TODO:
rpmlint errors
remove of BuildRequires: utoconf automake libtool gettext
if mate-common-1.4.0-6.fc16 is in stable

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #18 from raveit65  ---
http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec

http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-8.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #17 from raveit65  ---
new scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=4339394

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #16 from raveit65  ---
(In reply to comment #10)
> 1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in
> source folder)
done

> 2) Please remove source1
Can you explain me specific why this macro is bad if it isn't forbidden in
package guide lines?
'why' is declared inside the macro.
# Copy schemas from old package for later uninstall on upgrade
# Macro to remove schemas.  Not meant to be used publically
# Remove schemas unconditionally
# Remove schemas on package removal (not upgrade)

Same macro is also used by latest GConf2-3.2.5-2.fc18.src.rpm
http://koji.fedoraproject.org/koji/rpminfo?rpmID=3204445

If gnome can why not me?


> 3) Please update URL to http://mate-desktop.org

done
> 4) Please remove specific versions from dependencies (see below).

Specific version are mostly declared in configure.ac or configure.n in source
code. So i have to to it.
But, I will take a look in configure.in for using the correct version no.

> 5) Please remove unneeded defines in top of spec file.

done

> 6) Please remove patches and submit them to upstream, or give a logical
> explanation of why they MUST be in this package.
> Specific versions in the spec file because are not necessary.

This patched wasn't upstreamed to gnome git before perberos forked GConf2.
Without this patch we can run into this bug.
http://bugzilla.gnome.org/show_bug.cgi?id=568845


> 
> 
> tail of fedora-review build.log:
> 
> INFO: Installed packages:
> Start: build phase for mate-conf-1.4.0-7.fc18.src.rpm
> Start: device setup
> Finish: device setup
> Start: build setup for mate-conf-1.4.0-7.fc18.src.rpm
> ERROR:
> Exception(/home/dan/844015-mate-conf/srpm/mate-conf-1.4.0-7.fc18.src.rpm)
> Config(fedora-17-x86_64) 0 minutes 11 seconds
> INFO: Results and/or logs in: /home/dan/844015-mate-conf/results
> ERROR: Command failed:
>  # ['/usr/bin/yum-builddep', '--installroot',
> '/var/lib/mock/fedora-17-x86_64/root/',
> '/var/lib/mock/fedora-17-x86_64/root///builddir/build/SRPMS/mate-conf-1.4.0-
> 7.fc17.src.rpm']
> Getting requirements for mate-conf-1.4.0-7.fc17.src
>  --> libxml2-devel-2.7.8-7.fc17.x86_64
>  --> libxslt-devel-1.1.26-9.fc17.x86_64
> Error: No Package found for mate-corba-devel >= 1.1.0
> 


Weird,
see root.log in my scratch build

DEBUG util.py:257:   Package   Arch Version
  Repository
DEBUG util.py:257: 
   Size
DEBUG util.py:257: 

DEBUG util.py:257:  Installing:
DEBUG util.py:257:   autoconf  noarch   2.69-3.fc18
  build   701 k
DEBUG util.py:257:   automake  noarch   1.12.2-2.fc18  
  build   664 k
DEBUG util.py:257:   dbus-glib-devel   x86_64   0.100-1.fc18   
  build51 k
DEBUG util.py:257:   gettext   x86_64   0.18.1.1-16.fc18   
  build   1.1 M
DEBUG util.py:257:   glib2-devel   x86_64   2.33.6-2.fc18  
  build   1.9 M
DEBUG util.py:257:   gobject-introspection-devel   x86_64   1.33.4-2.fc18  
  build   1.0 M
DEBUG util.py:257:   gtk-doc   noarch   1.18-3.fc18
  build   266 k
DEBUG util.py:257:   gtk2-develx86_64   2.24.11-2.fc18 
  build   2.9 M
DEBUG util.py:257:   intltool  noarch   0.50.2-3.fc18  
  build58 k
DEBUG util.py:257:   libtool   x86_64   2.4.2-6.fc18   
  build   586 k
DEBUG util.py:257:   libxml2-devel x86_64   2.8.0-2.fc18   
  build   1.2 M
DEBUG util.py:257:   libxslt-devel x86_64   1.1.26-10.fc18 
  build   304 k
DEBUG util.py:257:   mate-common   noarch   1.4.0-6.fc18   
  build13 k
DEBUG util.py:257:   mate-corba-devel  x86_64   1.4.0-9.fc18   
  build   162 k


1.4.0 > 1.1.0 right?



> =
> ===
> 
> rmlint on srpm:
> 
> 
> $ rpmlint mate-conf-1.4.0-7.fc18.src.rpm 
> mate-conf.src: W: spelling-error %description -l en_US pluggable -> plug
> gable, plug-gable, plugged
> mate-conf.src: W: spelling-error %description -l en_US backends -> back
> ends, back-ends, backhands
> mate-conf.src: W: spelling-error %description -l en_US workgroup -> work
> group, work-group, groundwork
> mate-conf.src:113: W: deprecated-grep [u'fgrep']
> mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line
> 7)
> 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
> 
> MUST fix:
> 
> mate-conf.src:113: W: deprecated-grep [u'fgrep']
> mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line
> 7)
> 
> ==

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #15 from leigh scott  ---
(In reply to comment #13)
> Which package provides 'license check -r' ?

# rpm -qf $(which licensecheck)
rpmdevtools-8.2-2.fc17.noarch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #14 from Dan Mashal  ---
sorry, the command is "licensecheck".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #13 from raveit65  ---
Which package provides 'license check -r' ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #12 from Dan Mashal  ---
@Leigh, 

Sure it's allowed but you must put a comment as to why it's there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #11 from leigh scott  ---
(In reply to comment #10)
> Hi Wolfgang,
> 
> Thanks for taking the time to help contribute to the work going in to MATE
> Desktop for Fedora.
> 
> Some initial thoughts:
> 
> Easy stuff:
> 
> 1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in
> source folder)

This is a must

> 2) Please remove source1

This is allowed (show me the guideline that prohibits this)

> 3) Please update URL to http://mate-desktop.org

This is a must.


> 4) Please remove specific versions from dependencies (see below).

This is allowed and needed. (show me the guideline that prohibits this)


> 5) Please remove unneeded defines in top of spec file.

This is a must.

Change %defines to %global

> 6) Please remove patches and submit them to upstream, or give a logical
> explanation of why they MUST be in this package.

This is allowed. (show me the guideline that prohibits this)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #10 from Dan Mashal  ---
Hi Wolfgang,

Thanks for taking the time to help contribute to the work going in to MATE
Desktop for Fedora.

Some initial thoughts:

Easy stuff:

1) Please update license to LGPLv2+ and GPLv2+ (run license check -r . in
source folder)
2) Please remove source1
3) Please update URL to http://mate-desktop.org
4) Please remove specific versions from dependencies (see below).
5) Please remove unneeded defines in top of spec file.
6) Please remove patches and submit them to upstream, or give a logical
explanation of why they MUST be in this package.

Specific versions in the spec file because are not necessary.

I understand you are looking out for the users in your repo but that is the
reason why we stopped pushing packages to the repo and are building on rawhide
only for now.



tail of fedora-review build.log:

INFO: Installed packages:
Start: build phase for mate-conf-1.4.0-7.fc18.src.rpm
Start: device setup
Finish: device setup
Start: build setup for mate-conf-1.4.0-7.fc18.src.rpm
ERROR:
Exception(/home/dan/844015-mate-conf/srpm/mate-conf-1.4.0-7.fc18.src.rpm)
Config(fedora-17-x86_64) 0 minutes 11 seconds
INFO: Results and/or logs in: /home/dan/844015-mate-conf/results
ERROR: Command failed:
 # ['/usr/bin/yum-builddep', '--installroot',
'/var/lib/mock/fedora-17-x86_64/root/',
'/var/lib/mock/fedora-17-x86_64/root///builddir/build/SRPMS/mate-conf-1.4.0-7.fc17.src.rpm']
Getting requirements for mate-conf-1.4.0-7.fc17.src
 --> libxml2-devel-2.7.8-7.fc17.x86_64
 --> libxslt-devel-1.1.26-9.fc17.x86_64
Error: No Package found for mate-corba-devel >= 1.1.0



rmlint on srpm:


$ rpmlint mate-conf-1.4.0-7.fc18.src.rpm 
mate-conf.src: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
mate-conf.src: W: spelling-error %description -l en_US backends -> back ends,
back-ends, backhands
mate-conf.src: W: spelling-error %description -l en_US workgroup -> work group,
work-group, groundwork
mate-conf.src:113: W: deprecated-grep [u'fgrep']
mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 7)
1 packages and 0 specfiles checked; 0 errors, 5 warnings.

MUST fix:

mate-conf.src:113: W: deprecated-grep [u'fgrep']
mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 7)




Also we don't need to create a separate gtk package for files that are already
provided by gnome in the Fedora stable repo (unless we have a VERY good
reason).

Please also run rpmlint on the binary rpm generated on my local machine there
are a few files that used rpath (I'm still working on it but you can see my
spec file on my fp page that is a WIP). 

Please review the following:

https://fedoraproject.org/wiki/Common_Rpmlint_issues
http://fedoraproject.org/wiki/Packaging:Guidelines


Please also keep in mind, we want to package an RPM that is as close to
upstream source as possible with as little modification to the source code as
possible.

We do not want to modify or patch the code whatsoever unless absolutely
necessary.

If there is something that you disagree with, please talk to me on IRC or
google talk and we can discuss it further. 


Once you address all of the issues above the package review can continue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #9 from raveit65  ---
The incorrect-fsf-address issue i've reported to upstream.

https://github.com/mate-desktop/mate-conf/issues/3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #8 from raveit65  ---
(In reply to comment #7)
> You will need to delete all the .la files.

Thank you Leigh,
done.

New scratch build for fc18
http://koji.fedoraproject.org/koji/taskinfo?taskID=4338167

http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SPECS/mate-conf.spec

http://raveit65.fedorapeople.org/Mate-Desktop/fc18/SRPM/mate-conf-1.4.0-7.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

  Alias||mate-conf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

leigh scott  changed:

   What|Removed |Added

 CC||leigh123li...@googlemail.co
   ||m

--- Comment #7 from leigh scott  ---
(In reply to comment #0)
> Spec URL:
> http://raveit65.fedorapeople.org/Mate-Desktop/fc16/SPECS/mate-conf.spec
> SRPM URL:
> http://raveit65.fedorapeople.org/Mate-Desktop/fc16/SRPM/mate-conf-1.4.0-6.
> fc16.src.rpm
> Description: mate-conf is a process-transparent configuration database API
> used to
> store user preferences. It has pluggable backends and features to
> support workgroup administration.
> Fedora Account System Username: raveit65

You will need to delete all the .la files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

  Alias|mate-conf   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|RAWHIDE |---
   Keywords||Reopened

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2012-07-27 19:54:47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Blocks||840149 (MATE-DE-tracker)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #6 from Dan Mashal  ---
I will do the review for this. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

raveit65  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 Blocks|840149 (MATE-DE-tracker)|
   Assignee|dan.mas...@gmail.com|nob...@fedoraproject.org
 QA Contact|dan.mas...@gmail.com|extras...@fedoraproject.org

--- Comment #5 from raveit65  ---
rpmlint mate-conf.spec 
mate-conf.spec:110: W: deprecated-grep [u'fgrep']
mate-conf.spec:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 7)
0 packages and 1 specfiles checked; 0 errors, 2 warnings.

rpmlint mate-conf-1.4.0-6.fc16.i686.rpm 
mate-conf.i686: W: spelling-error %description -l en_US pluggable -> plug
gable, plug-gable, plugged
mate-conf.i686: W: spelling-error %description -l en_US backends -> back ends,
back-ends, backhands
mate-conf.i686: W: spelling-error %description -l en_US workgroup -> work
group, work-group, groundwork
mate-conf.i686: E: changelog-time-in-future 2012-07-28
mate-conf.i686: E: incorrect-fsf-address /usr/share/doc/mate-conf-1.4.0/COPYING
mate-conf.i686: E: incorrect-fsf-address
/usr/bin/mateconf-gsettings-schema-convert
mate-conf.i686: W: non-conffile-in-etc
/etc/xdg/autostart/mateconf-gsettings-data-convert.desktop
mate-conf.i686: W: non-conffile-in-etc /etc/rpm/macros.mateconf
mate-conf.i686: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.mate.MateConf.Defaults.conf
mate-conf.i686: W: no-manual-page-for-binary mateconf-merge-tree
1 packages and 0 specfiles checked; 3 errors, 7 warnings.

[rave@mother fc16]$ rpmlint mate-conf-1.4.0-6.fc16.src.rpm 
mate-conf.src: W: spelling-error %description -l en_US pluggable -> plug gable,
plug-gable, plugged
mate-conf.src: W: spelling-error %description -l en_US backends -> back ends,
back-ends, backhands
mate-conf.src: W: spelling-error %description -l en_US workgroup -> work group,
work-group, groundwork
mate-conf.src: E: changelog-time-in-future 2012-07-28
mate-conf.src:110: W: deprecated-grep [u'fgrep']
mate-conf.src:7: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 7)
1 packages and 0 specfiles checked; 1 errors, 5 warnings.

[rave@mother fc16]$ rpmlint mate-conf-devel-1.4.0-6.fc16.i686.rpm 
mate-conf-devel.i686: E: changelog-time-in-future 2012-07-28
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

[rave@mother fc16]$ rpmlint mate-conf-gtk-1.4.0-6.fc16.i686.rpm 
mate-conf-gtk.i686: E: changelog-time-in-future 2012-07-28
mate-conf-gtk.i686: W: no-documentation
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks||840149 (MATE-DE-tracker)
  Alias||mate-conf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 QA Contact|extras...@fedoraproject.org |dan.mas...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

  Flags||fedora-review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

Dan Mashal  changed:

   What|Removed |Added

 CC||dan.mas...@gmail.com
   Assignee|nob...@fedoraproject.org|dan.mas...@gmail.com

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #4 from raveit65  ---
Created attachment 600878
  --> https://bugzilla.redhat.com/attachment.cgi?id=600878&action=edit
GConf-2.18.0.1-reload.patch

# http://bugzilla.gnome.org/show_bug.cgi?id=568845
this patch is taken from fc16 gconf2 and adjusted for mate-conf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #3 from raveit65  ---
Created attachment 600877
  --> https://bugzilla.redhat.com/attachment.cgi?id=600877&action=edit
macros.mate.conf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #2 from raveit65  ---
scratch builds from fc16 src.rpm:
fc16
http://koji.fedoraproject.org/koji/taskinfo?taskID=4337828
0 free  0 open  3 done  0 failed

fc17
http://koji.fedoraproject.org/koji/taskinfo?taskID=4337844
0 free  0 open  3 done  0 failed

fc18
http://koji.fedoraproject.org/koji/taskinfo?taskID=4337847
0 free  0 open  3 done  0 failed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 844015] Review Request: mate-conf - A process-transparent configuration system

2012-07-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=844015

--- Comment #1 from raveit65  ---
This is my first package for fedora and i need a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review