[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Fedora Update System changed: What|Removed |Added Fixed In Version||ilbc-1.1.1-4.el7 --- Comment #24 from Fedora Update System --- ilbc-1.1.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #23 from Fedora Update System --- ilbc-1.1.1-4.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ilbc-1.1.1-4.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #22 from Fedora Update System --- ilbc-1.1.1-3.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Fedora Update System changed: What|Removed |Added Resolution|RAWHIDE |ERRATA --- Comment #21 from Fedora Update System --- ilbc-1.1.1-3.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Peter Lemenkov changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |RAWHIDE Last Closed||2012-09-13 07:16:44 --- Comment #20 from Peter Lemenkov --- (In reply to comment #19) > You should mark this BZ as CLOSED/NEXTRELEASE rather than having Bodhi mark > it as modified since it's not a bug fix. Ok, I'm closing this as CLOSED/RAWHIDE (it's available in Rawhide now). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #19 from Darryl L. Pierce --- You should mark this BZ as CLOSED/NEXTRELEASE rather than having Bodhi mark it as modified since it's not a bug fix. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #18 from Fedora Update System --- ilbc-1.1.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ilbc-1.1.1-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #17 from Fedora Update System --- ilbc-1.1.1-3.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/ilbc-1.1.1-3.el5 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #16 from Fedora Update System --- ilbc-1.1.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ilbc-1.1.1-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #15 from Fedora Update System --- ilbc-1.1.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ilbc-1.1.1-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #14 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Peter Lemenkov changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Peter Lemenkov --- (In reply to comment #12) > (In reply to comment #11) > > Added COPYING and README as %doc > > > > * http://peter.fedorapeople.org/ilbc.spec > > * http://peter.fedorapeople.org/ilbc-1.1.1-3.fc19.src.rpm > > Very good. APPROVED! Thanks! New Package SCM Request === Package Name: ilbc Short Description: Internet Low Bitrate Codec Owners: peter Branches: f17 f18 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Darryl L. Pierce changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #12 from Darryl L. Pierce --- (In reply to comment #11) > Added COPYING and README as %doc > > * http://peter.fedorapeople.org/ilbc.spec > * http://peter.fedorapeople.org/ilbc-1.1.1-3.fc19.src.rpm Very good. APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #11 from Peter Lemenkov --- Added COPYING and README as %doc * http://peter.fedorapeople.org/ilbc.spec * http://peter.fedorapeople.org/ilbc-1.1.1-3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221
--- Comment #10 from Darryl L. Pierce ---
LEGEND: X=Met, !=Not met, ?=Not a blocker but should be fixed
=
[X] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.[1]
mcpierce@mcpierce-laptop:review $ rpmlint ilbc*rpm
ilbc.src: W: spelling-error %description -l en_US codec -> codex, code, codes
ilbc.src: W: spelling-error %description -l en_US kbit -> knit, kit, bit
ilbc.src: W: spelling-error %description -l en_US kbps -> bps, kips, k bps
ilbc.src: W: no-url-tag
ilbc.src: W: invalid-url Source0:
dekkers-libilbc-upstream-1.1.1-9-g88cd161.tar.gz
ilbc.x86_64: W: spelling-error %description -l en_US codec -> codex, code,
codes
ilbc.x86_64: W: spelling-error %description -l en_US kbit -> knit, kit, bit
ilbc.x86_64: W: spelling-error %description -l en_US kbps -> bps, kips, k bps
ilbc.x86_64: W: no-url-tag
ilbc.x86_64: W: no-documentation
ilbc-debuginfo.x86_64: W: no-url-tag
ilbc-devel.x86_64: W: summary-not-capitalized C development files for ilbc
ilbc-devel.x86_64: W: no-url-tag
ilbc-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 14 warnings.
[X] MUST: The package must be named according to the Package Naming Guidelines
.
[X] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
[X] MUST: The package must meet the Packaging Guidelines .
[X] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
[X] MUST: The License field in the package spec file must match the actual
license. [3]
[!] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.[4]
No files are marked as %doc, though the package needs to provide at least the
COPYING file and mark it as %doc
[X] MUST: The spec file must be written in American English. [5]
[X] MUST: The spec file for the package MUST be legible. [6]
[?] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
The Source0 field isn't a URL. It should point to the location where someone
could download the upstream source tarball. See the rpmlint output above.
[X] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture. [7]
[X] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[X] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
[X] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10]
[X] MUST: Packages must NOT bundle copies of system libraries.[11]
[X] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. [13]
[X] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)[14]
[X] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. [15]
[X] MUST: Each package must consistently use macros. [16]
[X] MUST: The package must contain code, or permissable content. [17]
[X] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). [18]
[X] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present. [18]
[X] MUST: Development files must be in a -devel package. [20]
[X] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} [21]
[X] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.[19]
[X] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Darryl L. Pierce changed: What|Removed |Added Status|NEW |ASSIGNED CC||dpie...@redhat.com Assignee|nob...@fedoraproject.org|dpie...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Peter Lemenkov changed: What|Removed |Added Blocks||848423 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Peter Lemenkov changed: What|Removed |Added Whiteboard|NotReady| -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #9 from Peter Lemenkov --- (In reply to comment #8) > Heads up, folks. > Unfortunately it's not 100% compatible with the old API - I'm working on > this. Stay tuned! Hello All. I added a compatibility symlinks for older apps but it seems that some of them will require manual intervention anyway (fortunately changes will be quite simple and straightforward). Here is a new package: * http://peter.fedorapeople.org/ilbc.spec * http://peter.fedorapeople.org/ilbc-1.1.1-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Peter Lemenkov changed: What|Removed |Added Whiteboard||NotReady --- Comment #8 from Peter Lemenkov --- Heads up, folks. Unfortunately it's not 100% compatible with the old API - I'm working on this. Stay tuned! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #7 from Peter Lemenkov --- (In reply to comment #5) > is this useable with asterisk ? > > I think for some reason jcollie remove ilbc from asterisk package. Should be compatible. This package contains a compatibility layer with the original version from RFCs. Please try it out. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #6 from Itamar Reis Peixoto --- ** removed. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Itamar Reis Peixoto changed: What|Removed |Added CC||ita...@ispbrasil.com.br, ||j...@ocjtech.us --- Comment #5 from Itamar Reis Peixoto --- is this useable with asterisk ? I think for some reason jcollie remove ilbc from asterisk package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #4 from Tom "spot" Callaway --- It's Google code, I'm not sure what you were expecting. ;) Anyways, I don't think any of the above items necessary preclude webrtc from going into Fedora, as long as there is a maintainer who understands all of these things and is crazy enough to still want to do it. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #3 from Peter Lemenkov --- (In reply to comment #2) > FWIW, I had to make webrtc packages for Chromium, they should be okay for > someone to maintain in Fedora, I'm just not incredibly motivated to do it by > myself (although, I'd be willing to comaintain): > > http://repos.fedorapeople.org/repos/spot/chromium/fedora-17/SRPMS/webrtc-0.1- > 0.5.20120613svn2401.fc17.src.rpm No offence but it seems that I walked much further down this road :) https://github.com/lemenkov/WebRTC/commits/autotools In fact the current state of WebRTC is awful (failed unit-tests, discrepancies in macros here ant there, impossible to build as is on PPC or Tilera, etc). I don't think we'll soon get a something ready for the consumption. After looking closely at the WebRTC I realized that WebRTC folks * doesn't do daily full rebuilds, * doesn't run unit-tests regularly * doesn't test patches for regressions before submitting. * doesn't do static analysis of their code base * doesn't use different compilers -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #2 from Tom "spot" Callaway --- FWIW, I had to make webrtc packages for Chromium, they should be okay for someone to maintain in Fedora, I'm just not incredibly motivated to do it by myself (although, I'd be willing to comaintain): http://repos.fedorapeople.org/repos/spot/chromium/fedora-17/SRPMS/webrtc-0.1-0.5.20120613svn2401.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Peter Lemenkov changed: What|Removed |Added Blocks||728302 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 Peter Lemenkov changed: What|Removed |Added Blocks||814230 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845221] Review Request: ilbc - Internet Low Bitrate Codec
https://bugzilla.redhat.com/show_bug.cgi?id=845221 --- Comment #1 from Peter Lemenkov --- Koji scratchbuild for EL5: * http://koji.fedoraproject.org/koji/taskinfo?taskID=4350138 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
