[Bug 845262] Review Request: mhwaveedit - Sound editing program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845262 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2012-11-26 06:25:11 --- Comment #12 from Jørn Lomax northlo...@gmail.com --- Yes -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845262 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Resolution|NOTABUG |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #11 from Volker Fröhlich volke...@gmx.at --- Jørn, can we close this ticket? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #7 from Jørn Lomax northlo...@gmail.com --- New Package SCM Request === Package Name: mhwaveedit Short Description: graphical sound editor Owners: jvlomax Branches: f17 f16 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #8 from Volker Fröhlich volke...@gmx.at --- You forgot to set the flag. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #9 from Jørn Lomax northlo...@gmail.com --- Ooops. Thanks. I was a bit rushed :) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 Jørn Lomax northlo...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). Added f18. Volker, please take ownership of review BZs, thanks! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added Assignee|nob...@fedoraproject.org|volke...@gmx.at -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262
Volker Fröhlich volke...@gmx.at changed:
What|Removed |Added
QA Contact|extras...@fedoraproject.org |volke...@gmx.at
Flags||fedora-review+
--- Comment #6 from Volker Fröhlich volke...@gmx.at ---
==APPROVED==
The encoding conversions belongs in the prep section.
It seems to me, there is no need to install the icon to
%{_datadir}/icons/hicolor. If I'm right, please drop it and the requirement for
hicolor-icon-theme and the scriptlets.
I think the summary and description could be better. Please take a look at the
description on http://gna.org/projects/mhwaveedit.
You could try to preserve the timestamp of AUTHORS, as its content didn't
change. Something like this would do: touch -r COPYING AUTHORS
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Package installs a %{name}.desktop using desktop-file-install if
there is such a file.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v2 or later) GENERATED FILE, *No copyright* UNKNOWN, *No
copyright* GENERATED FILE, GPL (v2 or later), LGPL (with incorrect
FSF address) For detailed output of licensecheck see file:
/home/makerpm/845262-mhwaveedit/licensecheck.txt
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #3 from Jørn Lomax northlo...@gmail.com --- Sorry for the delay, here are the Updated URLS: SPEC URL: http://jvlomax.fedorapeople.org/packaging/mhwaveedit.spec SRPM URL:http://jvlomax.fedorapeople.org/packaging/mhwaveedit-1.4.22-2.fc17.src.rpm rpmlint output: [makerpm@Fafnir SPECS]$ rpmlint mhwaveedit mhwaveedit.i686: E: incorrect-fsf-address /usr/share/doc/mhwaveedit-1.4.22/COPYING mhwaveedit.i686: W: file-not-utf8 /usr/share/doc/mhwaveedit-1.4.22/AUTHORS 1 packages and 0 specfiles checked; 1 errors, 1 warnings. [makerpm@Fafnir SPECS]$ rpmlint ../SRPMS/mhwaveedit-1.4.22-2.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #4 from Volker Fröhlich volke...@gmx.at --- Please correct these two issues. The latter is a must. https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address https://fedoraproject.org/wiki/Common_Rpmlint_issues#file-not-utf8 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 --- Comment #5 from Jørn Lomax northlo...@gmail.com --- Forgot to comment that i have contacted upstream about incorrect fsf address. Updated fileS: SPEC URL: http://jvlomax.fedorapeople.org/packaging/mhwaveedit.spec SPRMS URL: http://jvlomax.fedorapeople.org/packaging/mhwaveedit-1.4.22-3.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262
--- Comment #2 from Volker Fröhlich volke...@gmx.at ---
%{_mandir}/man1/%{name}.1.gz should rather be %{_mandir}/man1/%{name}.1*, as
the compression method might change.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845262] Review Request: mhwaveedit - Sound editing program
https://bugzilla.redhat.com/show_bug.cgi?id=845262 Volker Fröhlich volke...@gmx.at changed: What|Removed |Added CC||volke...@gmx.at --- Comment #1 from Volker Fröhlich volke...@gmx.at --- [makerpm@desktop SPECS]$ rpmlint /home/makerpm/rpmbuild/SRPMS/mhwaveedit-1.4.22-1.fc16.src.rpm /home/makerpm/rpmbuild/RPMS/x86_64/mhwaveedit-1.4.22-1.fc16.x86_64.rpm /home/makerpm/rpmbuild/RPMS/x86_64/mhwaveedit-debuginfo-1.4.22-1.fc16.x86_64.rpm mhwaveedit.x86_64: E: incorrect-fsf-address /usr/share/doc/mhwaveedit-1.4.22/COPYING mhwaveedit.x86_64: W: file-not-utf8 /usr/share/doc/mhwaveedit-1.4.22/AUTHORS I'd personally shorten the description. The license is more accurately described in the package's metadata and the URL is there as well. You might consider to ship BUGS, NEWS, TODO, HACKING and ChangeLog. Besides that, it looks perfect. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
