[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-13 04:01:52 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540
Marek Goldmann mgold...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mgold...@redhat.com
Assignee|nob...@fedoraproject.org|mgold...@redhat.com
Flags||fedora-review?
--- Comment #2 from Marek Goldmann mgold...@redhat.com ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
== Issues ==
1. Please repackage the Source0 and remove all binary files like .class
2. Use LGPLv2+ as license.
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[-]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[!]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Fully versioned dependency in subpackages, if present.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
javadoc
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (with incorrect FSF address), *No copyright* LGPL (with incorrect
FSF address), Unknown or generated. 3 files have unknown license.
Detailed output of licensecheck in
/home/goldmann/tmp/815060-classmate/845540-xapool/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build
Note: Test run failed
Maven:
[x]: Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: Old add_to_maven_depmap macro is not being used
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 --- Comment #3 from gil cattaneo punto...@libero.it --- Spec URL: http://gil.fedorapeople.org/xapool/1/xapool.spec SRPM URL: http://gil.fedorapeople.org/xapool/1/xapool-1.5.0-2.fc16.src.rpm - fix license tag - repackaged Source0 and removed all binary files -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #4 from Marek Goldmann mgold...@redhat.com --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 gil cattaneo punto...@libero.it changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from gil cattaneo punto...@libero.it --- New Package SCM Request === Package Name: xapool Short Description: Open source XA JDBC Pool Owners: gil Branches: f17 f18 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- xapool-1.5.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/xapool-1.5.0-2.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- xapool-1.5.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xapool-1.5.0-2.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- xapool-1.5.0-2.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||852330 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845540] Review Request: xapool - open source XA JDBC Pool
https://bugzilla.redhat.com/show_bug.cgi?id=845540 --- Comment #1 from gil cattaneo punto...@libero.it --- xapool is a BR for hibenate-testing 4.x. hibenate-testing is required to perform tests -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
