[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Tobias Florek m...@ibotty.net changed: What|Removed |Added CC||m...@ibotty.net --- Comment #15 from Tobias Florek m...@ibotty.net --- *** Bug 860316 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-27 18:56:12 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- adobe-source-sans-pro-fonts-1.033-3.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- adobe-source-sans-pro-fonts-1.033-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/adobe-source-sans-pro-fonts-1.033-3.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- adobe-source-sans-pro-fonts-1.033-3.fc16 has been pushed to the Fedora 16 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 --- Comment #10 from Lameire Alexis alexisis-pristont...@hotmail.com --- New Package SCM Request === Package Name: adobe-source-sans-pro-fonts Short Description: A set of OpenType fonts designed for user interfaces Owners: alexises Branches: f16 f17 f18 InitialCC: fonts-sig -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Lameire Alexis alexisis-pristont...@hotmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 --- Comment #8 from Lameire Alexis alexisis-pristont...@hotmail.com --- I've fixed it : SPEC : http://alexises.fedorapeople.org/adobe-source-sans-pro-fonts/1.033-3/adobe-source-sans-pro-fonts.spec SRPM : http://alexises.fedorapeople.org/adobe-source-sans-pro-fonts/1.033-3/adobe-source-sans-pro-fonts-1.033-3.fc17.src.rpm RPM : http://alexises.fedorapeople.org/adobe-source-sans-pro-fonts/1.033-3/adobe-source-sans-pro-fonts-1.033-3.fc17.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Mohamed El Morabity pikachu.2...@gmail.com --- APPROVED! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 --- Comment #6 from Sandro Mathys s...@sandro-mathys.ch --- (In reply to comment #2) Alexis, your spec file looks good at a first glance but when I install the package the font is not shown in libreoffice writer (it's shown in the KDE Font Manager though). Any idea about this? I tried packaging the font last Friday myself and ended up with the same issue, too. Strange, the fonts are now shown in Libreoffice. Can't remember doing anything that could have helped except applying updates and then rebooting. (In reply to comment #4) I will review this package. What's stopping you? :) We're waiting ;) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743
Mohamed El Morabity pikachu.2...@gmail.com changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #7 from Mohamed El Morabity pikachu.2...@gmail.com ---
Here is at last the review :)
The package looks quite good, and complies with the font guidelines. The
fontconfig file is OK for me, and the fonts are available in the system once
the package installed, even in LibreOffice.
Anyway, I wouldn't include the README.html file, which seems useless to me: it
contains installation intructions, useless with a RPM, and only for Windows and
Mac OS X. It contains also some generic notice for all the fonts sold by Adobe.
As a result, I suggest you to drop this file.
Once this file removed, I will approve your package.
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[-]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[-]: MUST Development files must be in a -devel package
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[-]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #5 from Rex Dieter rdie...@math.unl.edu --- if reviewing, please set fedora‑review flag to ? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||pikachu.2...@gmail.com Assignee|nob...@fedoraproject.org|pikachu.2...@gmail.com --- Comment #4 from Mohamed El Morabity pikachu.2...@gmail.com --- I will review this package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Lameire Alexis alexisis-pristont...@hotmail.com changed: What|Removed |Added Blocks||182235 (FE-Legal) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Lameire Alexis alexisis-pristont...@hotmail.com changed: What|Removed |Added Blocks|182235 (FE-Legal) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 Sandro Mathys s...@sandro-mathys.ch changed: What|Removed |Added CC||s...@sandro-mathys.ch --- Comment #2 from Sandro Mathys s...@sandro-mathys.ch --- Alexis, your spec file looks good at a first glance but when I install the package the font is not shown in libreoffice writer (it's shown in the KDE Font Manager though). Any idea about this? I tried packaging the font last Friday myself and ended up with the same issue, too. Note: not assigning the review to myself just now as I might or might not have time to do it later on. Anyone else is welcome to take over instead. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 --- Comment #3 from Lameire Alexis alexisis-pristont...@hotmail.com --- Strange, I actualy use it as principale system font. It's should that libreoffice have is own font system. I look about this. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 845743] Review Request: adobe-source-sans-pro-fonts - A set of OpenType fonts designed for user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=845743 --- Comment #1 from Lameire Alexis alexisis-pristont...@hotmail.com --- the upstream release new versionned archive, I have update ma spec according this new source : SPEC : http://alexises.fedorapeople.org/adobe-source-sans-pro-fonts/1.033-2/adobe-source-sans-pro-fonts.spec SRPM : http://alexises.fedorapeople.org/adobe-source-sans-pro-fonts/1.033-2/adobe-source-sans-pro-fonts-1.033-2.fc17.src.rpm RPM : http://alexises.fedorapeople.org/adobe-source-sans-pro-fonts/1.033-2/adobe-source-sans-pro-fonts-1.033-2.fc17.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
