[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-09-17 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #17 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.fc18 has been pushed to the Fedora 18 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-31 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #16 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-24 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2012-08-24 22:56:01

--- Comment #14 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.fc17 has been pushed to the Fedora 17 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-24 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #15 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.fc16 has been pushed to the Fedora 16 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #4 from Miroslav Suchý msu...@redhat.com ---
 - Is there any benefit of moving the various doc files in %install section? 
 The
 optimal solution, I think, is to leave them in %{gem_instdir} and mark them as
 %doc there.

It is good habbit on every other package but rubygems. Location is not mandated
by guidelines. I already opened discussion about it on packaging mailing lists.

 Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3,
 LICENSE) in the main package and move the others to the -doc subpackage.

So you mean just copy README.rdoc, to -doc package? ok.

 It is customary to exclude cached gem in the RPM packaged gems, please do so.

done

 %{gem_docdir} should be marked as %doc.

done

Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk.spec
SRPM URL:
http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk-1.0.3-3.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #5 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
(In reply to comment #4)
  - Is there any benefit of moving the various doc files in %install section? 
  The
  optimal solution, I think, is to leave them in %{gem_instdir} and mark them 
  as
  %doc there.
 
 It is good habbit on every other package but rubygems. Location is not
 mandated by guidelines. I already opened discussion about it on packaging
 mailing lists.
 

I don't see any such discussion, would you care to post a link here?

  Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3,
  LICENSE) in the main package and move the others to the -doc subpackage.
 
 So you mean just copy README.rdoc, to -doc package? ok.
 

I also meant CHANGELOG :) Please move that before importing to dist-git, too.

  It is customary to exclude cached gem in the RPM packaged gems, please do 
  so.
 
 done
 
  %{gem_docdir} should be marked as %doc.
 
 done
 
 Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk.spec
 SRPM URL:
 http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk-1.0.3-3.fc17.
 src.rpm


The package looks good now. Please move the CHANGELOG file to -doc subpackage,
as mentioned above, before importing to dist-git. This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #6 from Miroslav Suchý msu...@redhat.com ---
 I don't see any such discussion, would you care to post a link here?

http://lists.fedoraproject.org/pipermail/packaging/2012-August/008598.html

 I also meant CHANGELOG :) Please move that before importing to dist-git, too.

Will do.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #7 from Miroslav Suchý msu...@redhat.com ---
New Package SCM Request
===
Package Name: rubygem-ttfunk
Short Description: Font Metrics Parser for Prawn
Owners: msuchy
Branches: F-18, F-17, F-16, EL-6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #8 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #9 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.fc16

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.fc17

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-16 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #13 from Fedora Update System upda...@fedoraproject.org ---
rubygem-ttfunk-1.0.3-4.fc18 has been pushed to the Fedora 18 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

Bohuslav Slavek Kabrda bkab...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||bkab...@redhat.com
   Assignee|nob...@fedoraproject.org|bkab...@redhat.com
  Flags||fedora-review?

--- Comment #2 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
I'll take it for a review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-15 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

--- Comment #3 from Bohuslav Slavek Kabrda bkab...@redhat.com ---
- Is there any benefit of moving the various doc files in %install section? The
optimal solution, I think, is to leave them in %{gem_instdir} and mark them as
%doc there.
- Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3,
LICENSE) in the main package and move the others to the -doc subpackage.
- It is customary to exclude cached gem in the RPM packaged gems, please do so.
- %{gem_docdir} should be marked as %doc.

Otherwise the package looks good, so please fix these and post updated
SPEC/SRPM so I can take one more look and approve it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 845805] Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn

2012-08-09 Thread bugzilla 
https://bugzilla.redhat.com/show_bug.cgi?id=845805

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

  Alias||rubygem-ttfunk

--- Comment #1 from Miroslav Suchý msu...@redhat.com ---
Updated:
Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk.spec
SRPM URL:
http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk-1.0.3-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review