[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-editdist-0.3-4.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-21 05:57:52 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-editdist-0.3-4.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|RELEASE_PENDING |ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-editdist-0.3-4.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- python-editdist-0.3-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-editdist-0.3-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-editdist-0.3-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-editdist-0.3-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Paul Wouters pwout...@redhat.com changed: What|Removed |Added Status|MODIFIED|RELEASE_PENDING -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||puiterw...@gmail.com Flags||fedora-review? --- Comment #1 from Patrick Uiterwijk puiterw...@gmail.com --- I will review this one. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|puiterw...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879
--- Comment #2 from Patrick Uiterwijk puiterw...@gmail.com ---
The first things I notice when looking at it (formal review will come later
today):
1. You use both %{version} and $RPM_BUILD_ROOT, so inconsistent variable style
usage.
2. The first changelog entry (* Wed Jul 05 2006 Damien Miller
d...@mindrot.org) is not in the correct format: it is missing the version
number.
3. The Url field should be in complete capitals, so URL.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #3 from Patrick Uiterwijk puiterw...@gmail.com --- The last thing I noted is that the license file seems more like the ISC license then BSD. Also the license headers in the files seem like ISC to me. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Patrick Uiterwijk puiterw...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Patrick Uiterwijk puiterw...@gmail.com --- Except for those things, I can't find any problems with that. I trust you will fix these issues before pushing, so this package is APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #5 from Paul Wouters pwout...@redhat.com --- Spec URL: ftp://ftp.nohats.ca/python-editdist/python-editdist.spec SRPM URL: ftp://ftp.nohats.ca/python-editdist/python-editdist-0.3-3.src.rpm * Thu Aug 09 2012 Paul Wouters pwout...@redhat.com - 0.3-3 - Fix mixed macros, license, changelog and url fields -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879
--- Comment #6 from Paul Wouters pwout...@redhat.com ---
Here is the fedora-review output for reference
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
C/C++
[x]: MUST Package does not contain any libtool archives (.la)
[ ]: MUST Package does not contain kernel modules.
[ ]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[ ]: MUST Development (unversioned) .so files in -devel subpackage, if
present.
Note: Unversioned so-files in non-devel package (fix or explain):python-
editdist-0.3-3.x86_64.rpm : /usr/lib64/python2.7/site-
packages/editdist.so
Generic
[x]: EXTRA Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: EXTRA Spec file according to URL is the same as in SRPM.
[ ]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[ ]: MUST Package contains no bundled libraries.
[ ]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[ ]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
[ ]: MUST Package contains desktop file if it is a GUI application.
[ ]: MUST Development files must be in a -devel package
[ ]: MUST Package requires other packages for directories it uses.
[ ]: MUST Package uses nothing in %doc for runtime.
[ ]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[ ]: MUST Package complies to the Packaging Guidelines
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[ ]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[ ]: MUST License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
ISC For detailed output of licensecheck see file: /vol/home/paul/846879
-python-editdist/licensecheck.txt
[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
names).
[x]: MUST Package is named using only allowed ascii characters.
[ ]: MUST Package is named according to the Package Naming Guidelines.
[ ]: MUST Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
[ ]: MUST Package must own all directories that it creates.
[ ]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[ ]: MUST Package is not relocatable.
[ ]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
[ ]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[ ]: MUST Package contains systemd file(s) if in need.
[x]: MUST File names are valid UTF-8.
[ ]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[ ]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[!]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[ ]: SHOULD Package functions as described.
[ ]: SHOULD Latest version is packaged.
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 Paul Wouters pwout...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Paul Wouters pwout...@redhat.com --- I'll add the missing dist tag in the initial package New Package SCM Request === Package Name: python-editdist Short Description: editdist is a CPython module that calculates the Levenshtein edit distance between two strings. Owners: pwouters Branches: f18, f17, el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #8 from Paul Wouters pwout...@redhat.com --- For completeness sake: * Thu Aug 09 2012 Paul Wouters pwout...@redhat.com - 0.3-4 - Added dist tag - Added check section. Spec URL: ftp://ftp.nohats.ca/python-editdist/python-editdist.spec SRPM URL: ftp://ftp.nohats.ca/python-editdist/python-editdist-0.3-4.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 846879] Review Request: python-editdist - CPython module to quickly calculate Levenshtein's edit distance
https://bugzilla.redhat.com/show_bug.cgi?id=846879 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
