[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- mate-backgrounds-1.4.0-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- mate-backgrounds-1.4.0-1.fc16 has been pushed to the Fedora 16 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-08-22 17:06:16 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- mate-backgrounds-1.4.0-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- mate-backgrounds-1.4.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-backgrounds-1.4.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- mate-backgrounds-1.4.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-backgrounds-1.4.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- mate-backgrounds-1.4.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mate-backgrounds-1.4.0-1.fc16 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- mate-backgrounds-1.4.0-1.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697
--- Comment #4 from Wolfgang Ulbrich chat-to...@raveit.de ---
missing requrires:
Requires: desktop-backgrounds-compat
and for f17 if you really want to build for F16/f17
Requires: beefy-miracle-backgrounds-single
Requires: beefy-miracle-backgrounds-gnome
For f18 you need the new background packages.
Your package install the backgrounds in
%{_datadir}/pixmaps/backgrounds/mate/
but fedora use in general a own background path
%{_datadir}/backgrounds/mate/
IMO you have to fix this in a patch, i can send you this patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #5 from Dan Mashal dan.mas...@gmail.com --- MATE uses its own background. I'm not sure that I want to use Fedora's background. We'll discuss offline. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697
--- Comment #6 from Rex Dieter rdie...@math.unl.edu ---
I too don't understand the need for the dependency changes in Comment #4,
please explain and provide the justification for doing so.
except for %{_datadir}/pixmaps/backgrounds/mate/, which is something I
mentioned in the review, item 3
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697
--- Comment #7 from Wolfgang Ulbrich chat-to...@raveit.de ---
(In reply to comment #6)
I too don't understand the need for the dependency changes in Comment #4,
please explain and provide the justification for doing so.
except for %{_datadir}/pixmaps/backgrounds/mate/, which is something I
mentioned in the review, item 3
@ Requires: desktop-backgrounds-compat
root@mother rave]# rpm -ql desktop-backgrounds-compat
/usr/share/backgrounds/default.png
/usr/share/backgrounds/images/default-16_10.png
/usr/share/backgrounds/images/default-5_4.png
/usr/share/backgrounds/images/default.png
Without this require we have no /usr/share/backgrounds/default.png
I think nobody wants that.
For get this working we need also the other requires, because 'default.png' is
a symlink to current fedora bckground image.
for f16
[root@mother rave]# ls -l /usr/share/backgrounds/default.png
lrwxrwxrwx 1 root root 40 8. Feb 2012 /usr/share/backgrounds/default.png -
verne/default/standard/verne.png
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #8 from Rex Dieter rdie...@math.unl.edu --- the handling of desktop-backgrounds-compat would best be handled elsewhere, particularly when/if you offer a default configuration that actually uses these. For example, for kde, we provide a kde-settings package that does that. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #9 from Wolfgang Ulbrich chat-to...@raveit.de --- Which background image Mate-Desktop use in the end is handled by a mateconf key from libmate. I can add those requires in libmate , np -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #10 from Rex Dieter rdie...@math.unl.edu --- like I said, my suggestion would be to put branding/configuration defaults elsewhere, preferably in a separate package. one advantage in doing so is that it makes it easier for others to customize and change that way, but I'll leave the ultimate decision and implementation up to you mate maintainers. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #1 from Rex Dieter rdie...@math.unl.edu --- I can review -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697
Rex Dieter rdie...@math.unl.edu changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter rdie...@math.unl.edu ---
naming: ok
sources: ok
$ md5sum *.xz
225a2ce7672c2a236c3b7d01da95af5a mate-backgrounds-1.4.0.tar.xz
licensing
1 SHOULD remove
BuildRequires: mate-conf-devel mate-corba-devel
these aren't needed (builds ok for me without these)
macros: mostly ok, except for:
2. SHOULD not use undefined macro po_package, change
%find_lang %{po_package} --all-name
...
%files -f %{po_package}.lang
to
%find_lang %{name} --all-name
...
%files -f %{name}.lang
3. SHOULD: dir /usr/share/pixmaps/backgrounds seems unowned. mind either
owning this here too, or consider if it's possible to move
/usr/share/pixmaps/backgrounds/mate
to
/usr/share/backgrounds/mate
to be closer to how gnome does things? (fwiw, kde uses /usr/share/wallpapers)
scriptlets: ok (n/a)
fairly good and simple, APPROVED.
please address items 1-3 prior to doing any builds.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Dan Mashal dan.mas...@gmail.com --- New Package SCM Request === Package Name: mate-backgrounds Short Description: Backgrounds for MATE Desktop Owners: vicodan raveit65 rdieter Branches: f16 f17 f18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847697] Review Request: mate-backgrounds - Backgrounds for MATE Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=847697 Dan Mashal dan.mas...@gmail.com changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||840149 (MATE-DE-tracker) Alias||mate-backgrounds -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
