[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2012-09-17 18:43:51 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- gstreamer1-0.11.93-1.fc18, gstreamer1-plugins-bad-free-0.11.93-2.fc18, gstreamer1-plugins-base-0.11.93-1.fc18, gstreamer1-plugins-good-0.11.93-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Bastien Nocera bnoc...@redhat.com changed: What|Removed |Added Flags||fedora-review+ --- Comment #5 from Bastien Nocera bnoc...@redhat.com --- All the comments fixed. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Bastien Nocera bnoc...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Brian Pepple bdpep...@gmail.com --- New Package SCM Request === Package Name: gstreamer1-plugins-bad-free Short Description: GStreamer streaming media framework bad plugins Owners: bpepple Branches: f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- gstreamer1-0.11.93-1.fc18, gstreamer1-plugins-bad-free-0.11.93-2.fc18, gstreamer1-plugins-base-0.11.93-1.fc18, gstreamer1-plugins-good-0.11.93-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-11899/gstreamer1-plugins-bad-free-0.11.93-2.fc18,gstreamer1-plugins-good-0.11.93-1.fc18,gstreamer1-plugins-base-0.11.93-1.fc18,gstreamer1-0.11.93-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- Package gstreamer1-0.11.93-1.fc18, gstreamer1-plugins-bad-free-0.11.93-2.fc18, gstreamer1-plugins-base-0.11.93-1.fc18, gstreamer1-plugins-good-0.11.93-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing gstreamer1-0.11.93-1.fc18 gstreamer1-plugins-bad-free-0.11.93-2.fc18 gstreamer1-plugins-base-0.11.93-1.fc18 gstreamer1-plugins-good-0.11.93-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-11899/gstreamer1-plugins-bad-free-0.11.93-2.fc18,gstreamer1-plugins-good-0.11.93-1.fc18,gstreamer1-plugins-base-0.11.93-1.fc18,gstreamer1-0.11.93-1.fc18 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 --- Comment #4 from Brian Pepple bdpep...@gmail.com --- Spec URL: http://bpepple.fedorapeople.org/rpms/gstreamer1-plugins-bad-free.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/gstreamer1-plugins-bad-free-0.11.93-2.fc17.src.rpm * Sat Aug 18 2012 Brian Pepple bpep...@fedoraproject.org - 0.11.93-2 - Fix permission on tarball clean-up script. - Re-enable soundtouch-devel. - Add COPYING.LIB to package. - Use %%global instead of %%define. Upstream Bug fix fsf addy: http://bugzilla.gnome.org/show_bug.cgi?id=681952 Upstream Bug fixing tarball warnings: http://bugzilla.gnome.org/show_bug.cgi?id=682158 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755
Bastien Nocera bnoc...@redhat.com changed:
What|Removed |Added
CC||bnoc...@redhat.com
Assignee|nob...@fedoraproject.org|bnoc...@redhat.com
--- Comment #3 from Bastien Nocera bnoc...@redhat.com ---
Package Review
==
Key:
- = N/A
x = Pass
! = Fail
C/C++
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Development (unversioned) .so files in -devel subpackage, if present.
Generic
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot}
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm 4.4
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package contains desktop file if it is a GUI application.
[x]: MUST Development files must be in a -devel package
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST The spec file handles locales properly.
[x]: MUST Package consistently uses macro.
[x]: MUST Package is named using only allowed ascii characters.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Package is not relocatable.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint is run on all rpms the build produces.
gstreamer1-plugins-bad-free.src: W: spelling-error Summary(en_US) GStreamer -
G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.src: W: spelling-error %description -l en_US
GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.src: W: strange-permission gst-p-bad-cleanup.sh
0775L
Make that 755 instead.
gstreamer1-plugins-bad-free.src:18: W: macro-in-comment %{version}
gstreamer1-plugins-bad-free.src: W: invalid-url Source0:
gst-plugins-bad-free-0.11.93.tar.xz
gstreamer1-plugins-bad-free.x86_64: W: spelling-error Summary(en_US) GStreamer
- G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.x86_64: W: spelling-error %description -l en_US
GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/gstreamer-1.0/libgstvideoparsersbad.so ['/usr/lib64']
gstreamer1-plugins-bad-free.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/gstreamer-1.0/libgstcamerabin2.so ['/usr/lib64']
A couple of rpaths see:
https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath
gstreamer1-plugins-bad-free.x86_64: E: incorrect-fsf-address
/usr/share/doc/gstreamer1-plugins-bad-free-0.11.93/COPYING
Please file a bug
gstreamer1-plugins-bad-free-devel.x86_64: W: spelling-error %description -l
en_US GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free-extras.x86_64: W: spelling-error %description -l
en_US GStreamer - G Streamer, Streamer, Steamer
gstreamer1-plugins-bad-free-extras.x86_64: W: spelling-error %description -l
en_US gstreamer - streamer, g streamer, steamer
gstreamer1-plugins-bad-free-extras.x86_64: W:
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added External Bug ID||GNOME Desktop 682158 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added External Bug ID||GNOME Desktop 681962 --- Comment #1 from Brian Pepple bdpep...@gmail.com --- Spec URL: http://bpepple.fedorapeople.org/rpms/gstreamer1-plugins-bad-free.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/gstreamer1-plugins-bad-free-0.11.93-1.fc17.src.rpm * Wed Aug 15 2012 Brian Pepple bpep...@fedoraproject.org - 0.11.93-1 - Update to 0.11.93. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added External Bug ID|GNOME Desktop 681962| -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added External Bug ID||GNOME Desktop 681952 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 --- Comment #2 from Brian Pepple bdpep...@gmail.com --- Forgot to add a link to a scratch build for this: http://koji.fedoraproject.org/koji/taskinfo?taskID=4394360 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847755] Review Request: gstreamer1-plugins-bad-free - GStreamer streaming media framework bad plugins
https://bugzilla.redhat.com/show_bug.cgi?id=847755 Brian Pepple bdpep...@gmail.com changed: What|Removed |Added Depends On||841243 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
