[Bug 847811] Review Request: libee - An event expression library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847811 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ON_QA |CLOSED CC||lemen...@gmail.com Resolution|--- |ERRATA Last Closed||2012-12-16 04:36:37 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dFpdibQbtja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=847811 Bug 847811 depends on bug 847817, which changed state. Bug 847817 Summary: Review Request: libestr - A library to handle strings https://bugzilla.redhat.com/show_bug.cgi?id=847817 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N9XRoJ9VZQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- libee-0.4.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/libee-0.4.1-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- libee-0.4.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/libee-0.4.1-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- libee-0.4.1-3.fc18 has been pushed to the Fedora 18 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Mahaveer Darade mah.dar...@gmail.com changed: What|Removed |Added CC||mah.dar...@gmail.com --- Comment #11 from Mahaveer Darade mah.dar...@gmail.com --- New Package SCM Request === Package Name: libee Short Description: Event expression library inspired by CEE Owners: mdarade Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Mahaveer Darade mah.dar...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #12 from Jason Tibbitts ti...@math.uh.edu --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #9 from mahaveer darade mdar...@redhat.com --- I've worked on comments by Michael Tomas. Below are the links to updated files. http://mdarade.fedorapeople.org/SPECS/libee.spec http://mdarade.fedorapeople.org/SRPMS/libee-0.4.1-4.fc15.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #10 from Tomas Mraz tm...@redhat.com --- Please do not change the COPYING file, it needs to be corrected upstream. Also the package is already ACCEPTED, so please follow the packaging process to build it into Fedora. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||tm...@redhat.com Assignee|nob...@fedoraproject.org|tm...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? | Flags||fedora-review+ --- Comment #7 from Tomas Mraz tm...@redhat.com --- I think the license tag is wrong - it should be probably either LGPLv2+ and MIT or LGPLv2+ alone. The statement at the beginning of COPYING file is probably an upstream mistake as the full text of the license is LGPL2.1 and not GPL. Please correct the licence tag and notify upstream about the mistake. I will approve the package anyway as the licence tag mistake can be fixed before import. rpmlint -v libee-0.4.1-3.fc16.src.rpm libee-0.4.1-3.fc16.x86_64.rpm libee-devel-0.4.1-3.fc16.x86_64.rpm libee-utils-0.4.1-3.fc16.x86_64.rpm libee.src: I: checking libee.src: I: checking-url http://www.libee.org (timeout 10 seconds) libee.src: I: checking-url http://www.libee.org/files/download/libee-0.4.1.tar.gz (timeout 10 seconds) libee.x86_64: I: checking libee.x86_64: I: checking-url http://www.libee.org (timeout 10 seconds) libee-devel.x86_64: I: checking libee-devel.x86_64: W: spelling-error %description -l en_US rsyslog - serology libee-devel.x86_64: I: checking-url http://www.libee.org (timeout 10 seconds) libee-devel.x86_64: W: no-documentation libee-utils.x86_64: I: checking libee-utils.x86_64: I: checking-url http://www.libee.org (timeout 10 seconds) libee-utils.x86_64: W: no-documentation libee-utils.x86_64: W: no-manual-page-for-binary libee-convert 4 packages and 0 specfiles checked; 0 errors, 4 warnings. The spelling error is not a real error. Missing documentation and manual page is upstream issue. Tarball matches the upstream sources. The package complies with Fedora packaging and licensing guidelines. The package is ACCEPTED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #8 from Michael Schwendt mschwe...@gmail.com --- I think the license tag is wrong In comment 4 I explicitly acknowledge that License: LGPLv2+ was correct. No idea why it has been changed in the newer spec file. The %changelog should have mentioned such changes to _the packaging_. That's one of the things packagers ought to practise. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Miloslav Trmač m...@redhat.com changed: What|Removed |Added CC||m...@redhat.com Component|pacemaker |Package Review -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 mahaveer darade mdar...@redhat.com changed: What|Removed |Added CC||and...@beekhof.net, ||fdini...@redhat.com, ||l...@redhat.com Component|Package Review |pacemaker --- Comment #6 from mahaveer darade mdar...@redhat.com --- I have worked on all the comments provided by Michael and here is a link to updated package. http://siddharths.fedorapeople.org/mahaveer/SPECS/libee.spec http://siddharths.fedorapeople.org/mahaveer/SRPMS/libee-0.4.1-3.fc15.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811
--- Comment #5 from Michael Schwendt mschwe...@gmail.com ---
* As noticed in the related reviews, there are inter-package dependencies
involved. libee-devel should contain
Requires: libestr-devel%{?_isa}
as headers like libee.h include libestr headers.
%build
%configure
%{__make}
Calling V=1 make for more verbose build output would be nice. For this
package, the linking stage would be affected, so a test-build was necessary to
notice this.
%{__make} install -p DESTDIR=%{buildroot}
That error is in here, too:
make install INSTALL=install -p DESTDIR=%{buildroot}
* The tests directory contains a testsuite that's suitable for running it in
a %check section in the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
CC||mschwe...@gmail.com
Depends On||847817
--- Comment #4 from Michael Schwendt mschwe...@gmail.com ---
Summary: An event expression library inspired by CEE
Not covered by any guidelines, but in many cases the leading article is
superfluous and doesn't increase conciseness.
Summary: Event expression library inspired by CEE
That makes a much better reading when displayed by Anaconda and package tools.
License: LGPLv2+
True. The majority of source files contain an LGPLv2+ preamble. Only
src/cjson/* contains merged files with an MIT-style preamble. There's a minor
typo at the top of file COPYING, which refers to GPL rather than LGPL.
Group: Development/Libraries
Base library packages still enter group System Environment/Libraries.
%description
I would rearrange the two paragraphs to begin with the explanation of what
libee does, then continue with the explanation of what CEE is.
%package devel
Summary: Include files for libee
More generally, it's
Summary: Development files for libee
because not just the header files are included.
Requires: %name = %version-%release
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
%package utils
Summary: The libee-convert utility provided by event expression library
Requires: %{name} = %{version}-%{release}
Same here.
The summary restricts the package contents to just the libee-convert utility.
It could be made more general to sum up whether these tools are optional or
strictly needed.
%{__make}
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
Plus: if you don't have a compelling reason to use a macro here, feel free to
run make from $PATH just as done with many other commands one runs in .spec
files.
%install
rm -rf %{buildroot}
It will be automatically cleaned:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Blocks||848388 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 --- Comment #3 from mahaveer darade mdar...@redhat.com --- Done. I have worked on all 3 suggestions and changes are in-place. Below is new SRPM link: http://siddharths.fedorapeople.org/mahaveer/SRPMS/libee-0.4.1-2.fc15.src.rpm Below are new rpmlint logs. [root@mdarade guest]# rpmlint -i libee.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i libee-0.4.1-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i libee-*.x86_64.rpm libee-devel.x86_64: W: spelling-error %description -l en_US rsyslog - serology The value of this tag appears to be misspelled. Please double-check. libee-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libee-utils.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. libee-utils.x86_64: W: no-manual-page-for-binary libee-convert Each executable in standard binary directories should have a man page. 4 packages and 0 specfiles checked; 0 errors, 4 warnings. [root@mdarade guest]# -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811
Milan Bartos mbar...@redhat.com changed:
What|Removed |Added
CC||mbar...@redhat.com
--- Comment #2 from Milan Bartos mbar...@redhat.com ---
Hi, this is just an informational review.
1. use macros and variables consistently
2. %clean is not necessary
3. i'm not sure about %{_sbindir}/libee-convert, it could go in separate -utils
package
Regards,
Milan
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Flags|fedora-review? | --- Comment #1 from Jason Tibbitts ti...@math.uh.edu --- If you set fedora-review, nobody will see your tickets. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847811] Review Request: libee - An event expression library
https://bugzilla.redhat.com/show_bug.cgi?id=847811 mahaveer darade mdar...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
