[Bug 848388] Review Request: liblognorm - Tool to normalize log data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848388 Bug 848388 depends on bug 847811, which changed state. Bug 847811 Summary: Review Request: libee - An event expression library https://bugzilla.redhat.com/show_bug.cgi?id=847811 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YT7S0uctbDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848388 Bug 848388 depends on bug 847817, which changed state. Bug 847817 Summary: Review Request: libestr - A library to handle strings https://bugzilla.redhat.com/show_bug.cgi?id=847817 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LOurcO0lHSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848388 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-14 21:38:31 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- liblognorm-0.3.4-4.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- liblognorm-0.3.4-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/liblognorm-0.3.4-4.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #17 from Fedora Update System upda...@fedoraproject.org --- liblognorm-0.3.4-4.fc17 has been pushed to the Fedora 17 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #16 from Fedora Update System upda...@fedoraproject.org --- liblognorm-0.3.4-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/liblognorm-0.3.4-4.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|tm...@redhat.com Flags||fedora-review+ --- Comment #13 from Tomas Mraz tm...@redhat.com --- Reverting the accidental changes. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Mahaveer Darade mah.dar...@gmail.com changed: What|Removed |Added CC||mah.dar...@gmail.com --- Comment #14 from Mahaveer Darade mah.dar...@gmail.com --- New Package SCM Request === Package Name: liblognorm Short Description: Fast samples-based log normalization library Owners: mdarade Branches: f17 f18 InitialCC: mbartos -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Mahaveer Darade mah.dar...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #15 from Jason Tibbitts ti...@math.uh.edu --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #9 from mahaveer darade mdar...@redhat.com --- I've worked on comments provided by Tomas Michael. Below is a link to updated package. http://mdarade.fedorapeople.org/SPECS/liblognorm.spec http://mdarade.fedorapeople.org/SRPMS/liblognorm-0.3.4-4.fc15.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|tm...@redhat.com Flags||fedora-review+ --- Comment #10 from Tomas Mraz tm...@redhat.com --- Please do not change the COPYING file, it needs to be corrected upstream. You can correct this mistake before you import the package into Fedora git. rpmlint -v liblognorm-0.3.4-4.fc16.src.rpm liblognorm-0.3.4-4.fc16.x86_64.rpm liblognorm-devel-0.3.4-4.fc16.x86_64.rpm liblognorm-utils-0.3.4-4.fc16.x86_64.rpm liblognorm-debuginfo-0.3.4-4.fc16.x86_64.rpm liblognorm.src: I: checking liblognorm.src: I: checking-url http://www.liblognorm.com (timeout 10 seconds) liblognorm.src: I: checking-url http://www.liblognorm.com/files/download/liblognorm-0.3.4.tar.gz (timeout 10 seconds) liblognorm.x86_64: I: checking liblognorm.x86_64: I: checking-url http://www.liblognorm.com (timeout 10 seconds) liblognorm-devel.x86_64: I: checking liblognorm-devel.x86_64: I: checking-url http://www.liblognorm.com (timeout 10 seconds) liblognorm-devel.x86_64: W: no-documentation liblognorm-utils.x86_64: I: checking liblognorm-utils.x86_64: W: spelling-error Summary(en_US) Lognormalizer - Normalize liblognorm-utils.x86_64: I: checking-url http://www.liblognorm.com (timeout 10 seconds) liblognorm-utils.x86_64: W: no-documentation liblognorm-utils.x86_64: W: no-manual-page-for-binary lognormalizer liblognorm-debuginfo.x86_64: I: checking liblognorm-debuginfo.x86_64: I: checking-url http://www.liblognorm.com (timeout 10 seconds) 5 packages and 0 specfiles checked; 0 errors, 4 warnings. The spelling error is not a real error. Missing documentation and manual page is upstream issue. Tarball matches the upstream sources. The package complies with Fedora packaging and licensing guidelines. The package is ACCEPTED. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Tomas Mraz tm...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 mahaveer darade mdar...@redhat.com changed: What|Removed |Added CC||asalk...@redhat.com, ||extras-orphan@fedoraproject ||.org, sd...@redhat.com Component|Package Review |pacemaker-cloud Flags|fedora-review+ | --- Comment #11 from mahaveer darade mdar...@redhat.com --- Thank you all for the review of all three packages. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Steven Dake sd...@redhat.com changed: What|Removed |Added Component|pacemaker-cloud |Package Review Assignee|tm...@redhat.com|nob...@fedoraproject.org --- Comment #12 from Steven Dake sd...@redhat.com --- reassigning to package review component since this is not pacemaker-cloud component and pacemaker-cloud has been dropped from Fedora. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Steven Dake sd...@redhat.com changed: What|Removed |Added CC||paulo.cesar.pereira.de.andr ||a...@gmail.com Component|Package Review |0ad Blocks||177841 (FE-NEEDSPONSOR) Assignee|nob...@fedoraproject.org|tm...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Steven Dake sd...@redhat.com changed: What|Removed |Added Component|0ad |Package Review Assignee|tm...@redhat.com|nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Steven Dake sd...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Tomas Mraz tm...@redhat.com changed: What|Removed |Added CC||tm...@redhat.com --- Comment #7 from Tomas Mraz tm...@redhat.com --- The %description for the main package should be at least slightly more descriptive. And the %description of the utils subpackage contains error 'its' is mistaken for 'it is'. The same mistake as in libee and libestr is repeated here - the first sentence in COPYING contradicts with the contents of COPYING and the source files. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #8 from Michael Schwendt mschwe...@gmail.com --- And the %description of the utils subpackage contains error 'its' is mistaken for 'it is'. See comment 4. it is or it's would not form a valid sentence, because an article such as a or the would be missing: | The lognormalizer is the core of liblognorm, it's utility for | normalizing log files. So, either add the missing article or rephrase. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Miloslav Trmač m...@redhat.com changed: What|Removed |Added CC||m...@redhat.com Component|pacemaker |Package Review -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 mahaveer darade mdar...@redhat.com changed: What|Removed |Added CC||and...@beekhof.net, ||fdini...@redhat.com, ||l...@redhat.com Component|Package Review |pacemaker --- Comment #6 from mahaveer darade mdar...@redhat.com --- I've worked on all the comments provided by Michael and here is a link to updated package. http://siddharths.fedorapeople.org/mahaveer/SPECS/liblognorm.spec http://siddharths.fedorapeople.org/mahaveer/SRPMS/liblognorm-0.3.4-3.fc15.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #5 from Milan Bartos mbar...@redhat.com --- Normalizer has been renamed in liblognorm 0.3.5 to lognormalizer to be more poignant. (http://www.liblognorm.com/tag/0-3-5/) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388
Michael Schwendt mschwe...@gmail.com changed:
What|Removed |Added
CC||mschwe...@gmail.com
--- Comment #4 from Michael Schwendt mschwe...@gmail.com ---
Release: 2
Not using %dist during review is okay, but be aware of future trouble when
building the package for multiple dists.
Summary: Tool to normalize log data
The library is not really a tool. The pkgconfig file contains a good
description that could be used for a better %summary:
Description: fast samples-based log normalization library
* The pkgconfig file as is won't work flawlessly. It contains
Libs: -L${libdir} -llognorm -lee -lestr
which means a Requires dependency is missing in the file, or else one could
not link successfully. However, explicitly relinking with shared libee and
libestr should not be necessary when linking with liblognorm, so these two
linker options should be dropped.
Some of liblognorm's header files access libee/libestr headers, so clearly a
Requires: libee-devel libestr-devel is needed in the liblognorm-devel
package. Note that adding a dependency to the .pc file would result in
automatic RPM dependencies.
%package devel
Requires: %{name} = %{version}-%{release}
%package utils
Requires: %{name} = %{version}-%{release}
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
%description utils
The normalizer is the core of liblognorm, it's utility for normalizing
log files.
s/it's/its/ ?
%build
make
V=1 make for more verbose output (compiler and linker options) in build log
would be nice. Plus (albeit this is just a small source project):
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
%install
make install -p DESTDIR=%{buildroot}
Option -p is very likely a mistake here as it is passed to make and is short
for --print-data-base. Assumably, what you actually want is:
make install INSTALL=install -p DESTDIR=%{buildroot}
$ rpmls -p liblognorm-utils-0.3.4-2.t1.x86_64.rpm
-rwxr-xr-x /usr/bin/normalizer
A very generic name, not in a special namespace, and almost caused a conflict
already:
# repoquery --whatprovides /usr/bin/normalize
normalize-0:0.7.7-6.fc17.x86_64
Upstream is highly encouraged to try to avoid using such generic names.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Depends On||847811, 847817 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #2 from mahaveer darade mdar...@redhat.com --- Done. All the changes suggested in comment#1 are in-place below are new rpmlint logs. [root@mdarade guest]# rpmlint -i liblognorm.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i liblognorm-0.3.4-2.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [root@mdarade guest]# rpmlint -i liblognorm*x86_64*.rpm liblognorm-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. liblognorm-utils.x86_64: W: spelling-error Summary(en_US) Normalizer - Normalize, Normalizes, Normalized The value of this tag appears to be misspelled. Please double-check. liblognorm-utils.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. liblognorm-utils.x86_64: W: no-manual-page-for-binary normalizer Each executable in standard binary directories should have a man page. 4 packages and 0 specfiles checked; 0 errors, 4 warnings. [root@mdarade guest]# -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 --- Comment #3 from mahaveer darade mdar...@redhat.com --- Forgot to mention updated link to SRPM so here it is: http://theinric.fedorapeople.org/liblognorm/liblognorm-0.3.4-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 Milan Bartos mbar...@redhat.com changed: What|Removed |Added CC||mbar...@redhat.com --- Comment #1 from Milan Bartos mbar...@redhat.com --- Hi, this is just an informational review. 1. liblognorm requires libestr, it should be in BuildRequires 2. %clean tag is not necessary 3. use INSTALL='install -p' Regards, Milan -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848388] Review Request: liblognorm - Tool to normalize log data
https://bugzilla.redhat.com/show_bug.cgi?id=848388 mahaveer darade mdar...@redhat.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
