[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851746 Bug 851746 depends on bug 851745, which changed state. Bug 851745 Summary: Review Request: python-bitlyapi - A thin python wrapper for the bit.ly REST API https://bugzilla.redhat.com/show_bug.cgi?id=851745 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=szzXXUTlqma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851746 Bug 851746 depends on bug 851745, which changed state. Bug 851745 Summary: Review Request: python-bitlyapi - A thin python wrapper for the bit.ly REST API https://bugzilla.redhat.com/show_bug.cgi?id=851745 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pehMDn6GPaa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746 Bug 851746 depends on bug 851745, which changed state. Bug 851745 Summary: Review Request: python-bitlyapi - A thin python wrapper for the bit.ly REST API https://bugzilla.redhat.com/show_bug.cgi?id=851745 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746 Ralph Bean rb...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Last Closed||2012-09-03 13:11:14 --- Comment #7 from Ralph Bean rb...@redhat.com --- Updates - https://admin.fedoraproject.org/updates/bitlyclip -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746 --- Comment #4 from Ralph Bean rb...@redhat.com --- Thanks again, Mario. I just learned how to use help2man, so that might be a good candidate here. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746 Ralph Bean rb...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Ralph Bean rb...@redhat.com --- New Package SCM Request === Package Name: bitlyclip Short Description: Shorten urls in the X clipboard with bit.ly Owners: ralph Branches: f17 f18 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #3 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4442247
$ rpmlint -i -v *
bitlyclip.src: I: checking
bitlyclip.src: W: spelling-error Summary(en_US) urls - curls, purls, hurls
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error Summary(en_US) ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error %description -l en_US url - URL, curl, purl
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error %description -l en_US ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error %description -l en_US hotkey - hokey, hockey,
hot key
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: I: checking-url http://pypi.python.org/pypi/bitlyclip (timeout
10 seconds)
bitlyclip.src: I: checking-url
http://pypi.python.org/packages/source/b/bitlyclip/bitlyclip-0.2.2.tar.gz
(timeout 10 seconds)
bitlyclip.noarch: I: checking
bitlyclip.noarch: W: spelling-error Summary(en_US) urls - curls, purls, hurls
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error Summary(en_US) ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error %description -l en_US url - URL, curl,
purl
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error %description -l en_US ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error %description -l en_US hotkey - hokey,
hockey, hot key
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: I: checking-url http://pypi.python.org/pypi/bitlyclip
(timeout 10 seconds)
bitlyclip.noarch: W: no-manual-page-for-binary bitlyclip
Each executable in standard binary directories should have a man page.
bitlyclip.spec: I: checking-url
http://pypi.python.org/packages/source/b/bitlyclip/bitlyclip-0.2.2.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 11 warnings.
Almost the same as for your first package, nothing worth to discuss.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv3+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
812f5949bc921826735c1eda065c058eba3f910c664c369bfb443dfeec69da7e
bitlyclip-0.2.2.tar.gz
812f5949bc921826735c1eda065c058eba3f910c664c369bfb443dfeec69da7e
bitlyclip-0.2.2.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||mario.blaetterm...@gmail.co
||m
Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
||m
Flags||fedora-review?
--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
$ rpmlint -i -v *
bitlyclip.noarch: I: checking
bitlyclip.noarch: W: spelling-error Summary(en_US) urls - curls, purls, hurls
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error Summary(en_US) ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error %description -l en_US url - URL, curl,
purl
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error %description -l en_US ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: W: spelling-error %description -l en_US hotkey - hokey,
hockey, hot key
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.noarch: I: checking-url http://pypi.python.org/pypi/bitlyclip
(timeout 10 seconds)
bitlyclip.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/bitlyclip/__init__.py 0644L /usr/bin/env
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed. If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.
bitlyclip.noarch: W: no-manual-page-for-binary bitlyclip
Each executable in standard binary directories should have a man page.
bitlyclip.src: I: checking
bitlyclip.src: W: spelling-error Summary(en_US) urls - curls, purls, hurls
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error Summary(en_US) ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error %description -l en_US url - URL, curl, purl
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error %description -l en_US ly - l, y, lye
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: W: spelling-error %description -l en_US hotkey - hokey, hockey,
hot key
The value of this tag appears to be misspelled. Please double-check.
bitlyclip.src: I: checking-url http://pypi.python.org/pypi/bitlyclip (timeout
10 seconds)
bitlyclip.src: I: checking-url
http://pypi.python.org/packages/source/b/bitlyclip/bitlyclip-0.2.1.tar.gz
(timeout 10 seconds)
bitlyclip.spec: I: checking-url
http://pypi.python.org/packages/source/b/bitlyclip/bitlyclip-0.2.1.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 1 errors, 11 warnings.
Most of the spelling errors are ignorable, just urls could be better URLs.
Please check out what to do with __init__.py. Maybe it helps to add the usual
header for noarch Python packages:
%{!?python_sitelib: %global python_sitelib %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib()))}
Or simply remove the shebang. Scripts in %{python_sitelib} usually don't have
it.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746 --- Comment #2 from Ralph Bean rb...@redhat.com --- Great. I left urls lower-cased... personal preference. I cut a new upstream release that removes the shebang. Spec URL: http://threebean.org/rpm/bitlyclip.spec SRPM URL: http://threebean.org/rpm/bitlyclip-0.2.2-1.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851746] Review Request: bitlyclip - Shorten urls in the X clipboard with bit.ly
https://bugzilla.redhat.com/show_bug.cgi?id=851746 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Depends On||851745 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
