[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7xYEGGVWCL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 Wolfgang Ulbrich changed: What|Removed |Added Flags|fedora-cvs+ | Flags||fedora-cvs? --- Comment #12 from Wolfgang Ulbrich --- Package Change Request == Package Name: emerald-themes New Branches: f17 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OIBAywMBqu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 Wolfgang Ulbrich changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-01-29 02:07:08 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZENWUwGLji&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 Wolfgang Ulbrich changed: What|Removed |Added Status|ASSIGNED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Blj1FZci1r&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 Mario Blättermann changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OySidU1FWG&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gVPIgZMN9X&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #10 from Wolfgang Ulbrich --- sorry, wrong Package Change Request Package Change Request == Package Name: emerald-themes New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jbkNtGd8rQ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 Wolfgang Ulbrich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Wolfgang Ulbrich --- Package Change Request == Package Name: emerald New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oP3vSb0J9Q&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #8 from Wolfgang Ulbrich --- Package Change Request == Package Name: emerald New Branches: f18 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ssg5qwLdFd&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851814
leigh scott changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #7 from leigh scott ---
APPROVED
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/emerald-themes
See:
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[-]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[-]: Package uses nothing in %doc for runtime.
[?]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 1 files have unknown license. Detailed output of
licensecheck in /home/leigh/851814-emerald-themes/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[!]: Package do not use a name that already exist
Note: A package already exist with this name, please check
https://admin.fedoraproject.org/pkgdb/acls/name/emerald-themes
[x]: Package obeys FHS, except libexecdir and /usr/target.
[?]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[?]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[?]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[?]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #6 from leigh scott --- You have a missing buildrequires autoconf + /usr/bin/bzip2 -dc /builddir/build/SOURCES/emerald-themes-0.5.2.tar.bz2 + /usr/bin/tar -xf - + STATUS=0 + '[' 0 -ne 0 ']' + cd emerald-themes-0.5.2 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + autoreconf -v --install /var/tmp/rpm-tmp.0LjNdY: line 37: autoreconf: command not found error: Bad exit status from /var/tmp/rpm-tmp.0LjNdY (%prep) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=HpwaDjoXrW&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #5 from Wolfgang Ulbrich --- Thank you for those hints. %changelog * Thu Jan 10 2013 Wolfgang Ulbrich - 1:0.5.2-8 - own directory - use new upstream package for rpm - generate configure - drop unnecessary command to remove import.sh - remove files with 'bak' instead of '~' - drop unnecessary 'chmod' command new successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4855521 Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/emerald-themes.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/emerald-themes-0.5.2-8.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YFCMiqgaW8&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=851814
--- Comment #4 from leigh scott ---
Please fix
MD5-sum check
-
http://cgit.compiz.org/fusion/decorators/emerald-themes/snapshot/emerald-themes-0.5.2.tar.bz2
:
CHECKSUM(SHA256) this package :
1c2c77a0fff352569a2f013e8b6c1fd99e2b6f9185c9a64d2cf2e918d9de4841
CHECKSUM(SHA256) upstream package :
146b97129675a83cd532646a0a7232ccee222caaa5bb32f802dfd8e7ee34eaac
diff -r also reports differences
And also change from
%files
%doc ChangeLog COPYING README
%{_datadir}/emerald/*
to
%files
%doc ChangeLog COPYING README
%{_datadir}/emerald/themes/
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=URDQESBVsv&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #3 from Wolfgang Ulbrich --- successful scratch build for rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=4840568 Spec URL: http://raveit65.fedorapeople.org/compiz/SPEC/emerald-themes.spec SRPM URL: http://raveit65.fedorapeople.org/compiz/SRPM/emerald-themes-0.5.2-7.fc19.src.rpm ready to review -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LghcTuRQem&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #2 from Wolfgang Ulbrich --- Spec URL:
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
https://bugzilla.redhat.com/show_bug.cgi?id=851814 --- Comment #1 from Wolfgang Ulbrich --- This is a re-review of a retired package. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851814] Review Request: emerald-themes - Themes for Emerald, a window decorator for Compiz Fusion
https://bugzilla.redhat.com/show_bug.cgi?id=851814 leigh scott changed: What|Removed |Added CC||leigh123li...@googlemail.co ||m Assignee|nob...@fedoraproject.org|leigh123li...@googlemail.co ||m -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
