[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819

Mattia Verga  changed:

   What|Removed |Added

 Resolution|--- |CURRENTRELEASE
 Status|POST|CLOSED
Last Closed||2021-07-31 09:56:32



--- Comment #17 from Mattia Verga  ---
Package is available in repos


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #16 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/mingw-sparsehash


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819

Robert-André Mauchin   changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #15 from Robert-André Mauchin   ---
Package approved.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed




= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "BSD 3-clause "New" or "Revised"
 License", "FSF All Permissive License", "Expat License", "NTP
 License". 53 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/mingw-sparsehash/review-
 mingw-sparsehash/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/i686-w64-mingw32/sys-
 root/mingw/include/google(mingw32-protobuf),
 /usr/x86_64-w64-mingw32/sys-
 root/mingw/include/google(mingw64-protobuf)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 61440 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 mingw32-sparsehash , mingw64-sparsehash
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
 Note: mingw32-sparsehash : /usr/i686-w64-mingw32/sys-
 root/mingw/lib/pkgconfig/libsparsehash.pc mingw64-sparsehash :
 /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/libsparsehash.pc
[-]: Sources are verified with gpgverify first in %prep if upstream

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #14 from Thomas Sailer  ---
(In reply to Robert-André Mauchin  from comment #10)

I should have addressed all of your comments.

https://copr.fedorainfracloud.org/coprs/sailer/mingw/build/1545170/

Thanks a lot Robert-André for your review comments!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #13 from Thomas Sailer  ---
> Find an official mirror?

I don't think there's one anymore, ubuntu also uses the github.com version


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #12 from Thomas Sailer  ---
(In reply to Robert-André Mauchin  from comment #11)
> Add %{?mingw_debug_package} before %prep too

This does not work, as sparsehash is a header-only library, there are no
binaries in the package, so debug file lists will be empty and debug package
generation fails


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #11 from Robert-André Mauchin   ---
Add %{?mingw_debug_package} before %prep too


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819

Robert-André Mauchin   changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #10 from Robert-André Mauchin   ---
URL:http://code.google.com/p/sparsehash
Source0:   
http://sparsehash.googlecode.com/files/sparsehash-%{version}.tar.gz

 - Both 404. Find an official mirror?

URL:https://github.com/sparsehash/sparsehash
Source0:%url/archive/sparsehash-%{version}.tar.gz

 - Group: is not used in Fedora

 - License must be included with %license, not %doc:

%files -n mingw32-%{mingw_pkg_name}
%license COPYING
%doc AUTHORS NEWS README TODO
%{mingw32_includedir}/google/
%{mingw32_includedir}/sparsehash/
%{mingw32_libdir}/pkgconfig/libsparsehash.pc

%files -n mingw64-%{mingw_pkg_name}
%license COPYING
%doc AUTHORS NEWS README TODO
%{mingw64_includedir}/google/
%{mingw64_includedir}/sparsehash/
%{mingw64_libdir}/pkgconfig/libsparsehash.pc


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Thomas Sailer  has canceled Package Review
's request for Thomas Sailer
's needinfo:
Bug 851819: Review Request: mingw-sparsehash - MinGW Extremely memory-efficient
C++ hash_map implementation
https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #9 from Thomas Sailer  ---
Update to 2.0.3:
https://sailer.fedorapeople.org/mingw-sparsehash.spec
https://sailer.fedorapeople.org/mingw-sparsehash-2.0.3-1.fc33.src.rpm

copr build:
https://copr.fedorainfracloud.org/coprs/sailer/mingw/build/1544026/
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819

Thomas Sailer  changed:

   What|Removed |Added

  Flags|needinfo?(t.sailer@alumni.e |
   |thz.ch) |



--- Comment #9 from Thomas Sailer  ---
Update to 2.0.3:
https://sailer.fedorapeople.org/mingw-sparsehash.spec
https://sailer.fedorapeople.org/mingw-sparsehash-2.0.3-1.fc33.src.rpm

copr build:
https://copr.fedorainfracloud.org/coprs/sailer/mingw/build/1544026/


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #7 from Upstream Release Monitoring 
 ---
epienbro's scratch build of
mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7 for f23 and
git://pkgs.fedoraproject.org/mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12897715

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #5 from Upstream Release Monitoring 
 ---
epienbro's scratch build of
mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7 for f23 and
git://pkgs.fedoraproject.org/mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12896452

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #6 from Upstream Release Monitoring 
 ---
epienbro's scratch build of
mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7 for f23 and
git://pkgs.fedoraproject.org/mingw-wine-gecko?#f6fe7e9688d9639fa7a1233a68a9862ce0b246e7
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12896755

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #4 from Thomas Sailer  ---
Huh? Since when should failed builds of other packages on epel7 be counted as
lack of submitter response?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819

Thomas Sailer  changed:

   What|Removed |Added

 Blocks|201449 (FE-DEADREVIEW)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819

gil cattaneo  changed:

   What|Removed |Added

 Blocks||201449 (FE-DEADREVIEW)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #1 from Upstream Release Monitoring 
 ---
pbrobinson's scratch build of
mingw-qt5-qtdeclarative?#0591cb7cdaa968100fd75da17c3cd72799f2a797 for
epel7-archbootstrap and
git://pkgs.fedoraproject.org/mingw-qt5-qtdeclarative?#0591cb7cdaa968100fd75da17c3cd72799f2a797
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12038486

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 851819] Review Request: mingw-sparsehash - MinGW Extremely memory-efficient C++ hash_map implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=851819



--- Comment #2 from Upstream Release Monitoring 
 ---
pbrobinson's scratch build of
mingw-qt5-qtbase?#824459d300a4cd07124c3e4967064eec3818d7e2 for
epel7-archbootstrap and
git://pkgs.fedoraproject.org/mingw-qt5-qtbase?#824459d300a4cd07124c3e4967064eec3818d7e2
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12038485

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review