[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nfacct-1.0.0-1.fc18 Resolution|--- |ERRATA Last Closed||2013-07-16 23:06:09 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bE9ZSIywn6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nfacct-1.0.0-1.fc18 |nfacct-1.0.0-1.fc19 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LhI0fNgpqSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nfacct-1.0.0-1.fc19 |nfacct-1.0.0-1.fc17 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.fc17 has been pushed to the Fedora 17 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Hy2K8L0xjUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4dIJAR3lqma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #17 from Jan Klepek jan.kle...@gmail.com --- i did not forgot, today it was uploaded into git, in the evening or tomorrow it will hit build system testing repos. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rn32gECBoma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #20 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nfacct-1.0.0-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=F1PTHIIM6ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cGtzWi95cna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nfacct-1.0.0-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=94r4UfERpMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/nfacct-1.0.0-1.fc17 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UANeP7Khjba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- nfacct-1.0.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nfacct-1.0.0-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UH1A1HNncFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #16 from Mario Blättermann mario.blaetterm...@gmail.com --- Just a reminder... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0W3v1JU3rXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #15 from Mario Blättermann mario.blaetterm...@gmail.com --- Any progress here? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EpZRNm2CQva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #14 from Mario Blättermann mario.blaetterm...@gmail.com --- Ping...? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TKdxDTlkXZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #13 from Jan Klepek jan.kle...@gmail.com --- (In reply to comment #12) is this bug alive ? Hi, I had some healt issues so I didn't had time to continue here, it will be finished during a week -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CtI0LlfuL5a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #12 from Xose Vazquez Perez xose.vazq...@gmail.com --- is this bug alive ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9tReM2Lhlea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 Xose Vazquez Perez xose.vazq...@gmail.com changed: What|Removed |Added CC||xose.vazq...@gmail.com --- Comment #11 from Xose Vazquez Perez xose.vazq...@gmail.com --- will it be ready for fedora 19 ? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Sbcis96314a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3s0a0F2ti4a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 Jan Klepek jan.kle...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Jan Klepek jan.kle...@gmail.com --- New Package SCM Request === Package Name: nfacct Short Description: Command line tool to create/retrieve/delete accounting objects Owners: hpejakle Branches: f17 f18 el5 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kKVHnyW3Gta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #7 from Jan Klepek jan.kle...@gmail.com --- sorry for longer delay, at this time I aim only for Fedora and not EPEL, so please do not consider missing EPEL specific stuff as blocker for this review, EPEL specific things will be added in future -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wqRVs15Kqma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=852185
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |
Flags||fedora-review+
--- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4874484
$ rpmlint -i -v *
nfacct.src: I: checking
nfacct.src: I: checking-url http://www.netfilter.org/projects/nfacct/index.html
(timeout 10 seconds)
nfacct.src: I: checking-url
http://www.netfilter.org/projects/nfacct/files/nfacct-1.0.0.tar.bz2 (timeout 10
seconds)
nfacct.i686: I: checking
nfacct.i686: I: checking-url
http://www.netfilter.org/projects/nfacct/index.html (timeout 10 seconds)
nfacct.i686: E: incorrect-fsf-address /usr/share/doc/nfacct-1.0.0/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
nfacct.x86_64: I: checking
nfacct.x86_64: I: checking-url
http://www.netfilter.org/projects/nfacct/index.html (timeout 10 seconds)
nfacct.x86_64: E: incorrect-fsf-address /usr/share/doc/nfacct-1.0.0/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
nfacct-debuginfo.i686: I: checking
nfacct-debuginfo.i686: I: checking-url
http://www.netfilter.org/projects/nfacct/index.html (timeout 10 seconds)
nfacct-debuginfo.x86_64: I: checking
nfacct-debuginfo.x86_64: I: checking-url
http://www.netfilter.org/projects/nfacct/index.html (timeout 10 seconds)
nfacct.spec: I: checking-url
http://www.netfilter.org/projects/nfacct/files/nfacct-1.0.0.tar.bz2 (timeout 10
seconds)
5 packages and 1 specfiles checked; 2 errors, 0 warnings.
Don't bother with incorrect FSF addresses, just inform upstream that they can
fix it for future releases. Changing a license file is not allowed by the
packaging guidelines anyway.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
GPLv2+
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
eb7e64c3ee4f1e4b5d508e933dc9dc2f91e14ea3ee5f1926aad76c114d1d2014
nfacct-1.0.0.tar.bz2
eb7e64c3ee4f1e4b5d508e933dc9dc2f91e14ea3ee5f1926aad76c114d1d2014
nfacct-1.0.0.tar.bz2.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com --- Ping...? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=UxBzH6G073a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 Bug 852185 depends on bug 848990, which changed state. Bug 848990 Summary: Review Request: libnetfilter_acct - A library providing interface to extended accounting infrastructure https://bugzilla.redhat.com/show_bug.cgi?id=848990 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lvfijmTCzya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Alias||nfacct Flags||fedora-review? --- Comment #5 from Mario Blättermann mario.blaetterm...@gmail.com --- @Jan, libnetfilter_acct will be available soon also for EPEL5, the package has been approved. It would be nice if you could add the specific stuff to your package. See https://bugzilla.redhat.com/show_bug.cgi?id=848990#c8 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=yjoh6cHD5aa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 Jan Klepek jan.kle...@gmail.com changed: What|Removed |Added Flags|needinfo?(jan.klepek@gmail. | |com)| --- Comment #4 from Jan Klepek jan.kle...@gmail.com --- Hi Jia, I see that somebody is already reviewing your package, so if you want to review this one, that will help. Do you have any other package for cross-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=852185 Xose Vazquez Perez xose.vazq...@gmail.com changed: What|Removed |Added CC||xose.vazq...@gmail.com --- Comment #3 from Xose Vazquez Perez xose.vazq...@gmail.com --- ping! -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 Hushan Jia hushan@gmail.com changed: What|Removed |Added CC||hushan@gmail.com Flags||needinfo?(jan.klepek@gmail. ||com) --- Comment #2 from Hushan Jia hushan@gmail.com --- Jan, do you want to do a cross review? to accelerate the both packages to get into f18. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 Jan Klepek jan.kle...@gmail.com changed: What|Removed |Added Depends On||848990 (libnetfilter_acct) -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 852185] Review Request: nfacct - Command line tool to create/retrieve/delete accounting objects
https://bugzilla.redhat.com/show_bug.cgi?id=852185 --- Comment #1 from Jan Klepek jan.kle...@gmail.com --- hpejakle@sapimaa ~/rpmbuild$ rpmlint /var/lib/mock/fedora-17-i386/result/nfacct-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. hpejakle@sapimaa ~/rpmbuild$ rpmlint SPECS/nfacct.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
