[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox

2012-09-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852416

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2012-09-19 03:44:35

--- Comment #7 from Parag pnem...@redhat.com ---
Thanks.

Package is now available in f18 and rawhide as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox

2012-08-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852416

--- Comment #1 from Parag pnem...@redhat.com ---
koji scratch build -
http://koji.fedoraproject.org/koji/taskinfo?taskID=4429668

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox

2012-08-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852416

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||limburg...@gmail.com
   Assignee|nob...@fedoraproject.org|limburg...@gmail.com
  Flags||fedora-review?

--- Comment #2 from Jon Ciesla limburg...@gmail.com ---
Reviewing, I need this for gnugb. . .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox

2012-08-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852416

--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Good:

- rpmlint checks return:

pangox-compat.x86_64: W: conffile-without-noreplace-flag
/etc/pango/pangox.aliases
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

pangox-compat.x86_64: E: incorrect-fsf-address
/usr/share/doc/pangox-compat-0.0.1/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

pangox-compat-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

3 packages and 0 specfiles checked; 1 errors, 2 warnings.

All ignorable given it's a compat package.

- package meets naming guidelines
- package meets packaging guidelines
- license ( LGPLv2+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream  with sha512
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r 

Really clean, good.  Working on mock build to confirm BRs.  Will approve if
that's good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox

2012-08-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852416

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+

--- Comment #4 from Jon Ciesla limburg...@gmail.com ---
Looks good, APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox

2012-08-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852416

Parag pnem...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?

--- Comment #5 from Parag pnem...@redhat.com ---
New Package SCM Request
===
Package Name: pangox-compat
Short Description: Compatibility library for pangox
Owners: pnemade
Branches: f18
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 852416] Review Request: pangox-compat - Compatibility library for pangox

2012-08-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=852416

--- Comment #6 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review