[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #21 from Fedora Update System --- rubygem-clouddb-0.0.1-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #20 from Fedora Update System --- rubygem-clouddb-0.0.1-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=853514 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2012-11-23 02:47:41 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #19 from Fedora Update System --- Package rubygem-clouddb-0.0.1-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rubygem-clouddb-0.0.1-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-17719/rubygem-clouddb-0.0.1-3.fc18 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #18 from Fedora Update System --- rubygem-clouddb-0.0.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-clouddb-0.0.1-3.fc17 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #17 from Fedora Update System --- rubygem-clouddb-0.0.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-clouddb-0.0.1-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #16 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Alejandro_Perez changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Alejandro_Perez --- I think the right request New Package SCM Request === Package Name: rubygem-clouddb Short Description: Ruby interface into the Rackspace Cloud DB service Owners: aeperezt Branches: f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #14 from Alejandro_Perez --- Sorry about that Jon New Package SCM Request === Package Name: rubygem-clouddb Short Description: Ruby interface into the Rackspace Cloud DB service Owners: aeperezt Branches: f18 f17 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #13 from Jon Ciesla --- WARNING: "Ruby-SIG" is not a valid FAS account. WARNING: Requested package name Rubygem-clouddb doesn't match bug summary rubygem-clouddb -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Alejandro_Perez changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from Alejandro_Perez --- New Package SCM Request === Package Name: Rubygem-clouddb Short Description: Ruby interface into the Rackspace Cloud DB service Owners: aeperezt Branches: f18 f17 el6 InitialCC: Ruby-SIG -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #11 from Jon Ciesla --- No SCM request present. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Alejandro_Perez changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Guillermo Gómez changed: What|Removed |Added Flags|fedora-review? | Flags||fedora-review+ --- Comment #10 from Guillermo Gómez --- :) Issues fixed APPROVED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #9 from Alejandro_Perez --- Details noted and fixed. Thanks for the advice. http://aeperezt.fedorapeople.org/rpmdev/rubygem-clouddb-0.0.1-3.fc17.src.rpm rpmlint SPECS/rubygem-clouddb.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-clouddb-0.0.1-3.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint RPMS/noarch/rubygem-clouddb-0.0.1-3.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint RPMS/noarch/rubygem-clouddb-doc-0.0.1-3.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514
--- Comment #8 from Guillermo Gómez ---
Package Review
==
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
===
[x]: Package contains Requires: ruby(abi).
See: http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_ABI
[!]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
Please fix:
Replace
%{gem_instdir}/COPYING
with
%doc %{gem_instdir}/COPYING
[!]: Specfile should use macros from rubygem-devel package.
Note: The specfile doesn't use following macro: %doc %{gem_docdir}
Please use %{gem_docdir} in
%doc %{gem_dir}/doc << actually wrong, claiming ownership of
/usr/share/rubygems/doc
Replace with which points to the right files.
%doc %{gem_docdir}
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[ ]: Large documentation files are in a -doc subpackage, if required.
[!]: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
Provides are present.
[x]: Package must own all directories that it creates.
[!]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Ruby:
[x]: Gem package must not define a non-gem subpackage
[ ]: Platform dependent files must all go under %{gem_extdir}, platform
independent under %{gem_dir}.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package contains Requires: ruby(abi).
= SHOULD items =
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Latest version is packaged.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define.
Ruby:
[x]: Gem package should exclude cached Gem.
[!]: Specfile should use macros from rubygem-devel package.
Note: The specfile doesn't use these macros: %doc %{gem_docdir}
Please use %{gem_docdir} in
%doc %{gem_dir}/doc << actually wrong, claiming ownership of
/usr/share/rubygems/doc
%doc %{gem_docdir}
[x]: Test suite should not be run by rak
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #7 from Alejandro_Perez --- Here is the url http://aeperezt.fedorapeople.org/rpmdev/rubygem-clouddb-0.0.1-2.fc17.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #6 from Alejandro_Perez --- Well the dependant of rubygem-ffi is needed by rubygem-typhoeus that is require by rubygem-clouddb, so if that requirement is meet by rubygem-typhoeus it should not be included on clouddb gem at lease that is what I think. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #5 from Guillermo Gómez --- Actually the gem not being listed issue is because of wrong location of the files, just remove the unnecesary macros. Test if rubygem-ffi is really needed at runtime (it was used during gem install clouddb in my workstation). -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #4 from Guillermo Gómez --- I tried to install rubygem-clouddb using gem command in a mock and found it uses ffi. The actual rubygem-clouddb is not listed. Missing BuildRequire from upstream as i see. gem list does not list clouddb after rpm installation. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #3 from Guillermo Gómez --- links? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Guillermo Gómez changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 --- Comment #2 from Alejandro_Perez --- Changes done as suggested thanks rpmlint rubygem-clouddb.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-clouddb-0.0.1-2.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint RPMS/noarch/rubygem-clouddb-0.0.1-2.fc17.noarch.rpm rubygem-clouddb.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514
Guillermo Gómez changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Guillermo Gómez ---
Unneeded macros...
%global gem_dir /usr/share/rubygems
%global gem_instdir %{gem_dir}/gems/%{gem_name}-%{version}
%global gem_docdir %{gem_dir}/doc/%{gem_name}-%{version}
%global gem_libdir %{gem_instdir}/lib
All of them are provided by rubygems-devel.
Source0:http://rubygems.org/downloads/clouddb-0.0.1.gem
Please use macros for name and version, sample:
Source0: http://rubygems.org/downloads/%{gem_name}-%{version}.gem
The rest looks good to me :) Please fix to go a second round.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 853514] Review Request: rubygem-clouddb - Ruby interface into the Rackspace Cloud DB service
https://bugzilla.redhat.com/show_bug.cgi?id=853514 Guillermo Gómez changed: What|Removed |Added CC||guillermo.go...@gmail.com Assignee|nob...@fedoraproject.org|guillermo.go...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
