[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 gil cattaneo changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 --- Comment #14 from gil cattaneo --- Package Change Request == Package Name: jcsp New Branches: f20 Owners: gil InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jcsp-1.1-0.2.rc5.fc21 Resolution|--- |ERRATA Last Closed||2014-11-14 07:05:38 --- Comment #13 from Fedora Update System --- jcsp-1.1-0.2.rc5.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 gil cattaneo changed: What|Removed |Added Blocks||1163724 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1163724 [Bug 1163724] Review Request: gpars - Groovy Parallel Systems -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- jcsp-1.1-0.2.rc5.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 --- Comment #11 from Fedora Update System --- jcsp-1.1-0.2.rc5.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/jcsp-1.1-0.2.rc5.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 gil cattaneo changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #9 from gil cattaneo --- git process has failed, please, re-run your script New Package SCM Request === Package Name: jcsp Short Description: Communicating Sequential Processes for Java (JCSP) Owners: gil Branches: f21 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from gil cattaneo --- Thanks! New Package SCM Request === Package Name: jcsp Short Description: Communicating Sequential Processes for Java (JCSP) Owners: gil Branches: f21 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Michael Simacek changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Michael Simacek --- Now it looks ok. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 --- Comment #5 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/jcsp.spec SRPM URL: http://gil.fedorapeople.org/jcsp-1.1-0.2.rc5.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237
--- Comment #4 from gil cattaneo ---
(In reply to Michael Simacek from comment #3)
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
>
> Issues
> ==
> - It is recognized as native library and ends up in %{_jnidir}. But the
> only load call I see is in windows-only part.
Strange i already remove that code part
> - description - see rpmlint warnings
Already fixed ...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237
--- Comment #3 from Michael Simacek ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues
==
- It is recognized as native library and ends up in %{_jnidir}. But the
only load call I see is in windows-only part.
- description - see rpmlint warnings
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or
generated". 94 files have unknown license. Detailed output of
licensecheck in /home/msimacek/reviews/854237-jcsp/srpm-unpacked/review-
jcsp/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-metadata
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separ
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 --- Comment #2 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/jcsp.spec SRPM URL: http://gil.fedorapeople.org/jcsp-1.1-1.fc19.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7990213 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 Michael Simacek changed: What|Removed |Added Status|NEW |ASSIGNED CC||msima...@redhat.com Assignee|nob...@fedoraproject.org|msima...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 gil cattaneo changed: What|Removed |Added Alias||jcsp --- Comment #1 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/jcsp.spec SRPM URL: http://gil.fedorapeople.org/jcsp-1.1-0.1.rc5.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9R1IL93WJR&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 854237] Review Request: jcsp - Communicating Sequential Processes for Java (JCSP)
https://bugzilla.redhat.com/show_bug.cgi?id=854237 gil cattaneo changed: What|Removed |Added Blocks||854239 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
