[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||tesla-polyglot-0.1.0-2.fc21 Resolution|--- |ERRATA Last Closed||2014-11-01 12:54:05 --- Comment #23 from Fedora Update System --- tesla-polyglot-0.1.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- tesla-polyglot-0.1.0-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 --- Comment #21 from Fedora Update System --- tesla-polyglot-0.1.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/tesla-polyglot-0.1.0-2.fc21 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 --- Comment #20 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 Bug 855331 depends on bug 859711, which changed state. Bug 859711 Summary: Review Request: jruby-maven-plugins - JRuby Maven Mojos https://bugzilla.redhat.com/show_bug.cgi?id=859711 What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #19 from gil cattaneo --- Thanks for the review! New Package SCM Request === Package Name: tesla-polyglot Short Description: Modules to enable Maven usage in other JVM languages Owners: gil Branches: f21 InitialCC: java-sig -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331
Michael Simacek changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #18 from Michael Simacek ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"MIT/X11 (BSD like)", "Unknown or generated". 122 files have unknown
license. Detailed output of licensecheck in /home/msimacek/855331-tesla-
polyglot/licensecheck.txt
The files under MIT don't end up in binary RPM
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-poms/tesla-polyglot, /usr/share
/maven-metadata
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/maven-poms/tesla-
polyglot, /usr/share/maven-metadata, /usr/share/java/tesla-polyglot
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It is
pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: If package uses '-Dmaven.local.depmap' explain why it was needed in a
comment
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_ma
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331
--- Comment #17 from gil cattaneo ---
(In reply to Mikolaj Izdebski from comment #16)
> Works for me with the following changes:
> 1. I had to add BR on ant-junit, without that it didn't build for me
Done
> 2. I added alias needed by Gradle:
> %mvn_alias ':tesla-polyglot-{*}' org.sonatype.pmaven:pmaven-@1
Done
Spec URL: http://gil.fedorapeople.org/tesla-polyglot.spec
SRPM URL: http://gil.fedorapeople.org/tesla-polyglot-0.1.0-2.fc19.src.rpm
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331
--- Comment #16 from Mikolaj Izdebski ---
Works for me with the following changes:
1. I had to add BR on ant-junit, without that it didn't build for me
2. I added alias needed by Gradle:
%mvn_alias ':tesla-polyglot-{*}' org.sonatype.pmaven:pmaven-@1
--
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855331] Review Request: tesla-polyglot - Modules to enable Maven usage in other JVM languages
https://bugzilla.redhat.com/show_bug.cgi?id=855331 gil cattaneo changed: What|Removed |Added Summary|Review Request: |Review Request: |tesla-polyglot - Modules to |tesla-polyglot - Modules to |enable Maven usage in |enable Maven usage in other |others JVM languages|JVM languages -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
